From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA080C433E6 for ; Mon, 8 Feb 2021 16:03:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57FEE64DED for ; Mon, 8 Feb 2021 16:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57FEE64DED Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=xenproject.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.82940.153446 (Exim 4.92) (envelope-from ) id 1l990g-0002P6-TD; Mon, 08 Feb 2021 16:03:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 82940.153446; Mon, 08 Feb 2021 16:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l990g-0002Oz-Q2; Mon, 08 Feb 2021 16:03:34 +0000 Received: by outflank-mailman (input) for mailman id 82940; Mon, 08 Feb 2021 16:03:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l990f-0002Ou-Cw for xen-devel@lists.xenproject.org; Mon, 08 Feb 2021 16:03:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l990f-0007ZJ-A0 for xen-devel@lists.xenproject.org; Mon, 08 Feb 2021 16:03:33 +0000 Received: from iwj (helo=mariner.uk.xensource.com) by xenbits.xenproject.org with local-bsmtp (Exim 4.92) (envelope-from ) id 1l990f-0006Hj-9A for xen-devel@lists.xenproject.org; Mon, 08 Feb 2021 16:03:33 +0000 Received: from iwj by mariner.uk.xensource.com with local (Exim 4.89) (envelope-from ) id 1l990c-0002s1-2l; Mon, 08 Feb 2021 16:03:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=References:In-Reply-To:Subject:Cc:To:Date :Message-ID:Content-Transfer-Encoding:Content-Type:MIME-Version:From; bh=ULoVTlqYjIo5XPRNUVxoY3zeGP2Wlvk1S89eRa24Ado=; b=djMfHjqlfuMEn9okbZfhmvxWca tkcf4Ay1KJ8w1eclFe5+OeQV+yLTRE4mFNwSQMif3am51rCW/3rzqQNPJ/nRPriXNNBaYzrrQyjnS nkLY7hQRcBjaCENqcJz1+lOibo4CMkOKN9fAoLvGkK0xe7v02s429fXwb7oTz9uD/pfg=; From: Ian Jackson MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <24609.24785.791060.128298@mariner.uk.xensource.com> Date: Mon, 8 Feb 2021 16:03:29 +0000 To: Olaf Hering Cc: xen-devel@lists.xenproject.org, Wei Liu Subject: Re: [PATCH v20210111 05/39] tools: add with-xen-scriptdir configure option In-Reply-To: <20210111174224.24714-6-olaf@aepfle.de> References: <20210111174224.24714-1-olaf@aepfle.de> <20210111174224.24714-6-olaf@aepfle.de> X-Mailer: VM 8.2.0b under 24.5.1 (i686-pc-linux-gnu) Olaf Hering writes ("[PATCH v20210111 05/39] tools: add with-xen-scriptdir configure option"): > In the near future all fresh installations will have an empty /etc. > The content of this directory will not be controlled by the package > manager anymore. One of the reasons for this move is to make snapshots > more robust. As I wrote in September 2019 I don't agree with it, if it's intended as a claim about all systems that Xen will run on. However, this seems to be an accidental retention in the commit message, since the content of the commit is now what I asked for, which is to make this directory configurable. So I approve of the contents of this patch in principle. > As a first step into this direction, add a knob to configure to allow > storing the hotplug scripts to libexec because they are not exactly > configuration. The current default is unchanged, which is > /etc/xen/scripts. I suggest this commit message as a compromise: Some distros plan for fresh installations will have an empty /etc, whose content will not be controlled by the package manager anymore. To make this possible, add a knob to configure to allow storing the hotplug scripts to libexec instead of /etc/xen/scripts. Olaf, would that be OK with you ? As for detailed review: > diff --git a/m4/paths.m4 b/m4/paths.m4 > index 89d3bb8312..0cec2bb190 100644 > --- a/m4/paths.m4 > +++ b/m4/paths.m4 ... > +AC_ARG_WITH([xen-scriptdir], > + AS_HELP_STRING([--with-xen-scriptdir=DIR], > + [Path to directory for dom0 hotplug scripts. [SYSCONFDIR/xen/scripts]]), > + [xen_scriptdir_path=$withval], > + [xen_scriptdir_path=$sysconfdir/xen/scripts]) ... > -XEN_SCRIPT_DIR=$XEN_CONFIG_DIR/scripts > +XEN_SCRIPT_DIR=$xen_scriptdir_path > AC_SUBST(XEN_SCRIPT_DIR) It is not clear to me why the deefault is changed from "$XEN_CONFIG_DIR/scripts" to "$sysconfdir/xen/scripts" and there isn't any explanation for this in the commit message. I think this may make no difference but an explanation is called for. As for the release ack question: there is a risk that this patch would break the build, by causing the scripts to go somewhere wrong. This risk seems fairly low and osstest would catch it. However, I find it difficult to analyse the consequence of the changed way the default is calculated. So, a conditional release ack: Release-Acked-by: Ian Jackson subject to changing this patch to make the actual implemented default to still be $XEN_CONFIG_DIR/scripts. Ian.