From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: linux-next: Tree for August 19: CRED: BUG: bad unlock balance detected! Date: Tue, 19 Aug 2008 16:23:18 +0100 Message-ID: <24643.1219159398@redhat.com> References: Return-path: Received: from mx1.redhat.com ([66.187.233.31]:60474 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbYHSPXe (ORCPT ); Tue, 19 Aug 2008 11:23:34 -0400 In-Reply-To: Sender: linux-next-owner@vger.kernel.org List-ID: To: Alexander Beregalov Cc: dhowells@redhat.com, linux-next@vger.kernel.org, LKML Alexander Beregalov wrote: > [ 25.742287] [ BUG: bad unlock balance detected! ] > [ 25.750284] ------------------------------------- > [ 25.758404] rc/404 is trying to release lock (&p->cred_exec_mutex) at: > [ 25.766716] [<00000000006aff78>] mutex_unlock+0x10/0x20 > [ 25.775078] but there are no more locks to release! I forgot to lock cred_exec_mutex in compat_do_execve(). I've posted a patch which should fix this: Subject: [PATCH] CRED: Take cred_exec_mutex in compat_do_execve() and fix error handling in do_execve() David