Re: [RFC PATCH v7 03/37] x86/apic: KVM: Deduplicate APIC vector => register+bit math

[Neeraj Upadhyay <Neeraj.Upadhyay@amd.com>]

On 6/23/2025 5:19 PM, Borislav Petkov wrote:
> On Tue, Jun 10, 2025 at 11:23:50PM +0530, Neeraj Upadhyay wrote:
>> diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
>> index 23d86c9750b9..c84d4e86fe4e 100644
>> --- a/arch/x86/include/asm/apic.h
>> +++ b/arch/x86/include/asm/apic.h
>> @@ -488,11 +488,14 @@ static inline void apic_setup_apic_calls(void) { }
>>  
>>  extern void apic_ack_irq(struct irq_data *data);
>>  
>> +#define APIC_VECTOR_TO_BIT_NUMBER(v) ((unsigned int)(v) % 32)
>> +#define APIC_VECTOR_TO_REG_OFFSET(v) ((unsigned int)(v) / 32 * 0x10)
> 
> Dunno - I'd probably shorten those macro names:
> 
> APIC_VEC_TO_BITNUM()
> APIC_VEC_TO_REGOFF()
> 
> because this way of shortening those words is very common and is still very
> readable, even if not fully written out...
> 

Sounds good to me. Will change this in next version (will also wait for Sean's
comment on this).

> LGTM regardless.
> 

Thanks!

- Neeraj

> Thx.
>