All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joseph Qi <jiangqi903@gmail.com>
To: Pavel Begunkov <asml.silence@gmail.com>,
	Jens Axboe <axboe@kernel.dk>,
	io-uring@vger.kernel.org
Subject: Re: [PATCH 0/3] files cancellation cleanup
Date: Fri, 22 Jan 2021 17:45:11 +0800	[thread overview]
Message-ID: <246d838d-0fce-d3c3-dcfc-9cbf9fa72de1@gmail.com> (raw)
In-Reply-To: <cover.1611109718.git.asml.silence@gmail.com>

Seems this series can also resolve a possible deadlock case I'm looking
into.

CPU0:
...
io_kill_linked_timeout  // &ctx->completion_lock
io_commit_cqring
__io_queue_deferred
__io_queue_async_work
io_wq_enqueue
io_wqe_enqueue  // &wqe->lock

CPU1:
...
__io_uring_files_cancel
io_wq_cancel_cb
io_wqe_cancel_pending_work  // &wqe->lock
io_cancel_task_cb  // &ctx->completion_lock

Thanks,
Joseph

On 1/20/21 10:32 AM, Pavel Begunkov wrote:
> Carefully remove leftovers from removing cancellations by files
> 
> Pavel Begunkov (3):
>   io_uring: remove cancel_files and inflight tracking
>   io_uring: cleanup iowq cancellation files matching
>   io_uring: don't pass files for cancellation
> 
>  fs/io_uring.c | 168 ++++++++++----------------------------------------
>  1 file changed, 32 insertions(+), 136 deletions(-)
> 

  parent reply	other threads:[~2021-01-22  9:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  2:32 [PATCH 0/3] files cancellation cleanup Pavel Begunkov
2021-01-20  2:32 ` [PATCH 1/3] io_uring: remove cancel_files and inflight tracking Pavel Begunkov
2021-01-20  2:32 ` [PATCH 2/3] io_uring: cleanup iowq cancellation files matching Pavel Begunkov
2021-01-20  2:32 ` [PATCH 3/3] io_uring: don't pass files for cancellation Pavel Begunkov
2021-01-20  3:13 ` [PATCH 0/3] files cancellation cleanup Jens Axboe
2021-01-22  9:45 ` Joseph Qi [this message]
2021-01-22 21:49   ` Pavel Begunkov
2021-01-25  2:14     ` Joseph Qi
2021-01-25 10:48       ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=246d838d-0fce-d3c3-dcfc-9cbf9fa72de1@gmail.com \
    --to=jiangqi903@gmail.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.