From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2] drm/i915: Beef up the IPS vs. CRC workaround Date: Thu, 17 Aug 2017 10:00:52 +0200 Message-ID: <2470960b-986e-e746-a1f0-24ea8790e975@linux.intel.com> References: <20161221093105.19120-1-ville.syrjala@linux.intel.com> <20170816143902.28641-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFB866E570 for ; Thu, 17 Aug 2017 08:00:56 +0000 (UTC) In-Reply-To: <20170816143902.28641-1-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: ville.syrjala@linux.intel.com, intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T3AgMTYtMDgtMTcgb20gMTY6Mzkgc2NocmVlZiB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bToKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29t Pgo+Cj4gT25lc2hvdCBkaXNhYmxpbmcgb2YgSVBTIHdoZW4gQ1JDIGNhcHR1cmluZyBpcyBzdGFy dGVkIGlzIGluc3VmZmljaWVudC4KPiBJUFMgbWF5IGdldCByZS1lbmFibGVkIGJ5IGFueSBwbGFu ZSB1cGRhdGUsIGFuZCBoZW5jZSB0ZXN0cyB0aGF0IGtlZXAKPiBDUkMgY2FwdHVyaW5nIG9uIGFj cm9zcyBwbGFuZSB1cGRhdGVzIHdpbGwgc3RhcnQgdG8gc2VlIGluY29uc2lzdGVudAo+IHJlc3Vs dHMgYXMgc29vbiBhcyBJUFMga2lja3MgYmFjayBpbi4gQWRkIGEgbmV3IGtub2IgaW50byB0aGUg Y3J0YyBzdGF0ZQo+IHRvIG1ha2Ugc3VyZSBJUFMgc3RheXMgZGlzYWJsZWQgYXMgbG9uZyBhcyBD UkMgY2FwdHVyaW5nIGlzIGVuYWJsZWQuCj4KPiBGb3JjaW5nIGEgbW9kZXNldCBpcyB0aGUgZWFz aWVzdCB3YXkgdG8gaGFuZGxlIHRoaXMgc2luY2UgdGhhdCdzIGFscmVhZHkKPiBob3cgd2UgZG8g dGhlIHBhbmVsIGZpdHRlciB3b3JrYXJvdW5kLiBJdCdzIGEgbGl0dGxlIGhlYXZ5IGhhbmRlZCBq dXN0Cj4gZm9yIElQUywgYnV0IHNlZWluZyBhcyB3ZSBtaWdodCBhbHJlYWR5IGRvIHRoZSBwYW5l bCBmaXR0ZXIgd29ya2Fyb3VuZAo+IEkgdGhpbmsgaXQncyBiZXR0ZXIgdG8gZm9sbG93IHRoYXQu IFdlIG1pZ3RoIHdhbnQgdG8gb3B0aW1pemUgYm90aCBjYXNlcwo+IGxhdGVyIGlmIHNvbWVvbmUg Z2V0cyB0b28gdXBzZXQgYnkgdGhlIGV4dHJhIGRlbGF5IGZyb20gdGhlIG1vZGVzZXQuCj4KPiB2 MjogQ2hlY2sgdGhlIHJpZ2h0IHRoaW5nIHdoZW4gZGVjaWRpbmcgd2hldGhlciB0byBmb3JjZSBh IG1vZGVzZXQKPgo+IENjOiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIuemFub25pQGludGVsLmNvbT4K PiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPiBDYzogTWFy dGEgTG9mc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGludGVsLmNvbT4KPiBCdWd6aWxsYTogaHR0cHM6 Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAxNjY0Cj4gUmV2aWV3ZWQt Ynk6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgfCAgNSArKystCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgfCAgMSArCj4gIGRyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMgfCA0MyArKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyksIDIxIGRlbGV0 aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGVmNWRk ZTVhYjFjZi4uMWNlNDc5NjE0ZjUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3Bs YXkuYwo+IEBAIC03MTg5LDYgKzcxODksNyBAQCBzdGF0aWMgdm9pZCBoc3dfY29tcHV0ZV9pcHNf Y29uZmlnKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICAKPiAgCXBpcGVfY29uZmlnLT5pcHNfZW5h YmxlZCA9IGk5MTUuZW5hYmxlX2lwcyAmJgo+ICsJCSFwaXBlX2NvbmZpZy0+aXBzX2ZvcmNlX2Rp c2FibGUgJiYKPiAgCQloc3dfY3J0Y19zdXBwb3J0c19pcHMoY3J0YykgJiYKPiAgCQlwaXBlX2Nv bmZpZ19zdXBwb3J0c19pcHMoZGV2X3ByaXYsIHBpcGVfY29uZmlnKTsKPiAgfQo+IEBAIC0xMjk1 OCw3ICsxMjk1OSw3IEBAIGNsZWFyX2ludGVsX2NydGNfc3RhdGUoc3RydWN0IGludGVsX2NydGNf c3RhdGUgKmNydGNfc3RhdGUpCj4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zY2FsZXJfc3RhdGUgc2Nh bGVyX3N0YXRlOwo+ICAJc3RydWN0IGludGVsX2RwbGxfaHdfc3RhdGUgZHBsbF9od19zdGF0ZTsK PiAgCXN0cnVjdCBpbnRlbF9zaGFyZWRfZHBsbCAqc2hhcmVkX2RwbGw7Cj4gLQlib29sIGZvcmNl X3RocnU7Cj4gKwlib29sIGZvcmNlX3RocnUsIGlwc19mb3JjZV9kaXNhYmxlOwo+ICAKPiAgCS8q IEZJWE1FOiBiZWZvcmUgdGhlIHN3aXRjaCB0byBhdG9taWMgc3RhcnRlZCwgYSBuZXcgcGlwZV9j b25maWcgd2FzCj4gIAkgKiBremFsbG9jJ2QuIENvZGUgdGhhdCBkZXBlbmRzIG9uIGFueSBmaWVs ZCBiZWluZyB6ZXJvIHNob3VsZCBiZQo+IEBAIC0xMjk3MCw2ICsxMjk3MSw3IEBAIGNsZWFyX2lu dGVsX2NydGNfc3RhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAlz aGFyZWRfZHBsbCA9IGNydGNfc3RhdGUtPnNoYXJlZF9kcGxsOwo+ICAJZHBsbF9od19zdGF0ZSA9 IGNydGNfc3RhdGUtPmRwbGxfaHdfc3RhdGU7Cj4gIAlmb3JjZV90aHJ1ID0gY3J0Y19zdGF0ZS0+ cGNoX3BmaXQuZm9yY2VfdGhydTsKPiArCWlwc19mb3JjZV9kaXNhYmxlID0gY3J0Y19zdGF0ZS0+ aXBzX2ZvcmNlX2Rpc2FibGU7Cj4gIAo+ICAJbWVtc2V0KGNydGNfc3RhdGUsIDAsIHNpemVvZiAq Y3J0Y19zdGF0ZSk7Cj4gIAo+IEBAIC0xMjk3OCw2ICsxMjk4MCw3IEBAIGNsZWFyX2ludGVsX2Ny dGNfc3RhdGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpCj4gIAljcnRjX3N0 YXRlLT5zaGFyZWRfZHBsbCA9IHNoYXJlZF9kcGxsOwo+ICAJY3J0Y19zdGF0ZS0+ZHBsbF9od19z dGF0ZSA9IGRwbGxfaHdfc3RhdGU7Cj4gIAljcnRjX3N0YXRlLT5wY2hfcGZpdC5mb3JjZV90aHJ1 ID0gZm9yY2VfdGhydTsKPiArCWNydGNfc3RhdGUtPmlwc19mb3JjZV9kaXNhYmxlID0gaXBzX2Zv cmNlX2Rpc2FibGU7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+IGluZGV4IDAyNWU0YzhiM2U2My4uY2FkYmE5YjkyY2M5IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBAQCAtNjUxLDYgKzY1MSw3IEBAIHN0cnVjdCBpbnRlbF9jcnRjX3N0 YXRlIHsKPiAgCXN0cnVjdCBpbnRlbF9saW5rX21fbiBmZGlfbV9uOwo+ICAKPiAgCWJvb2wgaXBz X2VuYWJsZWQ7Cj4gKwlib29sIGlwc19mb3JjZV9kaXNhYmxlOwpDb3VsZCB3ZSByZW5hbWUgdGhp cyB0byBjb2xsZWN0aW5nX2NyYyB0aHJvdWdob3V0IHRoZSBwYXRjaD8KCkFuZCBhcyBNYXJ0YSBu b3RlZCwgaW50ZWxfY3J0Y19zZXRfY3JjX3NvdXJjZSBhbHNvIG5lZWRzIGZpeGluZy4gOikKPiAg Cj4gIAlib29sIGVuYWJsZV9mYmM7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9waXBlX2NyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9j cmMuYwo+IGluZGV4IGVmMGMwZTE5NTE2NC4uNzQ3ODBiMDkwZDFlIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9waXBlX2NyYy5jCj4gQEAgLTU0Nyw4ICs1NDcsOCBAQCBzdGF0aWMgaW50 IGlsa19waXBlX2NyY19jdGxfcmVnKGVudW0gaW50ZWxfcGlwZV9jcmNfc291cmNlICpzb3VyY2Us Cj4gIAlyZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaHN3X3RyYW5zX2VkcF9waXBl X0FfY3JjX3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJCQlib29s IGVuYWJsZSkKPiArc3RhdGljIHZvaWQgaHN3X3BpcGVfQV9jcmNfd2Eoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2LAo+ICsJCQkgICAgICBib29sIGVuYWJsZSkKPiAgewo+ICAJc3Ry dWN0IGRybV9kZXZpY2UgKmRldiA9ICZkZXZfcHJpdi0+ZHJtOwo+ICAJc3RydWN0IGludGVsX2Ny dGMgKmNydGMgPSBpbnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXZfcHJpdiwgUElQRV9BKTsKPiBA QCAtNTcwLDExICs1NzAsMjMgQEAgc3RhdGljIHZvaWQgaHN3X3RyYW5zX2VkcF9waXBlX0FfY3Jj X3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlnb3RvIG91dDsKPiAg CX0KPiAgCj4gLQlwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZm9yY2VfdGhydSA9IGVuYWJsZTsKPiAt CWlmIChwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIgPT0gVFJBTlNDT0RFUl9FRFAgJiYKPiAt CSAgICBwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZCAhPSBlbmFibGUpCj4gKwkvKgo+ICsJ ICogV2hlbiBJUFMgZ2V0cyBlbmFibGVkLCB0aGUgcGlwZSBDUkMgY2hhbmdlcy4gU2luY2UgSVBT IGdldHMKPiArCSAqIGVuYWJsZWQgYW5kIGRpc2FibGVkIGR5bmFtaWNhbGx5IGJhc2VkIG9uIHBh Y2thZ2UgQyBzdGF0ZXMsCj4gKwkgKiB1c2VyIHNwYWNlIGNhbid0IG1ha2UgcmVsaWFibGUgdXNl IG9mIHRoZSBDUkNzLCBzbyBsZXQncyBqdXN0Cj4gKwkgKiBjb21wbGV0ZWx5IGRpc2FibGUgaXQu Cj4gKwkgKi8KPiArCXBpcGVfY29uZmlnLT5pcHNfZm9yY2VfZGlzYWJsZSA9IGVuYWJsZTsKPiAr CWlmIChwaXBlX2NvbmZpZy0+aXBzX2VuYWJsZWQgPT0gZW5hYmxlKQo+ICAJCXBpcGVfY29uZmln LT5iYXNlLmNvbm5lY3RvcnNfY2hhbmdlZCA9IHRydWU7Cj4gIAo+ICsJaWYgKElTX0hBU1dFTEwo ZGV2X3ByaXYpKSB7Cj4gKwkJcGlwZV9jb25maWctPnBjaF9wZml0LmZvcmNlX3RocnUgPSBlbmFi bGU7Cj4gKwkJaWYgKHBpcGVfY29uZmlnLT5jcHVfdHJhbnNjb2RlciA9PSBUUkFOU0NPREVSX0VE UCAmJgo+ICsJCSAgICBwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZCAhPSBlbmFibGUpCj4g KwkJCXBpcGVfY29uZmlnLT5iYXNlLmNvbm5lY3RvcnNfY2hhbmdlZCA9IHRydWU7Cj4gKwl9Cj4g Kwo+ICAJcmV0ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ICBvdXQ6Cj4gIAlXQVJOKHJl dCwgIlRvZ2dsaW5nIHdvcmthcm91bmQgdG8gJWkgcmV0dXJucyAlaVxuIiwgZW5hYmxlLCByZXQp Owo+IEBAIC01OTgsOCArNjEwLDkgQEAgc3RhdGljIGludCBpdmJfcGlwZV9jcmNfY3RsX3JlZyhz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJKnZhbCA9IFBJUEVfQ1JDX0VO QUJMRSB8IFBJUEVfQ1JDX1NPVVJDRV9TUFJJVEVfSVZCOwo+ICAJCWJyZWFrOwo+ICAJY2FzZSBJ TlRFTF9QSVBFX0NSQ19TT1VSQ0VfUEY6Cj4gLQkJaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpICYm IHBpcGUgPT0gUElQRV9BKQo+IC0JCQloc3dfdHJhbnNfZWRwX3BpcGVfQV9jcmNfd2EoZGV2X3By aXYsIHRydWUpOwo+ICsJCWlmICgoSVNfSEFTV0VMTChkZXZfcHJpdikgfHwKPiArCQkgICAgIElT X0JST0FEV0VMTChkZXZfcHJpdikpICYmIHBpcGUgPT0gUElQRV9BKQo+ICsJCQloc3dfcGlwZV9B X2NyY193YShkZXZfcHJpdiwgdHJ1ZSk7Cj4gIAo+ICAJCSp2YWwgPSBQSVBFX0NSQ19FTkFCTEUg fCBQSVBFX0NSQ19TT1VSQ0VfUEZfSVZCOwo+ICAJCWJyZWFrOwo+IEBAIC02MTgsNyArNjMxLDYg QEAgc3RhdGljIGludCBwaXBlX2NyY19zZXRfc291cmNlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdiwKPiAgCQkJICAgICAgIGVudW0gaW50ZWxfcGlwZV9jcmNfc291cmNlIHNvdXJj ZSkKPiAgewo+ICAJc3RydWN0IGludGVsX3BpcGVfY3JjICpwaXBlX2NyYyA9ICZkZXZfcHJpdi0+ cGlwZV9jcmNbcGlwZV07Cj4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9IGludGVsX2dldF9j cnRjX2Zvcl9waXBlKGRldl9wcml2LCBwaXBlKTsKPiAgCWVudW0gaW50ZWxfZGlzcGxheV9wb3dl cl9kb21haW4gcG93ZXJfZG9tYWluOwo+ICAJdTMyIHZhbCA9IDA7IC8qIHNodXQgdXAgZ2NjICov Cj4gIAlpbnQgcmV0Owo+IEBAIC02NjUsMTQgKzY3Nyw2IEBAIHN0YXRpYyBpbnQgcGlwZV9jcmNf c2V0X3NvdXJjZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCWdvdG8g b3V0Owo+ICAJCX0KPiAgCj4gLQkJLyoKPiAtCQkgKiBXaGVuIElQUyBnZXRzIGVuYWJsZWQsIHRo ZSBwaXBlIENSQyBjaGFuZ2VzLiBTaW5jZSBJUFMgZ2V0cwo+IC0JCSAqIGVuYWJsZWQgYW5kIGRp c2FibGVkIGR5bmFtaWNhbGx5IGJhc2VkIG9uIHBhY2thZ2UgQyBzdGF0ZXMsCj4gLQkJICogdXNl ciBzcGFjZSBjYW4ndCBtYWtlIHJlbGlhYmxlIHVzZSBvZiB0aGUgQ1JDcywgc28gbGV0J3MganVz dAo+IC0JCSAqIGNvbXBsZXRlbHkgZGlzYWJsZSBpdC4KPiAtCQkgKi8KPiAtCQloc3dfZGlzYWJs ZV9pcHMoY3J0Yyk7Cj4gLQo+ICAJCXNwaW5fbG9ja19pcnEoJnBpcGVfY3JjLT5sb2NrKTsKPiAg CQlrZnJlZShwaXBlX2NyYy0+ZW50cmllcyk7Cj4gIAkJcGlwZV9jcmMtPmVudHJpZXMgPSBlbnRy aWVzOwo+IEBAIC03MTMsMTAgKzcxNyw5IEBAIHN0YXRpYyBpbnQgcGlwZV9jcmNfc2V0X3NvdXJj ZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAkJCWc0eF91bmRvX3BpcGVf c2NyYW1ibGVfcmVzZXQoZGV2X3ByaXYsIHBpcGUpOwo+ICAJCWVsc2UgaWYgKElTX1ZBTExFWVZJ RVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2X3ByaXYpKQo+ICAJCQl2bHZfdW5kb19w aXBlX3NjcmFtYmxlX3Jlc2V0KGRldl9wcml2LCBwaXBlKTsKPiAtCQllbHNlIGlmIChJU19IQVNX RUxMKGRldl9wcml2KSAmJiBwaXBlID09IFBJUEVfQSkKPiAtCQkJaHN3X3RyYW5zX2VkcF9waXBl X0FfY3JjX3dhKGRldl9wcml2LCBmYWxzZSk7Cj4gLQo+IC0JCWhzd19lbmFibGVfaXBzKGNydGMp Owo+ICsJCWVsc2UgaWYgKChJU19IQVNXRUxMKGRldl9wcml2KSB8fAo+ICsJCQkgIElTX0JST0FE V0VMTChkZXZfcHJpdikpICYmIHBpcGUgPT0gUElQRV9BKQo+ICsJCQloc3dfcGlwZV9BX2NyY193 YShkZXZfcHJpdiwgZmFsc2UpOwo+ICAJfQo+ICAKPiAgCXJldCA9IDA7CgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlz dApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==