All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Cc: dev <dev@dpdk.org>, David Wilder <dwilder@us.ibm.com>,
	Dmitry Kozliuk <dmitry.kozliuk@gmail.com>,
	Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] test: set iova=va mode on ppc64 with --no-huge
Date: Wed, 06 Mar 2024 18:50:08 +0100	[thread overview]
Message-ID: <2481220.uoxibFcf9D@thomas> (raw)
In-Reply-To: <CAMw=ZnRmgKfUjQeeR+rTfOwJn7MCGu7it8B9UawGSMwWtzXVZQ@mail.gmail.com>

28/11/2023 15:56, Luca Boccassi:
> On Tue, 28 Nov 2023 at 14:40, <christian.ehrhardt@canonical.com> wrote:
> >
> > From: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> >
> > On ppc64, without huge pages, pa would be the default but fails like:
> >   EAL: Cannot use IOVA as 'PA' since physical addresses are not available
> >
> > On a normal system setup we'd expect an admin to set up huge pages
> > and for the unlikely case that they do not do that set iova=va
> > themselve. But the testing infrastructure does not have this conscious
> > admin that will do that, so fix test execution that by adjusting the
> > tests arguments accordingly if the conditions are met.
> >
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Moved the comment inside the "if condition" context.

Applied, thanks.




      reply	other threads:[~2024-03-06 17:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 14:40 [PATCH] test: set iova=va mode on ppc64 with --no-huge christian.ehrhardt
2023-11-28 14:56 ` Luca Boccassi
2024-03-06 17:50   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2481220.uoxibFcf9D@thomas \
    --to=thomas@monjalon.net \
    --cc=bluca@debian.org \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dwilder@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.