From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Paul Turner <pjt@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
paulmck <paulmck@linux.ibm.com>,
Boqun Feng <boqun.feng@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Dmitry Vyukov <dvyukov@google.com>,
linux-api <linux-api@vger.kernel.org>
Subject: Re: [RFC PATCH 2/4] rseq: Fix: Unregister rseq for CLONE_TLS
Date: Tue, 10 Sep 2019 20:31:01 -0400 (EDT) [thread overview]
Message-ID: <248314994.16.1568161861658.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20190911002744.8690-2-mathieu.desnoyers@efficios.com>
Of course, this patch title should read:
rseq: Fix: Unregister rseq for CLONE_SETTLS
----- On Sep 11, 2019, at 1:27 AM, Mathieu Desnoyers mathieu.desnoyers@efficios.com wrote:
> /*
> * If parent process has a registered restartable sequences area, the
> - * child inherits. Only applies when forking a process, not a thread.
> + * child inherits. Unregister rseq for a clone with CLONE_TLS set.
and here CLONE_SETTLS as well.
> */
> static inline void rseq_fork(struct task_struct *t, unsigned long clone_flags)
> {
> - if (clone_flags & CLONE_THREAD) {
> + if (clone_flags & CLONE_TLS) {
.. and here.
Thanks,
Mathieu
> t->rseq = NULL;
> t->rseq_sig = 0;
> t->rseq_event_mask = 0;
> --
> 2.17.1
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2019-09-11 0:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 0:27 [RFC PATCH 1/4] rseq: Fix: Reject unknown flags on rseq unregister Mathieu Desnoyers
2019-09-11 0:27 ` [RFC PATCH 2/4] rseq: Fix: Unregister rseq for CLONE_TLS Mathieu Desnoyers
2019-09-11 0:31 ` Mathieu Desnoyers [this message]
2019-09-11 0:27 ` [RFC PATCH 3/4] rseq: Introduce unreg_clone_flags Mathieu Desnoyers
2019-09-13 14:26 ` Mathieu Desnoyers
2019-09-11 0:27 ` [RFC PATCH 4/4] rseq/selftests: Use RSEQ_FLAG_UNREG_CLONE_FLAGS Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248314994.16.1568161861658.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=boqun.feng@gmail.com \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.