Re: [PATCH v3 2/2] platform/x86: hp-bioscfg: remove dead bounds check in audit_log_entries_show

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2453 bytes --]

On Wed, 19 Aug 2026, Muhammad Bilal wrote:

> audit_log_entries_show() checks "count * LOG_ENTRY_SIZE > PAGE_SIZE"
> prior to entering the loop. Because "count" is already bounded to fit
> within PAGE_SIZE, the inner loop check "(LOG_ENTRY_SIZE * i) > PAGE_SIZE"
> can never be reached and is dead code.
> 
> Remove the redundant inner bounds check and eliminate the unnecessary
> "else" block after "break" to clean up the loop control flow.
> 
> Signed-off-by: Muhammad Bilal <meatuni001@gmail.com>
> ---
> Changes in v3:
>   - Remove the dead inner loop check completely instead of adjusting
>     the boundary arithmetic, as noted by Ilpo Järvinen.
>   - Remove the redundant else block after break.
> 
> Changes in v2:
>   - None for this patch; resubmitted as part of the v2 series.
> 
> Link: https://lore.kernel.org/r/20260803143037.93105-1-meatuni001@gmail.com [v1]
> Link: https://lore.kernel.org/r/20260812111829.172273-1-meatuni001@gmail.com [v2]
> ---
>  drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
> index b57e42f29282..3b20757a3e74 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
> @@ -93,15 +93,12 @@ static ssize_t audit_log_entries_show(struct kobject *kobj,
>  					   HPWMI_SURESTART,
>  					   audit_log_buffer, 1, 128);
>  
> -		if (ret < 0 || (LOG_ENTRY_SIZE * i) > PAGE_SIZE) {
> -			/*
> -			 * Encountered a failure while reading
> -			 * individual logs. Only a partial list of
> -			 * audit log will be returned.
> -			 */
> +		/*
> +		 * Encountered a failure while reading individual logs.
> +		 * Only a partial list of audit log will be returned.
> +		 */
> +		if (ret < 0)
>  			break;
> -		} else {
> -			memcpy(buf, audit_log_buffer, LOG_ENTRY_SIZE);
> -			buf += LOG_ENTRY_SIZE;
> -		}
> +
> +		memcpy(buf, audit_log_buffer, LOG_ENTRY_SIZE);
> +		buf += LOG_ENTRY_SIZE;
>  	}
>  
>  	return i * LOG_ENTRY_SIZE;
> 

Patch 1 didn't apply without special trickery, this patch 2 doesn't even 
get that far:

checking file drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c
patch: **** malformed patch at line 65:         }

:-(

-- 
 i.