From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
WenjieX A Li <wenjiex.a.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed"
Date: Thu, 25 Apr 2019 10:19:28 +0200 [thread overview]
Message-ID: <2485235.lFPfLJtBTM@xps> (raw)
In-Reply-To: <20190424220309.84270-1-ferruh.yigit@intel.com>
25/04/2019 00:03, Ferruh Yigit:
> This reverts commit bdca79053b6aea504d02691d9319fa976062457f.
>
> Not all PMDs support the fixed link speed set, and link speed can be set
> even with auto negotiation enabled. Reverting the patch to not break
> existing usage.
Which PMDs do not support this flag?
Why not fixing the PMDs?
next prev parent reply other threads:[~2019-04-25 8:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 22:03 [dpdk-dev] [PATCH] Revert "app/testpmd: set fixed flag for exact link speed" Ferruh Yigit
2019-04-25 8:19 ` Thomas Monjalon [this message]
2019-04-25 11:47 ` Ferruh Yigit
2019-04-25 13:29 ` Thomas Monjalon
2019-04-25 15:27 ` Ferruh Yigit
2019-04-29 9:52 ` Thomas Monjalon
2019-05-02 18:31 ` Ferruh Yigit
2019-05-02 20:27 ` Thomas Monjalon
2019-05-04 20:45 ` Thomas Monjalon
2019-05-06 8:09 ` Andrew Rybchenko
2019-05-07 10:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2485235.lFPfLJtBTM@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenjiex.a.li@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.