From: Jan Beulich <jbeulich@suse.com>
To: Alejandro Vallejo <alejandro.garciavallejo@amd.com>
Cc: "Andrew Cooper" <andrew.cooper3@citrix.com>,
"Roger Pau Monné" <roger.pau@citrix.com>,
"Daniel P. Smith" <dpsmith@apertussolutions.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 0/4] Add Kconfig option to remove microcode loading support
Date: Thu, 13 Nov 2025 08:36:21 +0100 [thread overview]
Message-ID: <248593ca-e24a-4518-800e-2c58e3197937@suse.com> (raw)
In-Reply-To: <20251112162219.226075-1-alejandro.garciavallejo@amd.com>
On 12.11.2025 17:22, Alejandro Vallejo wrote:
> Hi,
>
> The series is mostly a refactor between everything needed to load microcode and
> the bare minimum to probe the current microcode revision.
>
> The Kconfig option keeps the reading of microcode rev data around, as it's very
> relevant for security and debuggability in order to deduce which erratas apply
> to the current platform.
>
> The idea is to move everything that must still be compiled with !CONFIG_UCODE
> onto {,amd-,intel-}base.c, then remove everything else conditionally at the
> Makefile level.
>
> Renaming files (e.g: s/base/core/ and s/core/common/) would better reflect
> post-series reality, but it'd be annoying for later backports in this general
> area.
>
> Cheers,
> Alejandro
>
> Alejandro Vallejo (4):
> x86: Split out AMD-specific code to be executed without ucode loading
> x86: Split out Intel-specific code to be executed without ucode
> loading
> x86: Split out early_microcode_load() and microcode_load_one()
> x86: Add Kconfig option to disable microcode loading
>
> xen/arch/x86/Kconfig | 12 ++++
> xen/arch/x86/cpu/microcode/Makefile | 9 ++-
> xen/arch/x86/cpu/microcode/amd-base.c | 55 +++++++++++++++++++
> xen/arch/x86/cpu/microcode/amd.c | 55 ++-----------------
> xen/arch/x86/cpu/microcode/amd.h | 15 +++++
> xen/arch/x86/cpu/microcode/base.c | 73 +++++++++++++++++++++++++
> xen/arch/x86/cpu/microcode/core.c | 58 +-------------------
> xen/arch/x86/cpu/microcode/intel-base.c | 50 +++++++++++++++++
> xen/arch/x86/cpu/microcode/intel.c | 56 +++----------------
> xen/arch/x86/cpu/microcode/intel.h | 16 ++++++
> xen/arch/x86/cpu/microcode/private.h | 14 +++++
> xen/arch/x86/efi/efi-boot.h | 2 +-
> xen/arch/x86/platform_hypercall.c | 2 +
> 13 files changed, 259 insertions(+), 158 deletions(-)
> create mode 100644 xen/arch/x86/cpu/microcode/amd-base.c
> create mode 100644 xen/arch/x86/cpu/microcode/amd.h
> create mode 100644 xen/arch/x86/cpu/microcode/base.c
> create mode 100644 xen/arch/x86/cpu/microcode/intel-base.c
> create mode 100644 xen/arch/x86/cpu/microcode/intel.h
Purely based on this diffstat: A doc update likely is necessary as well, as
the ucode= command line option now becomes only conditionally applicable (aiui,
i.e. without having looked at the patches them selves).
Jan
next prev parent reply other threads:[~2025-11-13 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 16:22 [PATCH 0/4] Add Kconfig option to remove microcode loading support Alejandro Vallejo
2025-11-12 16:22 ` [PATCH 1/4] x86: Split out AMD-specific code to be executed without ucode loading Alejandro Vallejo
2025-11-12 16:22 ` [PATCH 2/4] x86: Split out Intel-specific " Alejandro Vallejo
2025-11-12 16:22 ` [PATCH 3/4] x86: Split out early_microcode_load() and microcode_load_one() Alejandro Vallejo
2025-11-12 16:22 ` [PATCH 4/4] x86: Add Kconfig option to disable microcode loading Alejandro Vallejo
2025-11-13 7:36 ` Jan Beulich [this message]
2025-11-13 12:12 ` [PATCH 0/4] Add Kconfig option to remove microcode loading support Alejandro Vallejo
2025-11-13 8:50 ` Andrew Cooper
2025-11-13 12:11 ` Alejandro Vallejo
2025-11-17 16:55 ` Jan Beulich
2025-11-18 10:19 ` Alejandro Vallejo
2025-11-18 11:22 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248593ca-e24a-4518-800e-2c58e3197937@suse.com \
--to=jbeulich@suse.com \
--cc=alejandro.garciavallejo@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=dpsmith@apertussolutions.com \
--cc=marmarek@invisiblethingslab.com \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.