From: Martin Schiller <ms@dev.tdt.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
f.fainelli@gmail.com, davem@davemloft.net
Subject: Re: [PATCH v2] net: phy: mdio-gpio: fix access that may sleep
Date: Wed, 14 Nov 2018 08:43:49 +0100 [thread overview]
Message-ID: <248deac95f412b925b0de44ead2ffec6@dev.tdt.de> (raw)
In-Reply-To: <20181114070528.GD17052@lunn.ch>
On 2018-11-14 08:05, Andrew Lunn wrote:
> On Wed, Nov 14, 2018 at 07:37:03AM +0100, Martin Schiller wrote:
>> This commit re-enables support for slow GPIO pins. It was initially
>> introduced by commit
>> 2d6c9091ab7630dfcf34417c6683ce4764d7d40a
>> and got lost by commit
>> 7e5fbd1e0700f1bdb94508f84ec2aeb01eed7b12
>
> Hi Martin
>
> Was it really lost? It looks like _cansleep() just adds an extra check
> might_sleep_if(extra_checks), but it does not change any
> functionality.
Well, you are right, the functionality itself is not broken, but using
the NON _cansleep() functions on GPIOs that have the cansleep flag set,
this leads to a lot of kernel warnings/backtraces which makes the system
in fact useless.
Thats the WARN_ON() here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpio/gpiolib.c?h=v4.20-rc2#n2992
and here:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpio/gpiolib.c?h=v4.20-rc2#n3304
>
> So the change itself is O.K, i'm just not too sure about the commit
> message.
>
> Andrew
Hmm, ok. What would you suggest for a better commit message?
I thought it would be helpful to know that this was already in there
and got (inadvertently?) removed by another commit.
Martin
next prev parent reply other threads:[~2018-11-14 7:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 6:17 [PATCH] net: phy: mdio-gpio: fix access that may sleep Martin Schiller
2018-11-14 6:37 ` [PATCH v2] " Martin Schiller
2018-11-14 7:05 ` Andrew Lunn
2018-11-14 7:43 ` Martin Schiller [this message]
2018-11-14 20:46 ` Andrew Lunn
2018-11-14 9:20 ` Sergei Shtylyov
2018-11-17 3:52 ` David Miller
2018-11-14 10:12 ` [PATCH v3] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs Martin Schiller
2018-11-14 11:03 ` Sergei Shtylyov
2018-11-14 11:54 ` [PATCH v4] " Martin Schiller
2018-11-17 4:25 ` David Miller
2018-11-17 6:28 ` Andrew Lunn
2018-11-15 5:24 ` [PATCH v5] " Martin Schiller
2018-11-15 20:12 ` Andrew Lunn
2018-11-17 7:04 ` David Miller
2018-11-16 7:38 ` [PATCH v6] " Martin Schiller
2018-11-16 7:53 ` Andrew Lunn
2018-11-17 19:52 ` Florian Fainelli
2018-11-18 5:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=248deac95f412b925b0de44ead2ffec6@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.