Re: [PATCH net-next] vrf: use dev_replace_track() for better tracking

[David Ahern <dsahern@gmail.com>]

On 12/6/21 10:56 PM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
> 
> vrf_rt6_release() and vrf_rtable_release() changes dst->dev
> 
> Instead of
> 
> dev_hold(ndev);
> dev_put(odev);
> 
> We should use
> 
> dev_replace_track(odev, ndev, &dst->dev_tracker, GFP_KERNEL);
> 
> If we do not transfer dst->dev_tracker to the new device,
> we will get warnings from ref_tracker_dir_exit() when odev
> is finally dismantled.
> 
> Fixes: 9038c320001d ("net: dst: add net device refcount tracking to dst_entry")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  drivers/net/vrf.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 


Reviewed-by: David Ahern <dsahern@kernel.org>