From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Fri, 22 Dec 2017 14:08:20 +0200 Subject: [PATCH v5 01/12] dt-bindings: panel: lvds: Document power-supply property In-Reply-To: <0a6a3abcf1a6b7f0e66a81af8a44c5c0566ce06c.1513854122.git-series.maxime.ripard@free-electrons.com> References: <0a6a3abcf1a6b7f0e66a81af8a44c5c0566ce06c.1513854122.git-series.maxime.ripard@free-electrons.com> Message-ID: <2493504.1OPucrC18r@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Maxime, Thank you for the patch. On Thursday, 21 December 2017 13:02:27 EET Maxime Ripard wrote: > The power-supply property is used by a vast majority of panels, including > panel-simple. Let's document it as a common property > > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/panel/panel-common.txt | 6 ++++++ > Documentation/devicetree/bindings/display/panel/panel-lvds.txt | 1 + > Documentation/devicetree/bindings/display/panel/simple-panel.txt | 2 +- 3 > files changed, 8 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/panel/panel-common.txt > b/Documentation/devicetree/bindings/display/panel/panel-common.txt index > ec52c472c845..125ea68052af 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.txt > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.txt > @@ -78,6 +78,12 @@ used for panels that implement compatible control > signals. while active. Active high reset signals can be supported by > inverting the GPIO specifier polarity flag. > > +Power > +----- > + > +- power-supply: many display panels need an additional power supply in > + order to be fully powered-up. For such panels, power-supply contains > + a phandle to the regulator powering the panel. I think we should give more details here about the limitations of this property. How about the following explanation ? - power-supply: display panels require power to be supplied. While several panels need more than one power supply with panel-specific constraints governing the order and timings of the power supplies, in many cases a single power supply is sufficient, either because the panel has a single power rail, or because all its power rails can be driven by the same supply. In that case the power-supply property specifies the supply powering the panel as a phandle to a regulator. > Backlight > --------- > diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.txt > b/Documentation/devicetree/bindings/display/panel/panel-lvds.txt index > b938269f841e..250850a2150b 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.txt > +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.txt > @@ -32,6 +32,7 @@ Optional properties: > - label: See panel-common.txt. > - gpios: See panel-common.txt. > - backlight: See panel-common.txt. > +- power-supply: See panel-common.txt. > - data-mirror: If set, reverse the bit order described in the data mappings > below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to > 6. > diff --git > a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > b/Documentation/devicetree/bindings/display/panel/simple-panel.txt index > 1341bbf4aa3d..16d8ff088b7d 100644 > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > @@ -1,7 +1,7 @@ > Simple display panel > > Required properties: > -- power-supply: regulator to provide the supply voltage > +- power-supply: See panel-common.txt > > Optional properties: > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v5 01/12] dt-bindings: panel: lvds: Document power-supply property Date: Fri, 22 Dec 2017 14:08:20 +0200 Message-ID: <2493504.1OPucrC18r@avalon> References: <0a6a3abcf1a6b7f0e66a81af8a44c5c0566ce06c.1513854122.git-series.maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <0a6a3abcf1a6b7f0e66a81af8a44c5c0566ce06c.1513854122.git-series.maxime.ripard@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: Mark Rutland , Thomas Petazzoni , jernej.skrabec@siol.net, plaes@plaes.org, devicetree@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Rob Herring , thierry.reding@gmail.com, Daniel Vetter , linux-arm-kernel@lists.infradead.org, icenowy@aosc.io List-Id: devicetree@vger.kernel.org SGkgTWF4aW1lLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMjEgRGVj ZW1iZXIgMjAxNyAxMzowMjoyNyBFRVQgTWF4aW1lIFJpcGFyZCB3cm90ZToKPiBUaGUgcG93ZXIt c3VwcGx5IHByb3BlcnR5IGlzIHVzZWQgYnkgYSB2YXN0IG1ham9yaXR5IG9mIHBhbmVscywgaW5j bHVkaW5nCj4gcGFuZWwtc2ltcGxlLiBMZXQncyBkb2N1bWVudCBpdCBhcyBhIGNvbW1vbiBwcm9w ZXJ0eQo+IAo+IFJldmlld2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+IFNp Z25lZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAZnJlZS1lbGVjdHJvbnMu Y29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9w YW5lbC9wYW5lbC1jb21tb24udHh0IHwgNiArKysrKysKPiBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9wYW5lbC1sdmRzLnR4dCAgIHwgMSArCj4gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2ltcGxlLXBhbmVsLnR4 dCB8IDIgKy0gMwo+IGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQo+IAo+IGRpZmYgLS1naXQKPiBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k aXNwbGF5L3BhbmVsL3BhbmVsLWNvbW1vbi50eHQKPiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3BhbmVsLWNvbW1vbi50eHQgaW5kZXgKPiBlYzUyYzQ3 MmM4NDUuLjEyNWVhNjgwNTJhZiAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9wYW5lbC1jb21tb24udHh0Cj4gKysrIGIvRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvcGFuZWwtY29tbW9uLnR4 dAo+IEBAIC03OCw2ICs3OCwxMiBAQCB1c2VkIGZvciBwYW5lbHMgdGhhdCBpbXBsZW1lbnQgY29t cGF0aWJsZSBjb250cm9sCj4gc2lnbmFscy4gd2hpbGUgYWN0aXZlLiBBY3RpdmUgaGlnaCByZXNl dCBzaWduYWxzIGNhbiBiZSBzdXBwb3J0ZWQgYnkKPiBpbnZlcnRpbmcgdGhlIEdQSU8gc3BlY2lm aWVyIHBvbGFyaXR5IGZsYWcuCj4gCj4gK1Bvd2VyCj4gKy0tLS0tCj4gKwo+ICstIHBvd2VyLXN1 cHBseTogbWFueSBkaXNwbGF5IHBhbmVscyBuZWVkIGFuIGFkZGl0aW9uYWwgcG93ZXIgc3VwcGx5 IGluCj4gKyAgb3JkZXIgdG8gYmUgZnVsbHkgcG93ZXJlZC11cC4gRm9yIHN1Y2ggcGFuZWxzLCBw b3dlci1zdXBwbHkgY29udGFpbnMKPiArICBhIHBoYW5kbGUgdG8gdGhlIHJlZ3VsYXRvciBwb3dl cmluZyB0aGUgcGFuZWwuCgpJIHRoaW5rIHdlIHNob3VsZCBnaXZlIG1vcmUgZGV0YWlscyBoZXJl IGFib3V0IHRoZSBsaW1pdGF0aW9ucyBvZiB0aGlzIApwcm9wZXJ0eS4gSG93IGFib3V0IHRoZSBm b2xsb3dpbmcgZXhwbGFuYXRpb24gPwoKLSBwb3dlci1zdXBwbHk6IGRpc3BsYXkgcGFuZWxzIHJl cXVpcmUgcG93ZXIgdG8gYmUgc3VwcGxpZWQuIFdoaWxlIHNldmVyYWwgCnBhbmVscyBuZWVkIG1v cmUgdGhhbiBvbmUgcG93ZXIgc3VwcGx5IHdpdGggcGFuZWwtc3BlY2lmaWMgY29uc3RyYWludHMg CmdvdmVybmluZyB0aGUgb3JkZXIgYW5kIHRpbWluZ3Mgb2YgdGhlIHBvd2VyIHN1cHBsaWVzLCBp biBtYW55IGNhc2VzIGEgc2luZ2xlIApwb3dlciBzdXBwbHkgaXMgc3VmZmljaWVudCwgZWl0aGVy IGJlY2F1c2UgdGhlIHBhbmVsIGhhcyBhIHNpbmdsZSBwb3dlciByYWlsLCAKb3IgYmVjYXVzZSBh bGwgaXRzIHBvd2VyIHJhaWxzIGNhbiBiZSBkcml2ZW4gYnkgdGhlIHNhbWUgc3VwcGx5LiBJbiB0 aGF0IGNhc2UgCnRoZSBwb3dlci1zdXBwbHkgcHJvcGVydHkgc3BlY2lmaWVzIHRoZSBzdXBwbHkg cG93ZXJpbmcgdGhlIHBhbmVsIGFzIGEgcGhhbmRsZSAKdG8gYSByZWd1bGF0b3IuCgo+ICBCYWNr bGlnaHQKPiAgLS0tLS0tLS0tCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3BhbmVsLWx2ZHMudHh0Cj4gYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9wYW5lbC1sdmRzLnR4dCBpbmRleAo+ IGI5MzgyNjlmODQxZS4uMjUwODUwYTIxNTBiIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3BhbmVsLWx2ZHMudHh0Cj4gKysrIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvcGFuZWwtbHZk cy50eHQKPiBAQCAtMzIsNiArMzIsNyBAQCBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ICAtIGxhYmVs OiBTZWUgcGFuZWwtY29tbW9uLnR4dC4KPiAgLSBncGlvczogU2VlIHBhbmVsLWNvbW1vbi50eHQu Cj4gIC0gYmFja2xpZ2h0OiBTZWUgcGFuZWwtY29tbW9uLnR4dC4KPiArLSBwb3dlci1zdXBwbHk6 IFNlZSBwYW5lbC1jb21tb24udHh0Lgo+ICAtIGRhdGEtbWlycm9yOiBJZiBzZXQsIHJldmVyc2Ug dGhlIGJpdCBvcmRlciBkZXNjcmliZWQgaW4gdGhlIGRhdGEgbWFwcGluZ3MKPiBiZWxvdyBvbiBh bGwgZGF0YSBsYW5lcywgdHJhbnNtaXR0aW5nIGJpdHMgZm9yIHNsb3RzIDYgdG8gMCBpbnN0ZWFk IG9mIDAgdG8KPiA2Lgo+IGRpZmYgLS1naXQKPiBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9kaXNwbGF5L3BhbmVsL3NpbXBsZS1wYW5lbC50eHQKPiBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL3NpbXBsZS1wYW5lbC50eHQgaW5kZXgK PiAxMzQxYmJmNGFhM2QuLjE2ZDhmZjA4OGI3ZCAxMDA2NDQKPiAtLS0gYS9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaW1wbGUtcGFuZWwudHh0Cj4gKysr IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2ltcGxl LXBhbmVsLnR4dAo+IEBAIC0xLDcgKzEsNyBAQAo+ICBTaW1wbGUgZGlzcGxheSBwYW5lbAo+IAo+ ICBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+IC0tIHBvd2VyLXN1cHBseTogcmVndWxhdG9yIHRvIHBy b3ZpZGUgdGhlIHN1cHBseSB2b2x0YWdlCj4gKy0gcG93ZXItc3VwcGx5OiBTZWUgcGFuZWwtY29t bW9uLnR4dAo+IAo+ICBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ICAtIGRkYy1pMmMtYnVzOiBwaGFu ZGxlIG9mIGFuIEkyQyBjb250cm9sbGVyIHVzZWQgZm9yIEREQyBFRElEIHByb2JpbmcKCi0tIApS ZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756607AbdLVMIP (ORCPT ); Fri, 22 Dec 2017 07:08:15 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:59082 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755949AbdLVMII (ORCPT ); Fri, 22 Dec 2017 07:08:08 -0500 From: Laurent Pinchart To: Maxime Ripard Cc: Daniel Vetter , David Airlie , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Mark Rutland , Rob Herring , linux-arm-kernel@lists.infradead.org, plaes@plaes.org, icenowy@aosc.io, Thomas Petazzoni , jernej.skrabec@siol.net, devicetree@vger.kernel.org, thierry.reding@gmail.com Subject: Re: [PATCH v5 01/12] dt-bindings: panel: lvds: Document power-supply property Date: Fri, 22 Dec 2017 14:08:20 +0200 Message-ID: <2493504.1OPucrC18r@avalon> Organization: Ideas on Board Oy In-Reply-To: <0a6a3abcf1a6b7f0e66a81af8a44c5c0566ce06c.1513854122.git-series.maxime.ripard@free-electrons.com> References: <0a6a3abcf1a6b7f0e66a81af8a44c5c0566ce06c.1513854122.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Maxime, Thank you for the patch. On Thursday, 21 December 2017 13:02:27 EET Maxime Ripard wrote: > The power-supply property is used by a vast majority of panels, including > panel-simple. Let's document it as a common property > > Reviewed-by: Rob Herring > Signed-off-by: Maxime Ripard > --- > Documentation/devicetree/bindings/display/panel/panel-common.txt | 6 ++++++ > Documentation/devicetree/bindings/display/panel/panel-lvds.txt | 1 + > Documentation/devicetree/bindings/display/panel/simple-panel.txt | 2 +- 3 > files changed, 8 insertions(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/panel/panel-common.txt > b/Documentation/devicetree/bindings/display/panel/panel-common.txt index > ec52c472c845..125ea68052af 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-common.txt > +++ b/Documentation/devicetree/bindings/display/panel/panel-common.txt > @@ -78,6 +78,12 @@ used for panels that implement compatible control > signals. while active. Active high reset signals can be supported by > inverting the GPIO specifier polarity flag. > > +Power > +----- > + > +- power-supply: many display panels need an additional power supply in > + order to be fully powered-up. For such panels, power-supply contains > + a phandle to the regulator powering the panel. I think we should give more details here about the limitations of this property. How about the following explanation ? - power-supply: display panels require power to be supplied. While several panels need more than one power supply with panel-specific constraints governing the order and timings of the power supplies, in many cases a single power supply is sufficient, either because the panel has a single power rail, or because all its power rails can be driven by the same supply. In that case the power-supply property specifies the supply powering the panel as a phandle to a regulator. > Backlight > --------- > diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.txt > b/Documentation/devicetree/bindings/display/panel/panel-lvds.txt index > b938269f841e..250850a2150b 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.txt > +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.txt > @@ -32,6 +32,7 @@ Optional properties: > - label: See panel-common.txt. > - gpios: See panel-common.txt. > - backlight: See panel-common.txt. > +- power-supply: See panel-common.txt. > - data-mirror: If set, reverse the bit order described in the data mappings > below on all data lanes, transmitting bits for slots 6 to 0 instead of 0 to > 6. > diff --git > a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > b/Documentation/devicetree/bindings/display/panel/simple-panel.txt index > 1341bbf4aa3d..16d8ff088b7d 100644 > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > @@ -1,7 +1,7 @@ > Simple display panel > > Required properties: > -- power-supply: regulator to provide the supply voltage > +- power-supply: See panel-common.txt > > Optional properties: > - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing -- Regards, Laurent Pinchart