From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: linux-nfs-owner@vger.kernel.org Received: from mx1.redhat.com ([209.132.183.28]:20512 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755261Ab1K3Izp (ORCPT ); Wed, 30 Nov 2011 03:55:45 -0500 In-Reply-To: <20111130071319.GA16711@onthe.net.au> References: <20111130071319.GA16711@onthe.net.au> <1321861008-20611-1-git-send-email-chris@onthe.net.au> <20111129082501.GA569@onthe.net.au> <2E1EB2CF9ED1CB4AA966F0EB76EAB4430C3CBC20@SACMVEXC2-PRD.hq.netapp.com> To: Chris Dunlop , Al Viro Cc: dhowells@redhat.com, "Myklebust, Trond" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , Jan Harkes , "maintainer:CODA FILE SYSTEM" , Dave Kleikamp , Petr Vandrovec , Greg Kroah-Hartman , v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, codalist@TELEMANN.coda.cs.cmu.edu, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/1] fix d_revalidate oopsen on NFS exports Date: Wed, 30 Nov 2011 08:54:43 +0000 Message-ID: <24960.1322643283@redhat.com> From: David Howells Sender: linux-nfs-owner@vger.kernel.org List-ID: Chris Dunlop wrote: > To avoid other people further wasting their and your time on > exactly the same thing future, how something like the following > patch, based on your comment in: > > http://article.gmane.org/gmane.linux.nfs/40370 > > ...and, if that's acceptable, is it worthwhile doing for the > other file systems which are likewise currently vulnerable when > abused by broken layered file systems? Also, this may get fixed by Al's atomic open patches - but obviously it hasn't been yet... > Don't oops when abused by broken layered file systems > > Signed-off-by: Chris Dunlop Acked-by: David Howells It's also worth printing a message - this *is* a kernel bug of some description if it happens. David From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 1/1] fix d_revalidate oopsen on NFS exports Date: Wed, 30 Nov 2011 08:54:43 +0000 Message-ID: <24960.1322643283@redhat.com> References: <20111130071319.GA16711@onthe.net.au> <1321861008-20611-1-git-send-email-chris@onthe.net.au> <20111129082501.GA569@onthe.net.au> <2E1EB2CF9ED1CB4AA966F0EB76EAB4430C3CBC20@SACMVEXC2-PRD.hq.netapp.com> Cc: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Myklebust, Trond" , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Eric Van Hensbergen , Ron Minnich , Latchesar Ionkov , Jan Harkes , "maintainer:CODA FILE SYSTEM" , Dave Kleikamp , Petr Vandrovec , Greg Kroah-Hartman , v9fs-developer-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-afs-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, codalist-OCorLXSLWn+MVn35/9/JlcWGCVk0P7UB@public.gmane.org, jfs-discussion-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Chris Dunlop , Al Viro Return-path: In-Reply-To: <20111130071319.GA16711-s239Etu9j1dPR4JQBCEnsQ@public.gmane.org> Sender: linux-nfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org Chris Dunlop wrote: > To avoid other people further wasting their and your time on > exactly the same thing future, how something like the following > patch, based on your comment in: > > http://article.gmane.org/gmane.linux.nfs/40370 > > ...and, if that's acceptable, is it worthwhile doing for the > other file systems which are likewise currently vulnerable when > abused by broken layered file systems? Also, this may get fixed by Al's atomic open patches - but obviously it hasn't been yet... > Don't oops when abused by broken layered file systems > > Signed-off-by: Chris Dunlop Acked-by: David Howells It's also worth printing a message - this *is* a kernel bug of some description if it happens. David -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html