From: Marek Lindner <mareklindner@neomailbox.ch>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCHv2 maint 1/4] batman-adv: Fix broken DAT capability check
Date: Tue, 07 Jul 2015 16:41:12 +0800 [thread overview]
Message-ID: <2499178.5J3uHqtEmg@voltaire> (raw)
In-Reply-To: <1435940999-3829-2-git-send-email-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 736 bytes --]
On Friday, July 03, 2015 18:29:56 Linus Lüssing wrote:
> The introduction of set_bit() and clear_bit() calls in batman-adv
> wrongly passed bitmasks and not the bit numbers to these functions.
> This leads to broken capability checks.
>
> Fixing this by making the capability enum a non-bitmasked one and by
> that passing non-masked values to set_bit()/clear_bit().
>
> Fixes: bfd0fbaef270 ("batman-adv: Make DAT capability changes atomic")
> Reported-by: Def <def@laposte.net>
> Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
> ---
> distributed-arp-table.c | 2 +-
> types.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Applied in revision de46667.
Thanks,
Marek
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-07-07 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 16:29 [B.A.T.M.A.N.] [PATCHv2 maint 0/4] batman-adv: Fix broken capability checks Linus Lüssing
2015-07-03 16:29 ` [B.A.T.M.A.N.] [PATCHv2 maint 1/4] batman-adv: Fix broken DAT capability check Linus Lüssing
2015-07-07 8:41 ` Marek Lindner [this message]
2015-07-03 16:29 ` [B.A.T.M.A.N.] [PATCHv2 maint 2/4] batman-adv: Fix broken NC " Linus Lüssing
2015-07-07 8:45 ` Marek Lindner
2015-07-03 16:29 ` [B.A.T.M.A.N.] [PATCHv2 maint 3/4] batman-adv: Fix broken TT " Linus Lüssing
2015-07-07 8:46 ` Marek Lindner
2015-07-03 16:29 ` [B.A.T.M.A.N.] [PATCHv2 maint 4/4] batman-adv: Fix broken MCAST " Linus Lüssing
2015-07-07 8:48 ` Marek Lindner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2499178.5J3uHqtEmg@voltaire \
--to=mareklindner@neomailbox.ch \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.