From: Sibi Sankar <sibis@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: andy.gross@linaro.org, david.brown@linaro.org,
robh+dt@kernel.org, bjorn.andersson@linaro.org,
dianders@chromium.org, evgreen@chromium.org,
benchan@chromium.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tsoni@codeaurora.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node
Date: Mon, 29 Oct 2018 20:24:46 +0530 [thread overview]
Message-ID: <24ab0b3496de7809cc49479ea33c2eab@codeaurora.org> (raw)
In-Reply-To: <9fb3d2d2-37b5-27d2-ad27-45c77ebe1df2@linaro.org>
Hi Stan,
Thanks for the review!
On 2018-10-29 15:02, Stanimir Varbanov wrote:
> Hi Sibi,
>
> On 10/26/2018 03:25 PM, Sibi Sankar wrote:
>> Add SCM DT node to enable SCM functionality on SDM845.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> index b72bdb0a31a5..fad22acfda4d 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -221,6 +221,12 @@
>> };
>> };
>>
>> + firmware {
>> + scm {
>> + compatible = "qcom,scm-sdm845", "qcom,scm";
>> + };
>> + };
>
> What will happen if the platform is without tz firmware? I'd move this
> DT node in sdm845-mtp.dts or at least make it status = disabled.
Even in the absence of tz firmware, ATF is expected to implement the
necessary
handlers for the SMC calls so I don't think it is necessary to keep it
disabled.
--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
prev parent reply other threads:[~2018-10-29 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 12:25 [PATCH] arm64: dts: qcom: sdm845: Add SCM DT node Sibi Sankar
2018-10-29 1:35 ` Bjorn Andersson
2018-10-29 9:32 ` Stanimir Varbanov
2018-10-29 14:54 ` Sibi Sankar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24ab0b3496de7809cc49479ea33c2eab@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=benchan@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.