Re: (subset) [RFC PATCH v5 0/5] introduce io_uring_cmd_import_fixed_vec

[Pavel Begunkov <asml.silence@gmail.com>]

On 3/20/25 16:10, Sidong Yang wrote:
> On Thu, Mar 20, 2025 at 12:04:33PM +0000, Pavel Begunkov wrote:
>> On 3/20/25 01:47, Sidong Yang wrote:
>>> On Wed, Mar 19, 2025 at 11:10:07AM -0600, Jens Axboe wrote:
>>>> On 3/19/25 11:07 AM, David Sterba wrote:
>>>>> On Wed, Mar 19, 2025 at 09:27:37AM -0600, Jens Axboe wrote:
>>>>>> On 3/19/25 9:26 AM, Jens Axboe wrote:
>>>>>>>
>>>>>>> On Wed, 19 Mar 2025 06:12:46 +0000, Sidong Yang wrote:
>>>>>>>> This patche series introduce io_uring_cmd_import_vec. With this function,
>>>>>>>> Multiple fixed buffer could be used in uring cmd. It's vectored version
>>>>>>>> for io_uring_cmd_import_fixed(). Also this patch series includes a usage
>>>>>>>> for new api for encoded read/write in btrfs by using uring cmd.
>>>>>>>>
>>>>>>>> There was approximately 10 percent of performance improvements through benchmark.
>>>>>>>> The benchmark code is in
>>>>>>>> https://github.com/SidongYang/btrfs-encoded-io-test/blob/main/main.c
>>>>>>>>
>>>>>>>> [...]
>>>>>>>
>>>>>>> Applied, thanks!
>>>>>>>
>>>>>>> [1/5] io_uring: rename the data cmd cache
>>>>>>>         commit: 575e7b0629d4bd485517c40ff20676180476f5f9
>>>>>>> [2/5] io_uring/cmd: don't expose entire cmd async data
>>>>>>>         commit: 5f14404bfa245a156915ee44c827edc56655b067
>>>>>>> [3/5] io_uring/cmd: add iovec cache for commands
>>>>>>>         commit: fe549edab6c3b7995b58450e31232566b383a249
>>>>>>> [4/5] io_uring/cmd: introduce io_uring_cmd_import_fixed_vec
>>>>>>>         commit: b24cb04c1e072ecd859a98b2e4258ca8fe8d2d4d
>>>>>>
>>>>>> 1-4 look pretty straight forward to me - I'll be happy to queue the
>>>>>> btrfs one as well if the btrfs people are happy with it, just didn't
>>>>>> want to assume anything here.
>>>>>
>>>>> For 6.15 is too late so it makes more sense to take it through the btrfs
>>>>> patches targetting 6.16.
>>>>
>>>> No problem - Sidong, guessing you probably want to resend patch 5/5 once
>>>> btrfs has a next branch based on 6.15-rc1 or later.
>>>
>>> Thanks, I'll resend only patch 5/5 then.
>>
>> And please do send the fix, that should always be done first,
>> especially if it conflicts with the current patch as they usually
>> go to different trees and the fix might need to be backported.
> 
> Sorry to forget to cc you Pavel.
> https://lore.kernel.org/linux-btrfs/20250319180416.GL32661@twin.jikos.cz/T/#t

Ah, you already did, great!

-- 
Pavel Begunkov