From: Denis Kenzior <denkenz@gmail.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, ofono@lists.linux.dev
Subject: Re: [PATCH 2/2] udevng: Fix detection of USB attached tty devices
Date: Fri, 31 May 2024 10:52:23 -0500 [thread overview]
Message-ID: <24df8380-b6fe-4f86-bb20-49815ef58c1f@gmail.com> (raw)
In-Reply-To: <b0e4aed1-302a-0d4f-b466-7fd7b999275a@gmail.com>
Hi Ivo,
>> -
>> + /* Handle USB-connected devices in check_usb_device */
>> + if (l_streq0(bus, "usb")) {
>> + check_usb_device(device);
>> return;
>> }
>> - if (l_streq0(subsystem, "usb") || l_streq0(subsystem, "usbmisc"))
>
> Is it possible (in theory) that we have 'usb' subsystem device that is not on
> USB bus? If yes, then you shouldn't drop l_streq0(subsystem, "usb") check.
I hope not. What i've seen is subsystem 'usbmisc' devices not setting ID_BUS to
'usb', which is a bit weird. Hence the 'usbmisc' check below.
I think we do not care about usb subsystem devices, only the leafs:
- usbmisc (cdc-acm)
- tty (ttyUSB...)
- net
Regards,
-Denis
next prev parent reply other threads:[~2024-05-31 15:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 15:25 [PATCH 1/2] udevng: Don't crash for non-QMI devices Denis Kenzior
2024-05-30 15:25 ` [PATCH 2/2] udevng: Fix detection of USB attached tty devices Denis Kenzior
2024-05-31 6:09 ` Ivaylo Dimitrov
2024-05-31 15:52 ` Denis Kenzior [this message]
2024-05-31 17:27 ` Ivaylo Dimitrov
2024-05-31 19:30 ` [PATCH 1/2] udevng: Don't crash for non-QMI devices patchwork-bot+ofono
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24df8380-b6fe-4f86-bb20-49815ef58c1f@gmail.com \
--to=denkenz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=ofono@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.