From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Bui Duc Phuc <phucduc.bui@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Rosen Penev <rosenp@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
<linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>
Subject: Re: [PATCH 1/3] ASoC: mediatek: mt2701: Use devm_clk_get_optional() for audio_mrgif_pd
Date: Tue, 18 Aug 2026 13:18:04 +0200 [thread overview]
Message-ID: <24e7e485-625a-47f8-8aa7-d172aae80053@intel.com> (raw)
In-Reply-To: <CAABR9nFME5kYrLZUMn86sT1RaJiqzJeC7QJzqqxedL1NkZUYwA@mail.gmail.com>
On 8/18/2026 1:02 PM, Bui Duc Phuc wrote:
>>> Propagate other errors to the caller.
>>
>> What does that mean? Did the functional path change?
>>
>
> Previously, the code only returned an error for -EPROBE_DEFER and
> ignored other errors.
> After switching to devm_clk_get_optional(), all other errors are
> propagated to the caller as well.
>
> Regarding the functional path, I don't think it changes on platforms
> where the clock is present.
> The change only allows platforms without this optional clock to
> continue probing.
>> This should be part of a mediatek-patch-series with a cover letter.
>> Yeah, the mt6797 changes should be here too.
>
> Currently, the MediaTek ASoC drivers are split into multiple groups by SoC.
> I am handling them one group at a time to make the review easier.
>
> I will send each group once it is completed, rather than waiting for the entire
> MediaTek cleanup, which would take quite a long time. A single series
> covering all
> MediaTek SoCs would also be very long and harder to follow,
> especially if changes are requested during review.
>
> I hope this approach works for you.
Thanks for the explanations. I see only benefits from these changes.
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
prev parent reply other threads:[~2026-08-18 11:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 10:49 [PATCH 1/3] ASoC: mediatek: mt2701: Use devm_clk_get_optional() for audio_mrgif_pd phucduc.bui
2026-08-17 10:49 ` [PATCH 2/3] ASoC: mediatek: mt2701: Use dev_err_probe() for error handling phucduc.bui
2026-08-18 11:20 ` Cezary Rojewski
2026-08-17 10:49 ` [PATCH 3/3] ASoC: mediatek: mt2701: Drop redundant probe error messages phucduc.bui
2026-08-18 11:21 ` Cezary Rojewski
2026-08-18 10:31 ` [PATCH 1/3] ASoC: mediatek: mt2701: Use devm_clk_get_optional() for audio_mrgif_pd Cezary Rojewski
2026-08-18 11:02 ` Bui Duc Phuc
2026-08-18 11:18 ` Cezary Rojewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24e7e485-625a-47f8-8aa7-d172aae80053@intel.com \
--to=cezary.rojewski@intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel@makrotopia.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=rosenp@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.