From: Thomas Monjalon <thomas@monjalon.net>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: Akhil Goyal <gakhil@marvell.com>,
dev@dpdk.org, declan.doherty@intel.com,
hemant.agrawal@oss.nxp.com, anoobj@marvell.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix potential build error
Date: Wed, 03 Nov 2021 14:08:46 +0100 [thread overview]
Message-ID: <2503525.8RzHhxm8q0@thomas> (raw)
In-Reply-To: <20211103115618.3559996-1-radu.nicolau@intel.com>
03/11/2021 12:56, Radu Nicolau:
> When STATS_INTERVAL is set to a non-zero value the core_statistics array
> will be defined in multiple compilation units and this can trigger a
> linker error on particular environments. In order to fix this the
> core_statistics definition was moved out of the header file.
So it is not fixing compilation,
as we would never apply a patch which would completely break compilation.
I would say (in the title) that it moves global variable from header file.
> Fixes: 1329602b6c8f ("examples/ipsec-secgw: add per-core packet statistics")
> Cc: stable@dpdk.org
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
next prev parent reply other threads:[~2021-11-03 13:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 10:51 [dpdk-dev] [PATCH] examples/ipsec-secgw: fix build error Radu Nicolau
2021-11-03 11:56 ` [dpdk-dev] [PATCH v2] examples/ipsec-secgw: fix potential " Radu Nicolau
2021-11-03 13:08 ` Thomas Monjalon [this message]
2021-11-03 13:36 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-11-03 13:42 ` [dpdk-dev] [dpdk-stable] " David Marchand
2021-11-03 13:45 ` [dpdk-dev] [EXT] " Akhil Goyal
2021-11-03 13:50 ` David Marchand
2021-11-03 13:55 ` Akhil Goyal
2021-11-03 11:58 ` [dpdk-dev] [PATCH] examples/ipsec-secgw: fix " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2503525.8RzHhxm8q0@thomas \
--to=thomas@monjalon.net \
--cc=anoobj@marvell.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hemant.agrawal@oss.nxp.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.