From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs Date: Sat, 30 Mar 2019 10:24:16 +0100 Message-ID: <2505351.MTFty8Ks2V@phil> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jonas Karlman Cc: David Airlie , Neil Armstrong , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-rockchip@lists.infradead.org" , Sean Paul , Laurent Pinchart List-Id: linux-rockchip.vger.kernel.org QW0gTWl0dHdvY2gsIDIwLiBGZWJydWFyIDIwMTksIDA4OjUyOjMxIENFVCBzY2hyaWViIEpvbmFz IEthcmxtYW46Cj4gVGhlIFJvY2tjaGlwIFJLMzI4OCBTb0MgKHYyLjAwYSkgYW5kIFJLMzMyOC9S SzMzOTkgU29DcyAodjIuMTFhKSBoYXZlCj4gYWxzbyBiZWVuIGlkZW50aWZpZWQgYXMgbmVlZGlu ZyB0aGlzIHdvcmthcm91bmQgd2l0aCBhIHNpbmdsZSBpdGVyYXRpb24uCj4gCj4gRml4ZXM6IGJl NDFmYzU1ZjFhYSAoImRybTogYnJpZGdlOiBkdy1oZG1pOiBIYW5kbGUgb3ZlcmZsb3cgd29ya2Fy b3VuZCBiYXNlZCBvbiBkZXZpY2UgdmVyc2lvbiIpCj4gU2lnbmVkLW9mZi1ieTogSm9uYXMgS2Fy bG1hbiA8am9uYXNAa3dpYm9vLnNlPgoKT24gcmszMzI4IGFuZCByazMyODgKVGVzdGVkLWJ5OiBI ZWlrbyBTdHVlYmVyIDxoZWlrb0BzbnRlY2guZGU+CgpJZiBJIHJlbWVtYmVyIGNvcnJlY3RseSwg dGhpcyBzaG91bGQgcmVtb3ZlIHRoZSBwaW5rIGxpbmUgdGhhdCBzaG93cyB1cApzb21ldGltZXMu IFdpdGggdGhpcyBwYXRjaCBJIGNvdWxkbid0IHNlZSBpdCBhbnltb3JlIGR1cmluZyBtdWx0aXBs ZQpyZWJvb3RzLgoKSGVpa28KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3Bz eXMvZHctaGRtaS5jIHwgNCArKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1p LmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYwo+IGluZGV4IDY0 YzNjZjAyNzUxOC4uMTQyMjNjMGVlNzg0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9i cmlkZ2Uvc3lub3BzeXMvZHctaGRtaS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9z eW5vcHN5cy9kdy1oZG1pLmMKPiBAQCAtMTY1NSw2ICsxNjU1LDggQEAgc3RhdGljIHZvaWQgZHdf aGRtaV9jbGVhcl9vdmVyZmxvdyhzdHJ1Y3QgZHdfaGRtaSAqaGRtaSkKPiAgCSAqIGl0ZXJhdGlv biBmb3Igb3RoZXJzLgo+ICAJICogVGhlIEFtbG9naWMgTWVzb24gR1ggU29DcyAodjIuMDFhKSBo YXZlIGJlZW4gaWRlbnRpZmllZCBhcyBuZWVkaW5nCj4gIAkgKiB0aGUgd29ya2Fyb3VuZCB3aXRo IGEgc2luZ2xlIGl0ZXJhdGlvbi4KPiArCSAqIFRoZSBSb2NrY2hpcCBSSzMyODggU29DICh2Mi4w MGEpIGFuZCBSSzMzMjgvUkszMzk5IFNvQ3MgKHYyLjExYSkgaGF2ZQo+ICsJICogYmVlbiBpZGVu dGlmaWVkIGFzIG5lZWRpbmcgdGhlIHdvcmthcm91bmQgd2l0aCBhIHNpbmdsZSBpdGVyYXRpb24u Cj4gIAkgKi8KPiAgCj4gIAlzd2l0Y2ggKGhkbWktPnZlcnNpb24pIHsKPiBAQCAtMTY2Myw3ICsx NjY1LDkgQEAgc3RhdGljIHZvaWQgZHdfaGRtaV9jbGVhcl9vdmVyZmxvdyhzdHJ1Y3QgZHdfaGRt aSAqaGRtaSkKPiAgCQlicmVhazsKPiAgCWNhc2UgMHgxMzFhOgo+ICAJY2FzZSAweDEzMmE6Cj4g KwljYXNlIDB4MjAwYToKPiAgCWNhc2UgMHgyMDFhOgo+ICsJY2FzZSAweDIxMWE6Cj4gIAljYXNl IDB4MjEyYToKPiAgCQljb3VudCA9IDE7Cj4gIAkJYnJlYWs7Cj4gCgoKCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5CB9C43381 for ; Sat, 30 Mar 2019 09:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 712F92184C for ; Sat, 30 Mar 2019 09:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730548AbfC3JYc (ORCPT ); Sat, 30 Mar 2019 05:24:32 -0400 Received: from gloria.sntech.de ([185.11.138.130]:44734 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730384AbfC3JYc (ORCPT ); Sat, 30 Mar 2019 05:24:32 -0400 Received: from ip5f5a6320.dynamic.kabel-deutschland.de ([95.90.99.32] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hAADp-0003Js-GG; Sat, 30 Mar 2019 10:24:17 +0100 From: Heiko Stuebner To: Jonas Karlman Cc: "dri-devel@lists.freedesktop.org" , "linux-rockchip@lists.infradead.org" , Archit Taneja , Andrzej Hajda , Laurent Pinchart , David Airlie , Daniel Vetter , Sean Paul , Neil Armstrong , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs Date: Sat, 30 Mar 2019 10:24:16 +0100 Message-ID: <2505351.MTFty8Ks2V@phil> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 20. Februar 2019, 08:52:31 CET schrieb Jonas Karlman: > The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > also been identified as needing this workaround with a single iteration. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version") > Signed-off-by: Jonas Karlman On rk3328 and rk3288 Tested-by: Heiko Stueber If I remember correctly, this should remove the pink line that shows up sometimes. With this patch I couldn't see it anymore during multiple reboots. Heiko > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index 64c3cf027518..14223c0ee784 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > * iteration for others. > * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing > * the workaround with a single iteration. > + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have > + * been identified as needing the workaround with a single iteration. > */ > > switch (hdmi->version) { > @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > break; > case 0x131a: > case 0x132a: > + case 0x200a: > case 0x201a: > + case 0x211a: > case 0x212a: > count = 1; > break; >