From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
qemu-devel@nongnu.org
Cc: devel@daynix.com, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: Re: [PATCH v4 3/3] coreaudio: Initialize the buffer for device change
Date: Wed, 22 Jan 2025 19:54:16 +0100 [thread overview]
Message-ID: <2508753.NHzG6lTPJn@silver> (raw)
In-Reply-To: <20250117-coreaudio-v4-3-f8d4fa4cb5f4@daynix.com>
On Friday, January 17, 2025 7:47:02 AM CET Akihiko Odaki wrote:
> Reallocate buffers when the active device change as the required buffer
> size may differ.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
OTOH it also re-allocates the buffer when the size did not change, but Ok.
Acked-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
> audio/coreaudio.m | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/audio/coreaudio.m b/audio/coreaudio.m
> index b9e1a952ed37..72a6df0f75ee 100644
> --- a/audio/coreaudio.m
> +++ b/audio/coreaudio.m
> @@ -466,6 +466,7 @@ static OSStatus init_out_device(coreaudioVoiceOut *core)
> core->outputDeviceID = deviceID;
> core->audioDevicePropertyBufferFrameSize = audioDevicePropertyBufferFrameSize;
> core->hw.samples = core->bufferCount * core->audioDevicePropertyBufferFrameSize;
> + audio_generic_initialize_buffer_out(&core->hw);
> core->ioprocid = ioprocid;
>
> return 0;
>
>
prev parent reply other threads:[~2025-01-22 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 6:46 [PATCH v4 0/3] coreaudio fixes Akihiko Odaki
2025-01-17 6:47 ` [PATCH v4 1/3] coreaudio: Commit the result of init in the end Akihiko Odaki
2025-01-17 10:38 ` Phil Dennis-Jordan
2025-01-22 19:39 ` Christian Schoenebeck
2025-01-17 6:47 ` [PATCH v4 2/3] audio: Add functions to initialize buffers Akihiko Odaki
2025-01-17 10:14 ` Phil Dennis-Jordan
2025-01-17 6:47 ` [PATCH v4 3/3] coreaudio: Initialize the buffer for device change Akihiko Odaki
2025-01-17 10:24 ` Phil Dennis-Jordan
2025-01-22 18:54 ` Christian Schoenebeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2508753.NHzG6lTPJn@silver \
--to=qemu_oss@crudebyte.com \
--cc=akihiko.odaki@daynix.com \
--cc=devel@daynix.com \
--cc=kraxel@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.