From: Jesper Dangaard Brouer <hawk@kernel.org>
To: Jon Kohler <jon@nutanix.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jason Wang <jasowang@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH net-next] tun: use xdp_get_frame_len()
Date: Thu, 8 May 2025 17:04:25 +0200 [thread overview]
Message-ID: <2508ea8d-b7e3-49dc-b110-7eba1e4ece4d@kernel.org> (raw)
In-Reply-To: <7C311781-F3BA-4AEB-BD17-892A88192016@nutanix.com>
On 08/05/2025 16.24, Jon Kohler wrote:
>
>> On May 8, 2025, at 10:16 AM, Jesper Dangaard Brouer <hawk@kernel.org> wrote:
>>
[...]
>>
>> AFAICR there is also some dual packet handling code path for XDP in
>> vhost_net/tun. I'm also willing to take the paper-cut, for cleaning
>> that up.
>>
>> --Jesper
>
> When you say dual packet handling, what are you referring to specifically?
The important part of the sentence was *code path*, as in multiple code
path for packets.
You tricked me into looking up the code for you...
It was in drivers/net/virtio_net.c where function receive_buf() calls[1]
three different functions based on different checks. Some cases support
XDP and others don't. I though you talked about this in another thread?
--Jesper
[1]
https://elixir.bootlin.com/linux/v6.15-rc5/source/drivers/net/virtio_net.c#L2570-L2573
next prev parent reply other threads:[~2025-05-08 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-07 16:19 [PATCH net-next] tun: use xdp_get_frame_len() Jon Kohler
2025-05-07 20:56 ` Willem de Bruijn
2025-05-08 2:56 ` Jon Kohler
2025-05-08 13:29 ` Willem de Bruijn
2025-05-08 14:16 ` Jesper Dangaard Brouer
2025-05-08 14:24 ` Jon Kohler
2025-05-08 15:04 ` Jesper Dangaard Brouer [this message]
2025-05-08 15:26 ` Jon Kohler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2508ea8d-b7e3-49dc-b110-7eba1e4ece4d@kernel.org \
--to=hawk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=jon@nutanix.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.