From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A616D10C16 for ; Sun, 27 Oct 2024 10:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:MIME-Version:References: In-Reply-To:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S5EXjeBZeIni6OECZ4ig3IyftbFrA4b+gVeAJWASIkI=; b=dfJDeKp3wyyt+w zyPldW7wOY3BFgFZsdZfzR74A3EgdhBmn3DcMj/zF1cePxxxk+zRrMZqB0GHSV9TGHS7JAC1jSzL+ hTo7dun4m4XRArA3FUJzAo3o7FJsAWfvM4JhmsYUUcIDoCKGrGaIojb746OHCqzPd3ayqe1lnP0zV KEj6CGKTeZwDpaVwk2fImKLlFIkN3QDy2gftlntOt1aOuJL71ksMv3lpuAiRsuBbeFeY4vA1TPPhT I8e8KjqbvCtgNNY5yxF/uXAYwgaa71tyg+dcRxrWDEC5o/ySb/Lhp+YsuD9ePIJUKkMapxLCSn5uw JeQBtcZQcPN7O9yItB9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t505N-00000007wwN-0swh; Sun, 27 Oct 2024 10:01:25 +0000 Received: from m16.mail.163.com ([220.197.31.2]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t505J-00000007wvZ-2cR0 for linux-rockchip@lists.infradead.org; Sun, 27 Oct 2024 10:01:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Content-Type:MIME-Version: Message-ID; bh=/Mb/MAbniH+iTLFgaPUPLoohugvKzOX3bCzKXiE8zSs=; b=o fkDbmiKz1M+MBFrLp8PnYIt85i4lzZdK2bLu7EFt8OsDFd9UsCvWDpaP2OVoXGxp SIR9yqCtq2UOxp50jPVlFPXOndvbcd935cUDqBoYy4iWTNJItraln3/wqCtqevf6 i5IJBX5v9hwjBWEyHyiFkNJyMDHRndHudwdEJv2nXs= Received: from andyshrk$163.com ( [58.22.7.114] ) by ajax-webmail-wmsvr-40-117 (Coremail) ; Sun, 27 Oct 2024 17:58:57 +0800 (CST) X-Originating-IP: [58.22.7.114] Date: Sun, 27 Oct 2024 17:58:57 +0800 (CST) From: "Andy Yan" To: "Johan Jonker" Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, david.wu@rock-chips.com, andy.yan@rock-chips.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re:[PATCH v1 2/2] net: arc: rockchip: fix emac mdio node support X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.14 build 20240801(9da12a7b) Copyright (c) 2002-2024 www.mailtech.cn 163com In-Reply-To: References: X-NTES-SC: AL_Qu2YAvyZvEko4SGbYelS/DNR+6hBMKv32aNaoMQOZ8UqqTHC6CwvbV1SBFDxyvpExDuGajt87KyUggf9a/E3 MIME-Version: 1.0 Message-ID: <250cdfef.1bfc.192cd6a1f72.Coremail.andyshrk@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: dSgvCgD3E2zhDh5nyQgYAA--.58001W X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbB0huFXmceAjpw-wADsf X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241027_030122_014950_23B1164B X-CRM114-Status: UNSURE ( 5.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org Hello Johan, Thanks for your patch. Maybe we need a Fixes tag here? And for the patch itself: Tested-by: Andy Yan At 2024-10-27 17:42:45, "Johan Jonker" wrote: >The binding emac_rockchip.txt is converted to YAML. >Changed against the original binding is an added MDIO subnode. >Fix emac_mdio.c so that it can handle both old and new >device trees. > >Signed-off-by: Johan Jonker >--- > drivers/net/ethernet/arc/emac_mdio.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/arc/emac_mdio.c b/drivers/net/ethernet/arc/emac_mdio.c >index 87f40c2ba904..078b1a72c161 100644 >--- a/drivers/net/ethernet/arc/emac_mdio.c >+++ b/drivers/net/ethernet/arc/emac_mdio.c >@@ -133,6 +133,7 @@ int arc_mdio_probe(struct arc_emac_priv *priv) > struct arc_emac_mdio_bus_data *data = &priv->bus_data; > struct device_node *np = priv->dev->of_node; > const char *name = "Synopsys MII Bus"; >+ struct device_node *mdio_node; > struct mii_bus *bus; > int error; > >@@ -164,7 +165,13 @@ int arc_mdio_probe(struct arc_emac_priv *priv) > > snprintf(bus->id, MII_BUS_ID_SIZE, "%s", bus->name); > >- error = of_mdiobus_register(bus, priv->dev->of_node); >+ /* Backwards compatibility for EMAC nodes without MDIO subnode. */ >+ mdio_node = of_get_child_by_name(np, "mdio"); >+ if (!mdio_node) >+ mdio_node = of_node_get(np); >+ >+ error = of_mdiobus_register(bus, mdio_node); >+ of_node_put(mdio_node); > if (error) { > mdiobus_free(bus); > return dev_err_probe(priv->dev, error, >-- >2.39.2 > > >_______________________________________________ >Linux-rockchip mailing list >Linux-rockchip@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-rockchip _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8F7214CB36; Sun, 27 Oct 2024 10:01:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.3 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730023292; cv=none; b=ST7egdbqgtjGpJXl9t6zz3n/QUKBXXKzPqwZx25yriUXQsyCnoWi2H2x3PQddlhbkymI4cgom/nXdbmIhIMSs7BTI5S15vJlizmVX+4EMRDZuzbzlL9FaaXDAzTfEeBgxbN91J2jIebiMlG2hV2yTDYDHSTrTTOtO2WQQNpupCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730023292; c=relaxed/simple; bh=VoFIJcBuBgAEOEaKXwGvmmWLBxvC8SC/wK44SFhy4Kw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:Content-Type: MIME-Version:Message-ID; b=kM73L37HS8QuHiXd1TrgbQszoIUuo7RJ7IZca+HEZekXwCeonIdzEuhFIp8KdZtQOL04+MxNDbAd6CQQ4FsWAFvCGCG8pMLdT+CFaMIAeHiG2npBb3oBYvrwCk1b3BP4qtvS4b03yYJQSoXzr55+osQNYlLt39zG8S9L+uC/9gg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=fail (1024-bit key) header.d=163.com header.i=@163.com header.b=ofkDbmiK reason="signature verification failed"; arc=none smtp.client-ip=220.197.31.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=163.com header.i=@163.com header.b="ofkDbmiK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Content-Type:MIME-Version: Message-ID; bh=/Mb/MAbniH+iTLFgaPUPLoohugvKzOX3bCzKXiE8zSs=; b=o fkDbmiKz1M+MBFrLp8PnYIt85i4lzZdK2bLu7EFt8OsDFd9UsCvWDpaP2OVoXGxp SIR9yqCtq2UOxp50jPVlFPXOndvbcd935cUDqBoYy4iWTNJItraln3/wqCtqevf6 i5IJBX5v9hwjBWEyHyiFkNJyMDHRndHudwdEJv2nXs= Received: from andyshrk$163.com ( [58.22.7.114] ) by ajax-webmail-wmsvr-40-117 (Coremail) ; Sun, 27 Oct 2024 17:58:57 +0800 (CST) Date: Sun, 27 Oct 2024 17:58:57 +0800 (CST) From: "Andy Yan" To: "Johan Jonker" Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, david.wu@rock-chips.com, andy.yan@rock-chips.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re:[PATCH v1 2/2] net: arc: rockchip: fix emac mdio node support X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.14 build 20240801(9da12a7b) Copyright (c) 2002-2024 www.mailtech.cn 163com In-Reply-To: References: X-NTES-SC: AL_Qu2YAvyZvEko4SGbYelS/DNR+6hBMKv32aNaoMQOZ8UqqTHC6CwvbV1SBFDxyvpExDuGajt87KyUggf9a/E3 Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <250cdfef.1bfc.192cd6a1f72.Coremail.andyshrk@163.com> X-Coremail-Locale: zh_CN X-CM-TRANSID:dSgvCgD3E2zhDh5nyQgYAA--.58001W X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/xtbB0huFXmceAjpw-wADsf X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== CgoKCgoKCgoKCgoKCkhlbGxvIEpvaGFuLAogICAgVGhhbmtzIGZvciB5b3VyIHBhdGNoLiAgTWF5 YmUgd2UgbmVlZCBhIEZpeGVzIHRhZyBoZXJlPwogICAgQW5kIGZvciB0aGUgcGF0Y2ggaXRzZWxm OgogIAogICBUZXN0ZWQtYnk6IEFuZHkgWWFuIDxhbmR5c2hya0AxNjMuY29tPgoKQXQgMjAyNC0x MC0yNyAxNzo0Mjo0NSwgIkpvaGFuIEpvbmtlciIgPGpieDYyNDRAZ21haWwuY29tPiB3cm90ZToK PlRoZSBiaW5kaW5nIGVtYWNfcm9ja2NoaXAudHh0IGlzIGNvbnZlcnRlZCB0byBZQU1MLgo+Q2hh bmdlZCBhZ2FpbnN0IHRoZSBvcmlnaW5hbCBiaW5kaW5nIGlzIGFuIGFkZGVkIE1ESU8gc3Vibm9k ZS4KPkZpeCBlbWFjX21kaW8uYyBzbyB0aGF0IGl0IGNhbiBoYW5kbGUgYm90aCBvbGQgYW5kIG5l dwo+ZGV2aWNlIHRyZWVzLgo+Cj5TaWduZWQtb2ZmLWJ5OiBKb2hhbiBKb25rZXIgPGpieDYyNDRA Z21haWwuY29tPgo+LS0tCj4gZHJpdmVycy9uZXQvZXRoZXJuZXQvYXJjL2VtYWNfbWRpby5jIHwg OSArKysrKysrKy0KPiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCj4KPmRpZmYgLS1naXQgYS9kcml2ZXJzL25ldC9ldGhlcm5ldC9hcmMvZW1hY19tZGlvLmMg Yi9kcml2ZXJzL25ldC9ldGhlcm5ldC9hcmMvZW1hY19tZGlvLmMKPmluZGV4IDg3ZjQwYzJiYTkw NC4uMDc4YjFhNzJjMTYxIDEwMDY0NAo+LS0tIGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvYXJjL2Vt YWNfbWRpby5jCj4rKysgYi9kcml2ZXJzL25ldC9ldGhlcm5ldC9hcmMvZW1hY19tZGlvLmMKPkBA IC0xMzMsNiArMTMzLDcgQEAgaW50IGFyY19tZGlvX3Byb2JlKHN0cnVjdCBhcmNfZW1hY19wcml2 ICpwcml2KQo+IAlzdHJ1Y3QgYXJjX2VtYWNfbWRpb19idXNfZGF0YSAqZGF0YSA9ICZwcml2LT5i dXNfZGF0YTsKPiAJc3RydWN0IGRldmljZV9ub2RlICpucCA9IHByaXYtPmRldi0+b2Zfbm9kZTsK PiAJY29uc3QgY2hhciAqbmFtZSA9ICJTeW5vcHN5cyBNSUkgQnVzIjsKPisJc3RydWN0IGRldmlj ZV9ub2RlICptZGlvX25vZGU7Cj4gCXN0cnVjdCBtaWlfYnVzICpidXM7Cj4gCWludCBlcnJvcjsK Pgo+QEAgLTE2NCw3ICsxNjUsMTMgQEAgaW50IGFyY19tZGlvX3Byb2JlKHN0cnVjdCBhcmNfZW1h Y19wcml2ICpwcml2KQo+Cj4gCXNucHJpbnRmKGJ1cy0+aWQsIE1JSV9CVVNfSURfU0laRSwgIiVz IiwgYnVzLT5uYW1lKTsKPgo+LQllcnJvciA9IG9mX21kaW9idXNfcmVnaXN0ZXIoYnVzLCBwcml2 LT5kZXYtPm9mX25vZGUpOwo+KwkvKiBCYWNrd2FyZHMgY29tcGF0aWJpbGl0eSBmb3IgRU1BQyBu b2RlcyB3aXRob3V0IE1ESU8gc3Vibm9kZS4gKi8KPisJbWRpb19ub2RlID0gb2ZfZ2V0X2NoaWxk X2J5X25hbWUobnAsICJtZGlvIik7Cj4rCWlmICghbWRpb19ub2RlKQo+KwkJbWRpb19ub2RlID0g b2Zfbm9kZV9nZXQobnApOwo+Kwo+KwllcnJvciA9IG9mX21kaW9idXNfcmVnaXN0ZXIoYnVzLCBt ZGlvX25vZGUpOwo+KwlvZl9ub2RlX3B1dChtZGlvX25vZGUpOwo+IAlpZiAoZXJyb3IpIHsKPiAJ CW1kaW9idXNfZnJlZShidXMpOwo+IAkJcmV0dXJuIGRldl9lcnJfcHJvYmUocHJpdi0+ZGV2LCBl cnJvciwKPi0tCj4yLjM5LjIKPgo+Cj5fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+TGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Cj5MaW51eC1yb2NrY2hp cEBsaXN0cy5pbmZyYWRlYWQub3JnCj5odHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg==