From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Michael Baum <michaelba@nvidia.com>
Cc: dev@dpdk.org, Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
stable@dpdk.org, Lior Margalit <lmargalit@nvidia.com>,
asafp@nvidia.com
Subject: Re: [PATCH] net/mlx5: fix devargs validation for multiclass probe
Date: Thu, 25 Nov 2021 10:29:03 +0100 [thread overview]
Message-ID: <2510169.dztEg1IeGT@thomas> (raw)
In-Reply-To: <20211125061655.3143135-1-michaelba@nvidia.com>
25/11/2021 07:16, michaelba@nvidia.com:
> From: Michael Baum <michaelba@nvidia.com>
>
> The mlx5_args function reads the devargs and checks if they are valid
> for this driver and if not it returns an error.
>
> This was normal behavior as long as all the devargs come to this driver,
> but since it is possible to run several drivers together, the function
> may return an error for another driver's devarg even though it is
> completely valid.
> In addition the function does not allow the user to know which of the
> devargs he sent is incorrect, but returns an error without printing the
> unknown devarg.
>
> This patch eliminates the error return in the case of an unknown devarg,
> and prints a warning for each such devarg specifically.
>
> Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/mlx5.c | 68 ++++++-----------------------------------
> 1 file changed, 9 insertions(+), 59 deletions(-)
It is quite a big patch.
How well it has been tested?
How critical it is to have in 21.11?
next prev parent reply other threads:[~2021-11-25 9:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 6:16 [PATCH] net/mlx5: fix devargs validation for multiclass probe michaelba
2021-11-25 9:29 ` Thomas Monjalon [this message]
2021-11-25 10:38 ` Matan Azrad
2021-11-26 12:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2510169.dztEg1IeGT@thomas \
--to=thomas@monjalon.net \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=lmargalit@nvidia.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.