From: Thomas Monjalon <thomas@monjalon.net>
To: Kevin Laatz <kevin.laatz@intel.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check
Date: Wed, 27 Oct 2021 17:00:54 +0200 [thread overview]
Message-ID: <2517999.mVafrqInaF@thomas> (raw)
In-Reply-To: <YXlPOebiU3JfICUL@bricha3-MOBL.ger.corp.intel.com>
27/10/2021 15:08, Bruce Richardson:
> On Tue, Oct 26, 2021 at 02:20:45PM +0000, Kevin Laatz wrote:
> > When checking if the DMA device is active, the result of the operand will
> > always be zero since the err_code is truncated to 8 bits which makes
> > checking the 31st bit impossible.
> >
> > This is fixed by changing the type of err_code to uint32_t so that it is
> > not truncated.
> >
> > Coverity issue: 373657
> > Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
> >
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks.
next prev parent reply other threads:[~2021-10-27 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-26 14:20 [dpdk-dev] [PATCH] dma/idxd: fix truncated error code in status check Kevin Laatz
2021-10-27 13:08 ` Bruce Richardson
2021-10-27 15:00 ` Thomas Monjalon [this message]
2021-10-27 13:12 ` Walsh, Conor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2517999.mVafrqInaF@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=kevin.laatz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.