From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Lamparter via Linuxppc-dev Subject: Re: [PATCH v1 00/23] ata: sata_dwc_460ex: make it working again Date: Fri, 22 Apr 2016 13:06:15 +0200 Message-ID: <25199607.HghKfF60Bt@debian64> References: <1461262544-115408-1-git-send-email-andriy.shevchenko@linux.intel.com> <1939944.iP9HDO4haS@debian64> <571A0204.4050508@candw.ms> Reply-To: Christian Lamparter Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <571A0204.4050508@candw.ms> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Julian Margetson Cc: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Rob Herring , Tejun Heo , Andy Shevchenko , linuxppc-dev@lists.ozlabs.org List-Id: linux-ide@vger.kernel.org T24gRnJpZGF5LCBBcHJpbCAyMiwgMjAxNiAwNjo1MDo0NCBBTSBKdWxpYW4gTWFyZ2V0c29uIHdy b3RlOgo+IE9uIDQvMjEvMjAxNiA0OjI1IFBNLCBDaHJpc3RpYW4gTGFtcGFydGVyIHdyb3RlOgo+ ID4gT24gVGh1cnNkYXksIEFwcmlsIDIxLCAyMDE2IDA5OjE1OjIxIFBNIEFuZHkgU2hldmNoZW5r byB3cm90ZToKPiA+PiBUaGUgbGFzdCBhcHByb2FjaCBpbiB0aGUgY29tbWl0IDhiMzQ0NDg1MmEy YiAoInNhdGFfZHdjXzQ2MGV4OiBtb3ZlIHRvIGdlbmVyaWMKPiA+PiBETUEgZHJpdmVyIikgdG8g c3dpdGNoIHRvIGdlbmVyaWMgRE1BIGVuZ2luZSBBUEkgd2Fzbid0IHRlc3RlZCBvbiBiYXJlIG1l dGFsLgo+ID4+IEJlc2lkZXMgdGhhdCB3ZSBleHBlY3RpbmcgbmV3IGJvYXJkIHN1cHBvcnQgY29t aW5nIHdpdGggdGhlIHNhbWUgU0FUQSBJUCBidXQKPiA+PiB3aXRoIGRpZmZlcmVudCBETUEuCj4g Pj4KPiA+PiBUaGUgZHJpdmVyIGhhcyBiZWVuIHRlc3RlZCBteXNlbGYgb24gU2FtNDYwZXggYW5k IFdEIE15Qm9va0xpdmUgKGFwb2xsbzNnKQo+ID4+IGJvYXJkcy4gSW4gYW55IGNhc2UgSSBhc2sg Q2hyaXN0aWFuLCBNw6VucywgYW5kIEp1bGlhbiB0byBpbmRlcGVuZGVudGx5IHRlc3QgYW5kCj4g Pj4gcHJvdmlkZSBUZXN0ZWQtYnkgdGFnIG9yIGVycm9yIHJlcG9ydC4KPiA+IEkgZGlkIGEgdGVz dCBydW4gb24gbXkgV0QgTXlCb29rIExpdmUuIEkgYXBwbGllZCBhbGwgdGhlIHBhdGNoZXMgaW4K PiA+IHRoaXMgc2VyaWVzIG9uIHRvcCBvZiB0aGUgdG9waWMvZHcgYnJhbmNoIG9mIFZpbm9kIEtv dWw6Cj4gPiA8aHR0cHM6Ly9naXQua2VybmVsLm9yZy9jZ2l0L2xpbnV4L2tlcm5lbC9naXQvdmtv dWwvc2xhdmUtZG1hLmdpdC8+Cj4gPgo+ID4gVGVzdGVkLWJ5OiBDaHJpc3RpYW4gTGFtcGFydGVy IDxjaHVua2VleUBnb29nbGVtYWlsLmNvbT4KPiA+IC0tLQo+ID4gcmVzdWx0cyBmb3IgbXkgb2xk IFNUMzgwODExMEFTIEhERC4gZmlsZXN5c3RlbSBpcyBleHQ0Lgo+ID4KPiA+ICMgaGRwYXJtIC10 IC9kZXYvc2RhCj4gPgo+ID4gL2Rldi9zZGE6Cj4gPiAgIFRpbWluZyBidWZmZXJlZCBkaXNrIHJl YWRzOiAyMDQgTUIgaW4gIDMuMDIgc2Vjb25kcyA9ICA2Ny41MSBNQi9zZWMKPiA+Cj4gPiAjIGJv bm5pZSsrIC11IG1ibAo+ID4gVXNpbmcgdWlkOjEwMDAsIGdpZDoxMDAwLgo+ID4gV3JpdGluZyBh IGJ5dGUgYXQgYSB0aW1lLi4uZG9uZQo+ID4gV3JpdGluZyBpbnRlbGxpZ2VudGx5Li4uZG9uZQo+ ID4gUmV3cml0aW5nLi4uZG9uZQo+ID4gUmVhZGluZyBhIGJ5dGUgYXQgYSB0aW1lLi4uZG9uZQo+ ID4gUmVhZGluZyBpbnRlbGxpZ2VudGx5Li4uZG9uZQo+ID4gc3RhcnQgJ2VtLi4uZG9uZS4uLmRv bmUuLi5kb25lLi4uZG9uZS4uLmRvbmUuLi4KPiA+IENyZWF0ZSBmaWxlcyBpbiBzZXF1ZW50aWFs IG9yZGVyLi4uZG9uZS4KPiA+IFN0YXQgZmlsZXMgaW4gc2VxdWVudGlhbCBvcmRlci4uLmRvbmUu Cj4gPiBEZWxldGUgZmlsZXMgaW4gc2VxdWVudGlhbCBvcmRlci4uLmRvbmUuCj4gPiBDcmVhdGUg ZmlsZXMgaW4gcmFuZG9tIG9yZGVyLi4uZG9uZS4KPiA+IFN0YXQgZmlsZXMgaW4gcmFuZG9tIG9y ZGVyLi4uZG9uZS4KPiA+IERlbGV0ZSBmaWxlcyBpbiByYW5kb20gb3JkZXIuLi5kb25lLgo+ID4g VmVyc2lvbiAgMS45NyAgICAgICAtLS0tLS1TZXF1ZW50aWFsIE91dHB1dC0tLS0tLSAtLVNlcXVl bnRpYWwgSW5wdXQtIC0tUmFuZG9tLQo+ID4gQ29uY3VycmVuY3kgICAxICAgICAtUGVyIENoci0g LS1CbG9jay0tIC1SZXdyaXRlLSAtUGVyIENoci0gLS1CbG9jay0tIC0tU2Vla3MtLQo+ID4gTWFj aGluZSAgICAgICAgU2l6ZSBLL3NlYyAlQ1AgSy9zZWMgJUNQIEsvc2VjICVDUCBLL3NlYyAlQ1Ag Sy9zZWMgJUNQICAvc2VjICVDUAo+ID4gbWJsICAgICAgICAgICAgNDk2TSAgICA5OCAgOTkgMjYw MTEgIDIxIDE3NTg5ICAyMCAgIDUzOCAgOTkgODAxMzggIDM5IDIwOC45ICAgOAo+ID4gTGF0ZW5j eSAgICAgICAgICAgICA5NTI2N3VzICAgIDE0MDltcyAgICAgMjk1bXMgICAyNjk0N3VzICAgIDk2 NDR1cyAgICAxNzg3bXMKPiA+IFZlcnNpb24gIDEuOTcgICAgICAgLS0tLS0tU2VxdWVudGlhbCBD cmVhdGUtLS0tLS0gLS0tLS0tLS1SYW5kb20gQ3JlYXRlLS0tLS0tLS0KPiA+IG1ibCAgICAgICAg ICAgICAgICAgLUNyZWF0ZS0tIC0tUmVhZC0tLSAtRGVsZXRlLS0gLUNyZWF0ZS0tIC0tUmVhZC0t LSAtRGVsZXRlLS0KPiA+ICAgICAgICAgICAgICAgIGZpbGVzICAvc2VjICVDUCAgL3NlYyAlQ1Ag IC9zZWMgJUNQICAvc2VjICVDUCAgL3NlYyAlQ1AgIC9zZWMgJUNQCj4gPiAgICAgICAgICAgICAg ICAgICAxNiAgNjk1OSAgNzggKysrKysgKysrICA1MTk3ICA0MCAgNzI1MCAgNzkgKysrKysgKysr ICA0NzE4ICAzNwo+ID4gTGF0ZW5jeSAgICAgICAgICAgICAgIDE0OW1zICAgIDY3NDJ1cyAgICAg MjEybXMgICAgIDE3N21zICAgICA3Njd1cyAgICAgMjE3bXMKPiA+IDEuOTcsMS45NyxtYmwsMSwx NDYxMjY5NzcxLDQ5Nk0sLDk4LDk5LDI2MDExLDIxLDE3NTg5LDIwLDUzOCw5OSw4MDEzOCwzOSwy MDguOSw4LDE2LCwsLCw2OTU5LDc4LCsrKysrLCsrKyw1MTk3LDQwLDcyNTAsNzksKysrKyssKysr LDQ3MTgsMzcsOTUyNjd1cywxNDA5bXMsMjk1bXMsMjY5NDd1cyw5NjQ0dXMsMTc4N21zLDE0OW1z LDY3NDJ1cywyMTJtcywxNzdtcyw3Njd1cywyMTdtcwo+ID4KPiBBZ2FpbiBvbiBjb3B5IHBhcnRp dGlvbnMgLgoKT2ssIGhlcmUncyB0aGUgY29weSBmcm9tIG15IG1haWwgb2ZmLWxpc3QuCgpXZWxs LCBhIHVucmVsYXRlZCBkcml2ZXIgIm00MXQ4MCIgY2F1c2VkIGEgY3Jhc2g6ClsgICAxMi45MTI3 MzldIE9vcHM6IEtlcm5lbCBhY2Nlc3Mgb2YgYmFkIGFyZWEsIHNpZzogMTEgWyMzXQpbICAgMTIu OTEyNzQzXSBQUkVFTVBUIENhbnlvbmxhbmRzClsgICAxMi45MTI3NTNdIENQVTogMCBQSUQ6IDE0 MTMgQ29tbTogaXJxLzQ1LW00MXQ4MCBUYWludGVkOiBHICAgICAgRCAgICAgICAgIDQuNi4wLXJj NC1uZXh0LTIwMTYwNDIxLXNhbTQ2MGV4LWptICMxClsgICAxMi45MTI3NTddIHRhc2s6IGVhOTgz NGUwIHRpOiBlZWE2YzAwMCB0YXNrLnRpOiBlZWE2YzAwMApbICAgMTIuOTEyNzYwXSBOSVA6IGMw MjI0NDgwIExSOiBjMDAyMzQ5NCBDVFI6IGMwMDQyNTA4ClsgICAxMi45MTI3NjRdIFJFR1M6IGVl YTZkYWYwIFRSQVA6IDAzMDAgICBUYWludGVkOiBHICAgICAgRCAgICAgICAgICAoNC42LjAtcmM0 LW5leHQtMjAxNjA0MjEtc2FtNDYwZXgtam0pClsgICAxMi45MTI3NzRdIE1TUjogMDAwMjkwMDAg PENFLEVFLE1FPiAgQ1I6IDI0MDA4MjgyICBYRVI6IDAwMDAwMDAwClsgICAxMi45MTI4MjVdIERF QVI6IDAwMDAwMDA4IEVTUjogMDAwMDAwMDAgClsuLi5dClsgICAxMi45MTI5MjddIC0tLSBpbnRl cnJ1cHQ6IDMwMCBhdCBtdXRleF9sb2NrKzB4MC8weDFjClsgICAxMi45MTI5MjddICAgICBMUiA9 IG00MXQ4MF9oYW5kbGVfaXJxKzB4MjgvMHhhYwpbICAgMTIuOTEyOTMyXSBbZWVhNmRlNDBdIFsw MDAwMDAwMF0gICAobnVsbCkgKHVucmVsaWFibGUpClsgICAxMi45MTI5MzhdIFtlZWE2ZGU2MF0g W2MwMDRmZmFjXSBpcnFfdGhyZWFkX2ZuKzB4MmMvMHg0OApbICAgMTIuOTEyOTQ0XSBbZWVhNmRl ODBdIFtjMDA1MDFjY10gaXJxX3RocmVhZCsweGM0LzB4MTYwClsgICAxMi45MTI5NTFdIFtlZWE2 ZGVkMF0gW2MwMDNhM2Y4XSBrdGhyZWFkKzB4YzgvMHhjYwpbICAgMTIuOTEyOTU3XSBbZWVhNmRm NDBdIFtjMDAwYWVlOF0gcmV0X2Zyb21fa2VybmVsX3RocmVhZCsweDVjLzB4NjQKWyAgIDEyLjkx Mjk2MF0gSW5zdHJ1Y3Rpb24gZHVtcDoKWyAgIDEyLjkxMjk3NF0gODAwMTAwMTQgN2ZjM2YzNzgg YmJjMTAwMDggN2MwODAzYTYgMzgyMTAwMTAgNGJlMjRjYTggOTQyMWZmZDAgN2MwODAyYTYgClsg ICAxMi45MTI5ODddIGJmMjEwMDE0IDkwMDEwMDM0IDNiNDMwMmQ4IDgxMjMwMmVjIDw4Mzg5MDAw OD4gODEyMzAyZDggN2Y5YTQ4NDAgNDE5ZTAxMWMgClsgICAxMi45MTI5OTVdIEZpeGluZyByZWN1 cnNpdmUgZmF1bHQgYnV0IHJlYm9vdCBpcyBuZWVkZWQhCiAgICAgICAgICAgICAgICAgXl5eICJy ZWJvb3QgaXMgbmVlZGVkISIKCkFub3RoZXIgdGhpbmcgdGhhdCBjYW1lIHRvIG15IG1pbmQ6IEhh dmUgeW91IGNoZWNrZWQgaWYgeW91ciBoYXJkIGRyaXZlCmFuZCB0aGUgY2FibGVzIGFyZSBvaz8g QXJlIHRoZXJlIGFueSBwZW5kaW5nIHNlY3RvcnMgb3Igc3VzcGljaW91cyBzbWFydAp2YWx1ZXM/ IEhhcyB0aGUgZHJpdmUgcGFzc2VkIHRoZSBleHRlbmRlZCBvZmZsaW5lIHRlc3Q/CiAKT3RoZXJ3 aXNlLCBJIGNhbid0IHJlcHJvZHVjZSB0aGUgZXJyb3Igd2l0aCBteSBNeUJvb2sgc3lzdGVtLiBJ J3ZlIHRlc3RlZAp5b3VyIGtlcm5lbCBhbmQgaXQgd29ya2VkIG9uIHRoZSBkZXZpY2Ugd2l0aG91 dCBjcmFzaGluZy4gKEkgY29waWVkL2RkJ2VkCjgwR0IgZnJvbSBhbmQgYmFjayB0byB0aGUgaGFy ZC1kcml2ZS4gSXQgd2FzIGxvbmcgYW5kIGJvcmluZywgYnV0IEkgZGlkbid0CmVuY291bnRlciBh bnkgaXNzdWVzIGFuZCB0aGUgY3JjMzIgbWF0Y2hlZCkuCgpTb3JyeSwgYnV0IEkgY2FuJ3QgaGVs cCB5b3UgaWYgSSBjYW4ndCByZXByb2R1Y2UgaXQuLi4gQW5kIHNob3J0IG9mIHNlbmRpbmcKeW91 ciBib3ggdG8gdGVzdCwgSSBzZWUgbm8gZWZmaWNpZW50IHdheSB0byBkZWJ1ZyBpdC4gSG93ZXZl ciwgd2hhdCBJIGNhbgpkbywgaWYgeW91IGFyZSBpbnRlcmVzdGVkOiBJIGhhdmUgYSBmZXcgImJ1 aWxkIHlvdXIgb3duIiBNeSBCb29rIExpdmUga2l0cy4KSXQganVzdCBuZWVkcyBhIDMuNSIgaGFy ZC1kcml2ZSBhbmQgMTJ2IHBvd2VyIGFkYXB0ZXIuIElmIHlvdSBhcmUgaW50ZXJlc3RlZApQTSBt ZSBvZmYtbGlzdCwgdGhpcyB3YXkgeW91IGNhbiB2ZXJpZnkgdGhhdCB0aGUga2VybmVscyB5b3Ug YnVpbGQgZG8gd29yaywKanVzdCBpbiBjYXNlIHRoaXMgZXJyb3IgaXMgZHVlIHRvIGEgaGFyZHdh cmUgaXNzdWUgKHphcHBlZCBjb250cm9sbGVyLCAKYmFkIHJhbS9kcml2ZS9jYWJsZT8pIHdpdGgg eW91ciBzYW00NjBleCBib3guCgpSZWdhcmRzLApDaHJpc3RpYW4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMtZGV2IG1haWxpbmcgbGlzdApM aW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlz dGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3qrt8s32j4zDq5g for ; Fri, 22 Apr 2016 21:06:21 +1000 (AEST) Received: by mail-wm0-x243.google.com with SMTP id e201so3319724wme.2 for ; Fri, 22 Apr 2016 04:06:21 -0700 (PDT) From: Christian Lamparter To: Julian Margetson Cc: Andy Shevchenko , Tejun Heo , linux-ide@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: [PATCH v1 00/23] ata: sata_dwc_460ex: make it working again Date: Fri, 22 Apr 2016 13:06:15 +0200 Message-ID: <25199607.HghKfF60Bt@debian64> In-Reply-To: <571A0204.4050508@candw.ms> References: <1461262544-115408-1-git-send-email-andriy.shevchenko@linux.intel.com> <1939944.iP9HDO4haS@debian64> <571A0204.4050508@candw.ms> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday, April 22, 2016 06:50:44 AM Julian Margetson wrote: > On 4/21/2016 4:25 PM, Christian Lamparter wrote: > > On Thursday, April 21, 2016 09:15:21 PM Andy Shevchenko wrote: > >> The last approach in the commit 8b3444852a2b ("sata_dwc_460ex: mov= e to generic > >> DMA driver") to switch to generic DMA engine API wasn't tested on = bare metal. > >> Besides that we expecting new board support coming with the same S= ATA IP but > >> with different DMA. > >> > >> The driver has been tested myself on Sam460ex and WD MyBookLive (a= pollo3g) > >> boards. In any case I ask Christian, M=E5ns, and Julian to indepen= dently test and > >> provide Tested-by tag or error report. > > I did a test run on my WD MyBook Live. I applied all the patches in= > > this series on top of the topic/dw branch of Vinod Koul: > > = > > > > Tested-by: Christian Lamparter > > --- > > results for my old ST3808110AS HDD. filesystem is ext4. > > > > # hdparm -t /dev/sda > > > > /dev/sda: > > Timing buffered disk reads: 204 MB in 3.02 seconds =3D 67.51 MB= /sec > > > > # bonnie++ -u mbl > > Using uid:1000, gid:1000. > > Writing a byte at a time...done > > Writing intelligently...done > > Rewriting...done > > Reading a byte at a time...done > > Reading intelligently...done > > start 'em...done...done...done...done...done... > > Create files in sequential order...done. > > Stat files in sequential order...done. > > Delete files in sequential order...done. > > Create files in random order...done. > > Stat files in random order...done. > > Delete files in random order...done. > > Version 1.97 ------Sequential Output------ --Sequential Inpu= t- --Random- > > Concurrency 1 -Per Chr- --Block-- -Rewrite- -Per Chr- --Block= -- --Seeks-- > > Machine Size K/sec %CP K/sec %CP K/sec %CP K/sec %CP K/sec %= CP /sec %CP > > mbl 496M 98 99 26011 21 17589 20 538 99 80138 = 39 208.9 8 > > Latency 95267us 1409ms 295ms 26947us 9644us= 1787ms > > Version 1.97 ------Sequential Create------ --------Random Cr= eate-------- > > mbl -Create-- --Read--- -Delete-- -Create-- --Read-= -- -Delete-- > > files /sec %CP /sec %CP /sec %CP /sec %CP /sec = %CP /sec %CP > > 16 6959 78 +++++ +++ 5197 40 7250 79 +++++ = +++ 4718 37 > > Latency 149ms 6742us 212ms 177ms 767us= 217ms > > 1.97,1.97,mbl,1,1461269771,496M,,98,99,26011,21,17589,20,538,99,801= 38,39,208.9,8,16,,,,,6959,78,+++++,+++,5197,40,7250,79,+++++,+++,4718,3= 7,95267us,1409ms,295ms,26947us,9644us,1787ms,149ms,6742us,212ms,177ms,7= 67us,217ms > > > Again on copy partitions . Ok, here's the copy from my mail off-list. Well, a unrelated driver "m41t80" caused a crash: [ 12.912739] Oops: Kernel access of bad area, sig: 11 [#3] [ 12.912743] PREEMPT Canyonlands [ 12.912753] CPU: 0 PID: 1413 Comm: irq/45-m41t80 Tainted: G D = 4.6.0-rc4-next-20160421-sam460ex-jm #1 [ 12.912757] task: ea9834e0 ti: eea6c000 task.ti: eea6c000 [ 12.912760] NIP: c0224480 LR: c0023494 CTR: c0042508 [ 12.912764] REGS: eea6daf0 TRAP: 0300 Tainted: G D (= 4.6.0-rc4-next-20160421-sam460ex-jm) [ 12.912774] MSR: 00029000 CR: 24008282 XER: 00000000 [ 12.912825] DEAR: 00000008 ESR: 00000000=20 [...] [ 12.912927] --- interrupt: 300 at mutex_lock+0x0/0x1c [ 12.912927] LR =3D m41t80_handle_irq+0x28/0xac [ 12.912932] [eea6de40] [00000000] (null) (unreliable) [ 12.912938] [eea6de60] [c004ffac] irq_thread_fn+0x2c/0x48 [ 12.912944] [eea6de80] [c00501cc] irq_thread+0xc4/0x160 [ 12.912951] [eea6ded0] [c003a3f8] kthread+0xc8/0xcc [ 12.912957] [eea6df40] [c000aee8] ret_from_kernel_thread+0x5c/0x64 [ 12.912960] Instruction dump: [ 12.912974] 80010014 7fc3f378 bbc10008 7c0803a6 38210010 4be24ca8 94= 21ffd0 7c0802a6=20 [ 12.912987] bf210014 90010034 3b4302d8 812302ec <83890008> 812302d8 = 7f9a4840 419e011c=20 [ 12.912995] Fixing recursive fault but reboot is needed! ^^^ "reboot is needed!" Another thing that came to my mind: Have you checked if your hard drive= and the cables are ok? Are there any pending sectors or suspicious smar= t values? Has the drive passed the extended offline test? =20 Otherwise, I can't reproduce the error with my MyBook system. I've test= ed your kernel and it worked on the device without crashing. (I copied/dd'= ed 80GB from and back to the hard-drive. It was long and boring, but I did= n't encounter any issues and the crc32 matched). Sorry, but I can't help you if I can't reproduce it... And short of sen= ding your box to test, I see no efficient way to debug it. However, what I c= an do, if you are interested: I have a few "build your own" My Book Live k= its. It just needs a 3.5" hard-drive and 12v power adapter. If you are inter= ested PM me off-list, this way you can verify that the kernels you build do w= ork, just in case this error is due to a hardware issue (zapped controller,=20= bad ram/drive/cable?) with your sam460ex box. Regards, Christian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753346AbcDVLTf (ORCPT ); Fri, 22 Apr 2016 07:19:35 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34156 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753492AbcDVLGT convert rfc822-to-8bit (ORCPT ); Fri, 22 Apr 2016 07:06:19 -0400 From: Christian Lamparter To: Julian Margetson Cc: Andy Shevchenko , Tejun Heo , linux-ide@vger.kernel.org, Rob Herring , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: [PATCH v1 00/23] ata: sata_dwc_460ex: make it working again Date: Fri, 22 Apr 2016 13:06:15 +0200 Message-ID: <25199607.HghKfF60Bt@debian64> User-Agent: KMail/4.14.10 (Linux/4.6.0-rc3-wt+; KDE/4.14.14; x86_64; ; ) In-Reply-To: <571A0204.4050508@candw.ms> References: <1461262544-115408-1-git-send-email-andriy.shevchenko@linux.intel.com> <1939944.iP9HDO4haS@debian64> <571A0204.4050508@candw.ms> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, April 22, 2016 06:50:44 AM Julian Margetson wrote: > On 4/21/2016 4:25 PM, Christian Lamparter wrote: > > On Thursday, April 21, 2016 09:15:21 PM Andy Shevchenko wrote: > >> The last approach in the commit 8b3444852a2b ("sata_dwc_460ex: move to generic > >> DMA driver") to switch to generic DMA engine API wasn't tested on bare metal. > >> Besides that we expecting new board support coming with the same SATA IP but > >> with different DMA. > >> > >> The driver has been tested myself on Sam460ex and WD MyBookLive (apollo3g) > >> boards. In any case I ask Christian, Måns, and Julian to independently test and > >> provide Tested-by tag or error report. > > I did a test run on my WD MyBook Live. I applied all the patches in > > this series on top of the topic/dw branch of Vinod Koul: > > > > > > Tested-by: Christian Lamparter > > --- > > results for my old ST3808110AS HDD. filesystem is ext4. > > > > # hdparm -t /dev/sda > > > > /dev/sda: > > Timing buffered disk reads: 204 MB in 3.02 seconds = 67.51 MB/sec > > > > # bonnie++ -u mbl > > Using uid:1000, gid:1000. > > Writing a byte at a time...done > > Writing intelligently...done > > Rewriting...done > > Reading a byte at a time...done > > Reading intelligently...done > > start 'em...done...done...done...done...done... > > Create files in sequential order...done. > > Stat files in sequential order...done. > > Delete files in sequential order...done. > > Create files in random order...done. > > Stat files in random order...done. > > Delete files in random order...done. > > Version 1.97 ------Sequential Output------ --Sequential Input- --Random- > > Concurrency 1 -Per Chr- --Block-- -Rewrite- -Per Chr- --Block-- --Seeks-- > > Machine Size K/sec %CP K/sec %CP K/sec %CP K/sec %CP K/sec %CP /sec %CP > > mbl 496M 98 99 26011 21 17589 20 538 99 80138 39 208.9 8 > > Latency 95267us 1409ms 295ms 26947us 9644us 1787ms > > Version 1.97 ------Sequential Create------ --------Random Create-------- > > mbl -Create-- --Read--- -Delete-- -Create-- --Read--- -Delete-- > > files /sec %CP /sec %CP /sec %CP /sec %CP /sec %CP /sec %CP > > 16 6959 78 +++++ +++ 5197 40 7250 79 +++++ +++ 4718 37 > > Latency 149ms 6742us 212ms 177ms 767us 217ms > > 1.97,1.97,mbl,1,1461269771,496M,,98,99,26011,21,17589,20,538,99,80138,39,208.9,8,16,,,,,6959,78,+++++,+++,5197,40,7250,79,+++++,+++,4718,37,95267us,1409ms,295ms,26947us,9644us,1787ms,149ms,6742us,212ms,177ms,767us,217ms > > > Again on copy partitions . Ok, here's the copy from my mail off-list. Well, a unrelated driver "m41t80" caused a crash: [ 12.912739] Oops: Kernel access of bad area, sig: 11 [#3] [ 12.912743] PREEMPT Canyonlands [ 12.912753] CPU: 0 PID: 1413 Comm: irq/45-m41t80 Tainted: G D 4.6.0-rc4-next-20160421-sam460ex-jm #1 [ 12.912757] task: ea9834e0 ti: eea6c000 task.ti: eea6c000 [ 12.912760] NIP: c0224480 LR: c0023494 CTR: c0042508 [ 12.912764] REGS: eea6daf0 TRAP: 0300 Tainted: G D (4.6.0-rc4-next-20160421-sam460ex-jm) [ 12.912774] MSR: 00029000 CR: 24008282 XER: 00000000 [ 12.912825] DEAR: 00000008 ESR: 00000000 [...] [ 12.912927] --- interrupt: 300 at mutex_lock+0x0/0x1c [ 12.912927] LR = m41t80_handle_irq+0x28/0xac [ 12.912932] [eea6de40] [00000000] (null) (unreliable) [ 12.912938] [eea6de60] [c004ffac] irq_thread_fn+0x2c/0x48 [ 12.912944] [eea6de80] [c00501cc] irq_thread+0xc4/0x160 [ 12.912951] [eea6ded0] [c003a3f8] kthread+0xc8/0xcc [ 12.912957] [eea6df40] [c000aee8] ret_from_kernel_thread+0x5c/0x64 [ 12.912960] Instruction dump: [ 12.912974] 80010014 7fc3f378 bbc10008 7c0803a6 38210010 4be24ca8 9421ffd0 7c0802a6 [ 12.912987] bf210014 90010034 3b4302d8 812302ec <83890008> 812302d8 7f9a4840 419e011c [ 12.912995] Fixing recursive fault but reboot is needed! ^^^ "reboot is needed!" Another thing that came to my mind: Have you checked if your hard drive and the cables are ok? Are there any pending sectors or suspicious smart values? Has the drive passed the extended offline test? Otherwise, I can't reproduce the error with my MyBook system. I've tested your kernel and it worked on the device without crashing. (I copied/dd'ed 80GB from and back to the hard-drive. It was long and boring, but I didn't encounter any issues and the crc32 matched). Sorry, but I can't help you if I can't reproduce it... And short of sending your box to test, I see no efficient way to debug it. However, what I can do, if you are interested: I have a few "build your own" My Book Live kits. It just needs a 3.5" hard-drive and 12v power adapter. If you are interested PM me off-list, this way you can verify that the kernels you build do work, just in case this error is due to a hardware issue (zapped controller, bad ram/drive/cable?) with your sam460ex box. Regards, Christian