From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Wed, 04 Jan 2017 12:41:49 +0000 Subject: Re: [v1] video:fbdev:cobalt_lcdfb:- Handle return NULL error from devm_ioremap Message-Id: <2521746.Pc0WRFopsW@amdc3058> List-Id: References: <1481617252-8298-1-git-send-email-arvind.yadav.cs@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Yuasa Yoichi , Arvind Yadav Cc: tomi.valkeinen@ti.com, ralf@linux-mips.org, paul.burton@imgtec.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Hi, On Wednesday, December 14, 2016 11:23:07 AM Yuasa Yoichi wrote: > Hi Arvind, > > Thank you for fixing it. > > Acked-by: Yoichi Yuasa > > 2016-12-13 17:20 GMT+09:00 Arvind Yadav : > > Here, If devm_ioremap will fail. It will return NULL. > > Kernel can run into a NULL-pointer dereference. > > This error check will avoid NULL pointer dereference. > > > > Signed-off-by: Arvind Yadav Applied & queued for v4.10. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbdADMmL (ORCPT ); Wed, 4 Jan 2017 07:42:11 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:55935 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbdADMl5 (ORCPT ); Wed, 4 Jan 2017 07:41:57 -0500 X-AuditID: b6c32a37-f79116d000000e56-24-586ced907930 From: Bartlomiej Zolnierkiewicz To: Yuasa Yoichi , Arvind Yadav Cc: tomi.valkeinen@ti.com, ralf@linux-mips.org, paul.burton@imgtec.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [v1] video:fbdev:cobalt_lcdfb:- Handle return NULL error from devm_ioremap Date: Wed, 04 Jan 2017 13:41:49 +0100 Message-id: <2521746.Pc0WRFopsW@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsWy7bCmge6EtzkRBlemSFlc613IbHGi7wOr xeVdc9gs7u/byG5xaY+Kxfr5t9gs3l57xO7A7rFz1l12j56dZxg9jq5cy+Rx/MZ2Jo/Pm+QC WKO4bFJSczLLUov07RK4Mr5fe8ZY8IKl4sKja4wNjB+Yuxg5OSQETCSWND5nh7DFJC7cW8/W xcjFISSwg1Fi9+az7BBOO5PEtn03WWE6ru39yQKRmMMo8XPPRVYI5yujxJ5VK1hAqtgErCQm tq9iBLFFBIIlHm1ayQRSxCzQDNSxYyMTSEJYIFLi5PS9bCA2i4CqRM/fBjCbV0BT4kvTM7BB ogJeElv2tYPVcwINmvjtPitEjaDEj8n3wGqYBeQl9u2fygph60icPbaOEWSZhMAidom+jc+B hnIAObISmw5APe0i8eB7P9Q7whKvjm+BBoC0xKp/t5gg7OmMEtt/S0DM2cwosWr3BKgia4nD xy9CLeOTePe1hxViPq9ER5sQRImHRMvUDnaIsKPE92YVSAA9ZpRY1nKYfQKj/CwkL8xC8sIs JC8sYGRexSiWWlCcm55abFhgrFecmFtcmpeul5yfu4kRnFS0zHcwbjjnc4hRgINRiYd3xaLs CCHWxLLiytxDjBIczEoivN9e5EQI8aYkVlalFuXHF5XmpBYfYpTmYFES513caB0hJJCeWJKa nZpakFoEk2Xi4JRqYDQR/23pOUF4X/Pk31MapIWmSrMU3Y//77hqs7bZDP/G7Km6cwI9J53f 3Zq4bOMFX7O785UZX+Zye1o1Tb6dyq21xSjk2qQi+w1C5ilLhSNeK8yXSv4oKuzTdipnFuPu sr7OV35amveOln8MllSNtq5q2qHSUzr7isAHn9ZTc4tPrMnfZ7aJWYmlOCPRUIu5qDgRAMY7 HvEmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrGIsWRmVeSWpSXmKPExsVy+t9jQd0Jb3MiDPa84LO41ruQ2eJE3wdW i8u75rBZ3N+3kd3i0h4Vi/Xzb7FZvL32iN2B3WPnrLvsHj07zzB6HF25lsnj+I3tTB6fN8kF sEa52WSkJqakFimk5iXnp2TmpdsqhYa46VooKeQl5qbaKkXo+oYEKSmUJeaUAnlGBmjAwTnA PVhJ3y7BLeP7tWeMBS9YKi48usbYwPiBuYuRk0NCwETi2t6fLBC2mMSFe+vZuhi5OIQEZjFK bPzQDOV8ZZR4+eAqG0gVm4CVxMT2VYwgtohAsETnnr+MIEXMAs2MEhMmXQAbKywQKXFy+l6w BhYBVYmevw1gNq+ApsSXpmdg60QFvCS27GtnArE5gQbNfH2UHWJbP6PEgxUnWCAaBCV+TL4H ZjMLyEvs2z+VFcLWkli/8zjTBEagQxHKZiEpm4WkbAEj8ypGidSC5ILipPRcw7zUcr3ixNzi 0rx0veT83E2M4Dh7JrWD8eAu90OMAhyMSjy8AvdzIoRYE8uKK3MPMUpwMCuJ8H57ARTiTUms rEotyo8vKs1JLT7EaAr04URmKdHkfGAKyCuJNzQxNzE3NrAwt7Q0MVIS522c/SxcSCA9sSQ1 OzW1ILUIpo+Jg1OqgTHWzqWMx0WG8crVMuvFRZfP3bzF1n56BRO3y4xZN70mOyXHJhzdERX+ dS7LJN9XW292ijYxL3d5r5X8euXm5oS0v/kS76eVam5k4VTdVP7zcKb19aoaxocWLUbvTqor LFXL43F+mlpxnLe7qTW43tbA8XVVeGfwxaCf1RH9IdeXZebmn1FdpcRSnJFoqMVcVJwIAGfY 9zHJAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170104124152epcas1p2f74f40d8d9d361c98a1bcd463a8fe1cd X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170104124152epcas1p2f74f40d8d9d361c98a1bcd463a8fe1cd X-RootMTR: 20170104124152epcas1p2f74f40d8d9d361c98a1bcd463a8fe1cd References: <1481617252-8298-1-git-send-email-arvind.yadav.cs@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wednesday, December 14, 2016 11:23:07 AM Yuasa Yoichi wrote: > Hi Arvind, > > Thank you for fixing it. > > Acked-by: Yoichi Yuasa > > 2016-12-13 17:20 GMT+09:00 Arvind Yadav : > > Here, If devm_ioremap will fail. It will return NULL. > > Kernel can run into a NULL-pointer dereference. > > This error check will avoid NULL pointer dereference. > > > > Signed-off-by: Arvind Yadav Applied & queued for v4.10. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics