From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] doc: announce ABI change for librte_port Date: Thu, 16 Jul 2015 14:25:49 +0200 Message-ID: <2522078.kODQ7Zxo1C@xps13> References: <1437049176-6866-1-git-send-email-cristian.dumitrescu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Cristian Dumitrescu Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 53168C35E for ; Thu, 16 Jul 2015 14:27:00 +0200 (CEST) Received: by widic2 with SMTP id ic2so13833229wid.0 for ; Thu, 16 Jul 2015 05:27:00 -0700 (PDT) In-Reply-To: <1437049176-6866-1-git-send-email-cristian.dumitrescu@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-16 13:19, Cristian Dumitrescu: > +* librte_port (rte_port.h): Macros to access the packet meta-data stored within > + the packet buffer will be adjusted to cover the packet mbuf structure as well, > + as currently they are able to access any packet buffer location except the > + packet mbuf structure. The consequence is that applications currently using > + these macros will have to adjust the value of the offset parameter of these > + macros by increasing it with sizeof(struc rte_mbuf). The affected macros are: > + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>_PTR and > + RTE_MBUF_METADATA_UINT<8, 16, 32, 64>. In terms of code changes, most likely > + only the definition of RTE_MBUF_METADATA_UINT8_PTR macro will be changed from > + ``(&((uint8_t *) &(mbuf)[1])[offset])`` to > + ``(&((uint8_t *) (mbuf))[offset])``. Cristian, General comment: you are too verbose :) Specifically on this patch: same comment ;)