Re: [PATCH 4/5] arm64: dts: renesas: ulcb: Add HDMI output connector

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Vladimir,

Thank you for the patch.

On Friday 07 Jul 2017 05:37:36 Vladimir Barinov wrote:
> From: Vladimir Barinov <vladimir.barinov+renesas@cogentembedded.com>
> 
> The ULCB board has one HDMI output connector.
> 
> This connector is available on both the H3 and M3-W ULCB boards.
> Add this to the ulcb.dtsi file.
> 
> Signed-off-by: Vladimir Barinov
> <vladimir.barinov+renesas@cogentembedded.com> ---
>  arch/arm64/boot/dts/renesas/ulcb.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> b/arch/arm64/boot/dts/renesas/ulcb.dtsi index 6f0a7ca..fc5408d 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb.dtsi
> @@ -34,6 +34,17 @@
>  		clock-frequency = <11289600>;
>  	};
> 
> +	hdmi0-out {
> +		compatible = "hdmi-connector";
> +		label = "HDMI0 OUT";

As far as I know there is no "HDMI0 OUT" label on the board or casing. You can 
remove the label property. Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +		type = "a";
> +
> +		port {
> +			hdmi0_con: endpoint {
> +			};
> +		};
> +	};
> +
>  	keyboard {
>  		compatible = "gpio-keys";

-- 
Regards,

Laurent Pinchart