All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Shannon Zhao <zhaoshenglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] cpu_layout.py: adjust output format to align
Date: Tue, 27 May 2014 12:30:16 +0200	[thread overview]
Message-ID: <2531802.9vWkcExQfx@xps13> (raw)
In-Reply-To: <53845DC5.3000400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

Hi,

Your patch doesn't apply correctly.
Could you check it, please?

I have also a comment inlined:

2014-05-27 17:41, Shannon Zhao:
> -               print "\t", core_map[(s,c)],
> +               print core_map[(s,c)],"\t",

Is it possible to fix a minimum alignment of 2 characters?
It could prevent from such alignment problem:

Core 11 [9, 33]         [21, 45] 
Core 12 [10, 34]        [22, 46] 

Thanks
-- 
Thomas

  parent reply	other threads:[~2014-05-27 10:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-27  9:41 [PATCH] cpu_layout.py: adjust output format to align Shannon Zhao
     [not found] ` <53845DC5.3000400-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-05-27 10:30   ` Thomas Monjalon [this message]
2014-05-28  3:02     ` Shannon Zhao
     [not found]       ` <538551CC.3000108-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2014-05-28  9:23         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2531802.9vWkcExQfx@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=zhaoshenglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.