All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Subject: Re: grub-mkrescue problems in argp_parse
Date: Wed, 29 Apr 2015 18:57:30 +0200	[thread overview]
Message-ID: <25321568600134319256@scdbackup.webframe.org> (raw)
In-Reply-To: <5540E510.6040002@gmail.com>

Hi,

> We need for compatibility:
> -o
> --output

This is an intentional interference because grub-mkrescue -o
is supposed to overload mkisofs -o.
--output is not a mkisofs alias of -o, but rather -output.

So in order to keep grub-mkrescue users from circumventing
the overloading, grub-mkrescue should accept -output as alias
of -o and --output.


> -?

Yikes ! You can have that one.

> -d

Used in old mkisofs.
"Do not add trailing dot to ISO file names without dot."
An alias is available: -omit-period

> -k

Seems to be unused in traditional mkisofs and genisoimage.
I do not add single-letter options on my own.


> --rom-directory
> ...
> --verbose

Not in use yet by xorriso resp. xorriso -as mkisofs .
Some of the option names are quite unspecific, though.


> In future we can make a rule to add only options starting with --.

This will not really create clarity because i already added
options with "--" to -as mkisofs. Mainly to get out of
the way of future mkisofs extensions. The current option
set of xorriso -as mkisofs is strictly irregular.

The generic command interpreter of xorriso ignores leading '-'
completely and maps inner '-' to underscores '_'.
I.e.  set_filter_r , ----set-filter_r, --set-filter-r
are all recognized as valid command -set_filter_r.
(The interpreter can afford this because it is always aware
 when the next word is supposed to be a command.)
 

> > --modules --grub-mkimage --override-directory
> > Will they be re-introduced ? (Should they ? What did they do ?)
> They're there. If you have data suggesting otherwise, please detail it

You are right. I did not see them in
  http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-mkrescue.c
but now found them in
  http://git.savannah.gnu.org/cgit/grub.git/tree/include/grub/util/install.h
  http://git.savannah.gnu.org/cgit/grub.git/tree/util/grub-install-common.c

(Would it be ok and sufficient to call grub_install_parse ()
 from my proposed legacy parser when it encounters one of
 the three options ?)


---------------------------------------------------------

I have now made a file with the reserved option/command
names. Hopefully i remember to check it when i introduce
new names. (If not, i will have to solve collisions by
introducing aliases and deprecating my bad choices.)

Nevertheless i doubt that it is a good idea to stick for
future development with the implicit distinction between
arguments for grub-mkrescue and for xorriso.
This has potential for recurrent pain.


Have a nice day :)

Thomas



  parent reply	other threads:[~2015-04-29 16:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2037922098.114.1428942601173.JavaMail.open-xchange@ronja.mits.lan>
2015-04-13 17:06 ` grub-mkrescue problems in argp_parse Andrei Borzenkov
2015-04-13 17:16   ` Dietmar Maurer
2015-04-13 17:49     ` Andrei Borzenkov
2015-04-13 19:10       ` Thomas Schmitt
2015-04-14  7:23         ` Dietmar Maurer
2015-04-14  9:16           ` Thomas Schmitt
2015-04-14  9:58             ` Dietmar Maurer
2015-04-14 10:07             ` Dietmar Maurer
2015-04-14 10:34               ` Thomas Schmitt
2015-04-24 15:54       ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-04-24 16:31         ` Thomas Schmitt
2015-04-29 14:05           ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-04-29 16:42             ` Andrei Borzenkov
2015-04-29 16:57             ` Thomas Schmitt [this message]
2015-05-07 14:40               ` Vladimir 'φ-coder/phcoder' Serbinenko
2015-05-07 17:19                 ` Andrei Borzenkov
2015-05-07 18:41                   ` Thomas Schmitt
2015-05-07 18:19                 ` Thomas Schmitt
2015-04-24 17:14         ` Andrei Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25321568600134319256@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.