From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 6/9 v2] arm64: dts: m3ulcb: enable SDHI0
Date: Wed, 9 Nov 2016 11:06:33 +0300 [thread overview]
Message-ID: <2532ccaa-fbf5-914d-40cb-e27eabdca70f@cogentembedded.com> (raw)
In-Reply-To: <20161109074418.GC30093@verge.net.au>
Hi Simon,
On 09.11.2016 10:44, Simon Horman wrote:
> On Tue, Nov 08, 2016 at 05:14:21PM +0300, Vladimir Barinov wrote:
>> This supports SDHI0 on M3ULCB board SD card slot
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
>> Reviewed-off-by: Simon Horman <horms+renesas@verge.net.au>
> Thanks Vladimir,
>
> I have queued up the following patches:
>
> arm64: dts: h3ulcb: rename SDHI0 pins
> arm64: dts: h3ulcb: enable SDHI2
> arm64: dts: m3ulcb: enable SDHI2
> arm64: dts: m3ulcb: enable SDHI0
>
> For reference I would, however, like to make some comments regarding the
> way you have submitted these:
>
> 1. I did not provide a Reviewed-off-by tag or any other tag as far as I
> recall. So its not appropriate for you to add one when posting patches.
> I have removed it.
>
> 2. Not withstanding the above, Reviewed-off-by is an invalid tag.
> Perhaps you mean Reviewed-by.
>
> 3. When you repost patches I have a slight preference for you to repost
> them in a fresh thread. And if the patchset has more than one patch then
> with a fresh cover letter. This makes it a little easier for me
> to see what is going on. And gives a more natural place for
> me to respond to a patchset.
Thank you for these valuable comments!
I will follow them for further work.
Regards,
Vladimir
next prev parent reply other threads:[~2016-11-09 8:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-03 18:06 [PATCH 0/9] arm64: renesas: add M3ULCB board Vladimir Barinov
2016-11-03 18:06 ` [PATCH 1/9] dt: arm: shmobile: add M3ULCB board DT bindings Vladimir Barinov
2016-11-03 18:07 ` [PATCH 2/9] arm64: dts: m3ulcb: initial device tree Vladimir Barinov
2016-11-03 18:07 ` [PATCH 3/9] arm64: dts: m3ulcb: enable SCIF clk and pins Vladimir Barinov
2016-11-03 18:07 ` [PATCH 4/9] arm64: dts: m3ulcb: enable GPIO leds Vladimir Barinov
2016-11-07 12:57 ` Simon Horman
2016-11-07 12:57 ` Simon Horman
2016-11-07 13:02 ` Vladimir Barinov
2016-11-03 18:07 ` [PATCH 5/9] arm64: dts: m3ulcb: enable GPIO keys Vladimir Barinov
2016-11-03 18:07 ` Vladimir Barinov
2016-11-03 18:07 ` [PATCH 6/9] arm64: dts: m3ulcb: enable SDHI0 Vladimir Barinov
2016-11-07 13:00 ` Simon Horman
2016-11-07 13:05 ` Vladimir Barinov
2016-11-07 13:05 ` Vladimir Barinov
2016-11-03 18:08 ` [PATCH 7/9] arm64: dts: m3ulcb: enable EXTALR clk Vladimir Barinov
2016-11-03 18:08 ` Vladimir Barinov
2016-11-03 18:08 ` [PATCH 8/9] arm64: dts: m3ulcb: enable WDT Vladimir Barinov
2016-11-03 18:08 ` [PATCH 9/9] arm64: dts: m3ulcb: enable SDHI2 Vladimir Barinov
2016-11-07 13:35 ` [PATCH 0/9] arm64: renesas: add M3ULCB board Simon Horman
2016-11-07 13:35 ` Simon Horman
2016-11-08 14:14 ` [PATCH 6/9 v2] arm64: dts: m3ulcb: enable SDHI0 Vladimir Barinov
2016-11-09 7:44 ` Simon Horman
2016-11-09 7:44 ` Simon Horman
2016-11-09 8:06 ` Vladimir Barinov [this message]
2016-11-08 14:14 ` [PATCH 9/9 v2] arm64: dts: m3ulcb: enable SDHI2 Vladimir Barinov
2016-11-08 14:14 ` Vladimir Barinov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2532ccaa-fbf5-914d-40cb-e27eabdca70f@cogentembedded.com \
--to=vladimir.barinov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.