From: Thomas Monjalon <thomas@monjalon.net>
To: Shyam Kumar Shrivastav <shrivastav.shyam@gmail.com>
Cc: dev@dpdk.org, "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [PATCH v2] pipeline_firewall: Fix for port range filtering
Date: Fri, 21 Apr 2017 01:35:24 +0200 [thread overview]
Message-ID: <2536253.Wole6s4BNc@xps> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D891265277302E@IRSMSX108.ger.corp.intel.com>
> > Firewall ACL definition need to use same input index for source and
> > destination ports as these are 16 bits and would fit in one ACL
> > field of 32 bits. This is required as per librte_acl API. Without this
> > UDP/TCP source and destination ports filtering (and for that
> > matter ICMP type/code filtering) does not work.
> >
> > Signed-off-by: Shyam Kumar Shrivastav <shrivastav.shyam@gmail.com>
> > ---
>
> Reviewed-by: Jasvinder.Singh@intel.com
> Acked-by: Cristian.Dumitrescu@intel.com
>
> Thanks, Shyam, for debugging this!
Applied, thanks
prev parent reply other threads:[~2017-04-20 23:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 1:35 [PATCH v2] pipeline_firewall: Fix for port range filtering Shyam Kumar Shrivastav
2017-03-24 19:10 ` Dumitrescu, Cristian
2017-03-25 5:48 ` Shyam Shrivastav
2017-04-20 23:35 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2536253.Wole6s4BNc@xps \
--to=thomas@monjalon.net \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=shrivastav.shyam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.