From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:40797 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858AbeC2Gvy (ORCPT ); Thu, 29 Mar 2018 02:51:54 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: Laurent Pinchart , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment Date: Thu, 29 Mar 2018 09:51:55 +0300 Message-ID: <253721395.BpiYOE76Q7@avalon> In-Reply-To: <0829c7b9-e05b-fe27-b632-005074c86de3@ideasonboard.com> References: <20180226214516.11559-1-laurent.pinchart+renesas@ideasonboard.com> <0a055333-78b0-a64b-ef97-c1706b7b56b9@ideasonboard.com> <0829c7b9-e05b-fe27-b632-005074c86de3@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On Wednesday, 28 March 2018 22:04:49 EEST Kieran Bingham wrote: > On 28/03/18 13:27, Kieran Bingham wrote: > > On 26/02/18 21:45, Laurent Pinchart wrote: > >> The entities in the pipeline are all started when the LIF is setup. > >> Remove the outdated comment that state otherwise. > >> > >> Signed-off-by: Laurent Pinchart > >> > > > > I'll start with the easy ones :-) > > In fact, couldn't this patch be squashed into [PATCH 01/15] in this series ? I suppose it could, I'll do so. > > Reviewed-by: Kieran Bingham > > > >> --- > >> > >> drivers/media/platform/vsp1/vsp1_drm.c | 6 +----- > >> 1 file changed, 1 insertion(+), 5 deletions(-) > >> > >> diff --git a/drivers/media/platform/vsp1/vsp1_drm.c > >> b/drivers/media/platform/vsp1/vsp1_drm.c index > >> e31fb371eaf9..a1f2ba044092 100644 > >> --- a/drivers/media/platform/vsp1/vsp1_drm.c > >> +++ b/drivers/media/platform/vsp1/vsp1_drm.c > >> @@ -221,11 +221,7 @@ int vsp1_du_setup_lif(struct device *dev, unsigned > >> int pipe_index,>> > >> return -EPIPE; > >> > >> } > >> > >> - /* > >> - * Enable the VSP1. We don't start the entities themselves right at > >> this > >> - * point as there's no plane configured yet, so we can't start > >> - * processing buffers. > >> - */ > >> + /* Enable the VSP1. */ > >> > >> ret = vsp1_device_get(vsp1); > >> if (ret < 0) > >> > >> return ret; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment Date: Thu, 29 Mar 2018 09:51:55 +0300 Message-ID: <253721395.BpiYOE76Q7@avalon> References: <20180226214516.11559-1-laurent.pinchart+renesas@ideasonboard.com> <0a055333-78b0-a64b-ef97-c1706b7b56b9@ideasonboard.com> <0829c7b9-e05b-fe27-b632-005074c86de3@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A1766E3AD for ; Thu, 29 Mar 2018 06:51:55 +0000 (UTC) In-Reply-To: <0829c7b9-e05b-fe27-b632-005074c86de3@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gV2VkbmVzZGF5LCAyOCBNYXJjaCAyMDE4IDIyOjA0OjQ5IEVFU1QgS2ll cmFuIEJpbmdoYW0gd3JvdGU6Cj4gT24gMjgvMDMvMTggMTM6MjcsIEtpZXJhbiBCaW5naGFtIHdy b3RlOgo+ID4gT24gMjYvMDIvMTggMjE6NDUsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4g VGhlIGVudGl0aWVzIGluIHRoZSBwaXBlbGluZSBhcmUgYWxsIHN0YXJ0ZWQgd2hlbiB0aGUgTElG IGlzIHNldHVwLgo+ID4+IFJlbW92ZSB0aGUgb3V0ZGF0ZWQgY29tbWVudCB0aGF0IHN0YXRlIG90 aGVyd2lzZS4KPiA+PiAKPiA+PiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0Cj4gPj4g PGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9hcmQuY29tPgo+ID4gCj4gPiBJJ2xs IHN0YXJ0IHdpdGggdGhlIGVhc3kgb25lcyA6LSkKPiAKPiBJbiBmYWN0LCBjb3VsZG4ndCB0aGlz IHBhdGNoIGJlIHNxdWFzaGVkIGludG8gW1BBVENIIDAxLzE1XSBpbiB0aGlzIHNlcmllcyA/CgpJ IHN1cHBvc2UgaXQgY291bGQsIEknbGwgZG8gc28uCgo+ID4gUmV2aWV3ZWQtYnk6IEtpZXJhbiBC aW5naGFtIDxraWVyYW4uYmluZ2hhbStyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gPiAKPiA+ PiAtLS0KPiA+PiAKPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMg fCA2ICstLS0tLQo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDUgZGVsZXRp b25zKC0pCj4gPj4gCj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNw MS92c3AxX2RybS5jCj4gPj4gYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9kcm0u YyBpbmRleAo+ID4+IGUzMWZiMzcxZWFmOS4uYTFmMmJhMDQ0MDkyIDEwMDY0NAo+ID4+IC0tLSBh L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jCj4gPj4gKysrIGIvZHJpdmVy cy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZHJtLmMKPiA+PiBAQCAtMjIxLDExICsyMjEsNyBA QCBpbnQgdnNwMV9kdV9zZXR1cF9saWYoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZAo+ID4+ IGludCBwaXBlX2luZGV4LD4+IAo+ID4+ICAJCXJldHVybiAtRVBJUEU7Cj4gPj4gIAkKPiA+PiAg CX0KPiA+PiAKPiA+PiAtCS8qCj4gPj4gLQkgKiBFbmFibGUgdGhlIFZTUDEuIFdlIGRvbid0IHN0 YXJ0IHRoZSBlbnRpdGllcyB0aGVtc2VsdmVzIHJpZ2h0IGF0Cj4gPj4gdGhpcwo+ID4+IC0JICog cG9pbnQgYXMgdGhlcmUncyBubyBwbGFuZSBjb25maWd1cmVkIHlldCwgc28gd2UgY2FuJ3Qgc3Rh cnQKPiA+PiAtCSAqIHByb2Nlc3NpbmcgYnVmZmVycy4KPiA+PiAtCSAqLwo+ID4+ICsJLyogRW5h YmxlIHRoZSBWU1AxLiAqLwo+ID4+IAo+ID4+ICAJcmV0ID0gdnNwMV9kZXZpY2VfZ2V0KHZzcDEp Owo+ID4+ICAJaWYgKHJldCA8IDApCj4gPj4gIAkKPiA+PiAgCQlyZXR1cm4gcmV0OwoKCi0tIApS ZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVsCg==