From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Magnus Damm Date: Tue, 19 Jun 2018 08:56:37 +0300 Message-ID: <2538185.ecTHDDYmKt@avalon> In-Reply-To: References: <1529055605-29942-1-git-send-email-ulrich.hecht+renesas@gmail.com> <10848514.jCgBdBqkyy@avalon> MIME-Version: 1.0 Cc: takuya.sakata.wz@bp.renesas.com, u-boot@lists.denx.de, Linux-Renesas , Geert Uytterhoeven , Ulrich Hecht Subject: Re: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" List-ID: SGkgTWFnbnVzLAoKT24gVHVlc2RheSwgMTkgSnVuZSAyMDE4IDA4OjQzOjMxIEVFU1QgTWFnbnVz IERhbW0gd3JvdGU6Cj4gT24gVHVlLCBKdW4gMTksIDIwMTggYXQgMTE6MTUgQU0sIExhdXJlbnQg UGluY2hhcnQgd3JvdGU6Cj4gPiBPbiBTdW5kYXksIDE3IEp1bmUgMjAxOCAwMzowODowMiBFRVNU IE1hcmVrIFZhc3V0IHdyb3RlOgo+ID4+IE9uIDA2LzE2LzIwMTggMDU6NDQgUE0sIExhdXJlbnQg UGluY2hhcnQgd3JvdGU6Cj4gPj4+IE9uIFNhdHVyZGF5LCAxNiBKdW5lIDIwMTggMDI6NDI6MzAg RUVTVCBNYXJlayBWYXN1dCB3cm90ZToKPiA+Pj4+IE9uIDA2LzE2LzIwMTggMDE6MjEgQU0sIExh dXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+Pj4gT24gRnJpZGF5LCAxNSBKdW5lIDIwMTggMTU6 MDA6MzEgRUVTVCBNYXJlayBWYXN1dCB3cm90ZToKPiA+Pj4+Pj4gT24gMDYvMTUvMjAxOCAwMTo0 MyBQTSwgTWFyZWsgVmFzdXQgd3JvdGU6Cgpbc25pcF0KCj4gPj4+Pj4+PiBZZXQsIEkgaGF2ZSB0 byB3b25kZXIgaWYgQVRGIGRvZXNuJ3QgYWxyZWFkeSBjb250YWluIHNvbWUgc29ydCBvZgo+ID4+ Pj4+Pj4gc3RhbmRhcmQgU01DIGNhbGwgdG8gZ2V0IG1lbW9yeSB0b3BvbG9neS4gSXQgc3VycHJp c2VzIG1lIHRoYXQgaXQKPiA+Pj4+Pj4+IHdvdWxkbid0Lgo+ID4+Pj4+PiAKPiA+Pj4+Pj4gSW4g ZmFjdCwgTGF1cmVudCAoQ0NlZCkgd2FzIHNvbHZpbmcgc29tZSBzaW1pbGFyIGlzc3VlIHdpdGgg bG9zc3kKPiA+Pj4+Pj4gZGVjb21wIGFuZCBJIHRoaW5rIHRoaXMgaW52b2x2ZWQgc29tZSBwYXNz aW5nIG9mIG1lbW9yeSBsYXlvdXQKPiA+Pj4+Pj4gaW5mb3JtYXRpb24gZnJvbSBBVEYgdG8gVS1C b290IHRvbywgb3IgYW0gSSBtaXN0YWtlbiA/Cj4gPj4+Pj4gCj4gPj4+Pj4gVGhhdCdzIGNvcnJl Y3QsIEFURiBzdG9yZXMgaW5mb3JtYXRpb24gYWJvdXQgdGhlIG1lbW9yeSBsYXlvdXQgYXQgYQo+ ID4+Pj4+IGZpeGVkIGFkZHJlc3MgaW4gc3lzdGVtIG1lbW9yeSwgYW5kIFUtQm9vdCBjYW4gcmVh ZCBpdC4KPiA+Pj4+IAo+ID4+Pj4gV2VsbCwgdGhhdCBzb3VuZHMgZ29vZCAhIE1heWJlIHdlIGNh biBhdm9pZCBhZGRpbmcgU01DIGNhbGwgYWx0b2dldGhlcgo+ID4+Pj4gdGhlbj8gOikKPiA+Pj4g Cj4gPj4+IEknZCBwcmVmZXIgdGhhdCwgeWVzLgo+ID4+PiAKPiA+Pj4gTGV0J3Mgbm90IGR1cGxp Y2F0ZSB0aGUgbWVjaGFuaXNtIHVzZWQgdG8gcGFzcyBGQ05MIGluZm9ybWF0aW9uIGZyb20KPiA+ Pj4gQVRGIHRvIFUtIEJvb3QsIGJ1dCBpbnN0ZWFkIGNyZWF0ZSBhIGRhdGEgdGFibGUgZm9ybWF0 IHRoYXQgY2FuIHN0b3JlCj4gPj4+IGFsbCB0aGUgaW5mb3JtYXRpb24gd2UgbmVlZCwgaW4gYW4g ZWFzaWx5IGV4dGVuc2libGUgd2F5Lgo+ID4+PiAKPiA+Pj4gVG8gc2VlIGhvdyB0aGUgbWVjaGFu aXNtIGlzIGltcGxlbWVudGVkIGZvciBGQ05MLCBzZWFyY2ggZm9yIDQ3RkQ3MDAwCj4gPj4+IGlu IHRoZSBSZW5lc2FzIEFURiBzb3VyY2VzCj4gPj4+IChnaXQ6Ly9naXRodWIuY29tL3JlbmVzYXMt cmNhci9hcm0tdHJ1c3RlZC1maXJtd2FyZS5naXQpLgo+ID4+IAo+ID4+IEZvciBldmVyeW9uZSBp bnZvbHZlZCwgY2FuIHlvdSBleHBsYWluIHdoYXQgRkNOTCBpcyA/IDstKQo+ID4gCj4gPiBGQ05M IGlzIEZyYW1lIENvbXByZXNzaW9uIE5lYXIgTG9zc2xlc3MuIEl0J3MgYSB3YXkgdG8gcmVkdWNl IG1lbW9yeQo+ID4gYmFuZHdpZHRoIGJ5IHRyYW5zcGFyZW50IGNvbXByZXNzaW9uIGFuZCBkZWNv bXByZXNzaW9uIG9mIHZpZGVvIGZyYW1lcy4KPiA+IENvbXByZXNzaW9uIGlzIGhhbmRsZWQgYnkg YW4gSVAgY29yZSBjYWxsZWQgRkNQLCBhbmQgZGVjb21wcmVzc2lvbiBpcwo+ID4gaGFuZGxlZCBi eSB0aGUgRFJBTSBjb250cm9sbGVyLiBBVEYgcHJvZ3JhbXMgdGhlIERSQU0gY29udHJvbGxlciB3 aXRoCj4gPiByYW5nZXMgb2YgbWVtb3J5IGFkZHJlc3NlcyB0aGF0IHdpbGwgYmUgZHluYW1pY2Fs bHkgZGVjb21wcmVzc2VkLiBUaGUKPiA+IHJlZ2lzdGVycyBjb250YWluaW5nIHRob3NlIHJhbmdl cyBhcmUgYWNjZXNzaWJsZSBpbiBzZWN1cmUgbW9kZSBvbmx5LCBzbwo+ID4gbmVpdGhlciBVLUJv b3Qgbm9yIExpbnV4IGNhbiByZWFkIHRoZW0uIFRoYXQncyB3aHkgQVRGIGhhcyB0byBwYXNzIHRo ZQo+ID4gaW5mb3JtYXRpb24gdG8gVS1Cb290LCBpbiBvcmRlciB0byBhZGQgdGhlIHJhbmdlcyBh cyByZXNlcnZlZCBtZW1vcnkgaW4KPiA+IERULgo+IAo+IFRoYW5rcyBmb3IgdGhlIGNsYXJpZmlj YXRpb24uIEkgd29uZGVyIGhvdyBtdWNoIG9mIHRoZSBzcGxpdCBiZXR3ZWVuCj4gQVRGIGFuZCAi dGhlIHJlc3QiIGNhbiBiZSBhZGp1c3RlZC4gSXQgc21lbGxzIGxpa2UganVzdCBhIHNvZnR3YXJl Cj4gYXJjaGl0ZWN0dXJlIHBvbGljeSwgbXkgZ3V0IGZlZWxpbmcgaXMgdGhhdCBMSUZFQyBjYW4g YmUgcHJvZ3JhbW1lZCB0bwo+IGFkanVzdCB0aGUgYXNzaWdubWVudCBiZXR3ZWVuIHNlY3VyZSBz aWRlIGFuZCAicmVndWxhciIuIEF0IGxlYXN0IGl0Cj4gY2FuIGRvIHNvIGZvciBhIHdpZGUgcmFu Z2Ugb2YgYnVzIG1hc3RlcnMuIEhvd2V2ZXIgaWYgdGhpcyBpcyB0aGUgY2FzZQo+IGZvciBGQ05M IHJlbWFpbnMgdG8gYmUgc2Vlbi4KPiAKPiBBcyBhIHNpZGUgbm90ZSwgZm9yIEZDTkwgSSBwZXJz b25hbGx5IHdvdWxkIHByZWZlciBhIG1vcmUgZHluYW1pYwo+IHNvbHV0aW9uIHdoZXJlIHdlIG1h bmFnZSBwaHlzaWNhbGx5IGNvbnRpZ3VvdXMgcmFuZ2VzIGZyb20gTGludXgKPiBkdXJpbmcgcnVu IHRpbWUgaW5zdGVhZCBvZiByZWx5aW5nIG9mIHN0YXRpY2FsbHkgc2V0dXAgd2luZG93cy4KClNv IHdvdWxkIEksIGJ1dCB3aGV0aGVyIHdlIGNhbiBiZSBhbGxvd2VkIHRvIGFjY2VzcyB0aG9zZSBy ZWdpc3RlcnMgZnJvbSBMaW51eCAKaXNuJ3QgbXkgZGVjaXNpb24gOi0vCgo+ID4+IEFueSB5ZXMs IEkgYWdyZWUgdGhpcyBzb3VuZHMgZ29vZC4gSSBoYWQgYSBkaXNjdXNzaW9uIG9uIHRoZSBVLUJv b3QgSVJDCj4gPj4gYWJvdXQgcGFzc2luZyB0aGUgbWVtb3J5IGNvbmZpZ3VyYXRpb24gYXJvdW5k IGFuZCB0aGUgcmVzdWx0IGlzCj4gPj4gYmFzaWNhbGx5IHRoZSBzYW1lIC0tIHBhc3MgYSB0YWJs ZSBmcm9tIEFURiB0byBVLUJvb3QuIElmIHRoZXJlJ3MKPiA+PiBhbHJlYWR5IHNvbWV0aGluZywg Z3JlYXQuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVS1Cb290IG1haWxpbmcgbGlzdApVLUJv b3RAbGlzdHMuZGVueC5kZQpodHRwczovL2xpc3RzLmRlbnguZGUvbGlzdGluZm8vdS1ib290Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 19 Jun 2018 08:56:37 +0300 Subject: [U-Boot] [RFC] ARM: rmobile: create DT memory nodes for R8A7795 3.0 and newer In-Reply-To: References: <1529055605-29942-1-git-send-email-ulrich.hecht+renesas@gmail.com> <10848514.jCgBdBqkyy@avalon> Message-ID: <2538185.ecTHDDYmKt@avalon> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Magnus, On Tuesday, 19 June 2018 08:43:31 EEST Magnus Damm wrote: > On Tue, Jun 19, 2018 at 11:15 AM, Laurent Pinchart wrote: > > On Sunday, 17 June 2018 03:08:02 EEST Marek Vasut wrote: > >> On 06/16/2018 05:44 PM, Laurent Pinchart wrote: > >>> On Saturday, 16 June 2018 02:42:30 EEST Marek Vasut wrote: > >>>> On 06/16/2018 01:21 AM, Laurent Pinchart wrote: > >>>>> On Friday, 15 June 2018 15:00:31 EEST Marek Vasut wrote: > >>>>>> On 06/15/2018 01:43 PM, Marek Vasut wrote: [snip] > >>>>>>> Yet, I have to wonder if ATF doesn't already contain some sort of > >>>>>>> standard SMC call to get memory topology. It surprises me that it > >>>>>>> wouldn't. > >>>>>> > >>>>>> In fact, Laurent (CCed) was solving some similar issue with lossy > >>>>>> decomp and I think this involved some passing of memory layout > >>>>>> information from ATF to U-Boot too, or am I mistaken ? > >>>>> > >>>>> That's correct, ATF stores information about the memory layout at a > >>>>> fixed address in system memory, and U-Boot can read it. > >>>> > >>>> Well, that sounds good ! Maybe we can avoid adding SMC call altogether > >>>> then? :) > >>> > >>> I'd prefer that, yes. > >>> > >>> Let's not duplicate the mechanism used to pass FCNL information from > >>> ATF to U- Boot, but instead create a data table format that can store > >>> all the information we need, in an easily extensible way. > >>> > >>> To see how the mechanism is implemented for FCNL, search for 47FD7000 > >>> in the Renesas ATF sources > >>> (git://github.com/renesas-rcar/arm-trusted-firmware.git). > >> > >> For everyone involved, can you explain what FCNL is ? ;-) > > > > FCNL is Frame Compression Near Lossless. It's a way to reduce memory > > bandwidth by transparent compression and decompression of video frames. > > Compression is handled by an IP core called FCP, and decompression is > > handled by the DRAM controller. ATF programs the DRAM controller with > > ranges of memory addresses that will be dynamically decompressed. The > > registers containing those ranges are accessible in secure mode only, so > > neither U-Boot nor Linux can read them. That's why ATF has to pass the > > information to U-Boot, in order to add the ranges as reserved memory in > > DT. > > Thanks for the clarification. I wonder how much of the split between > ATF and "the rest" can be adjusted. It smells like just a software > architecture policy, my gut feeling is that LIFEC can be programmed to > adjust the assignment between secure side and "regular". At least it > can do so for a wide range of bus masters. However if this is the case > for FCNL remains to be seen. > > As a side note, for FCNL I personally would prefer a more dynamic > solution where we manage physically contiguous ranges from Linux > during run time instead of relying of statically setup windows. So would I, but whether we can be allowed to access those registers from Linux isn't my decision :-/ > >> Any yes, I agree this sounds good. I had a discussion on the U-Boot IRC > >> about passing the memory configuration around and the result is > >> basically the same -- pass a table from ATF to U-Boot. If there's > >> already something, great. -- Regards, Laurent Pinchart