From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] centralize some nls helpers
Date: Wed, 1 Sep 2004 16:15:38 +0200 [thread overview]
Message-ID: <253871B35E8@vcnet.vc.cvut.cz> (raw)
On 1 Sep 04 at 11:50, Christoph Hellwig wrote:
> This patch adds common nls_tolower, nls_toupper and nls_strnicmp helpers
> to nls.h and uses them in various filesystems instead of local
> duplicates.
>
> The situation for ncpfs isn't as nice as it allows to compile without
> nls support even if the kernel has CONFIG_NLS set, so we need wrappers
> there.
I have no problem with setting CONFIG_NCPFS_NLS == CONFIG_NLS. As all
ncpfs features except NCPFS_SMALLDOS can be set at mount time,
there is no reason for not hardwiring all CONFIG_NCPFS_* options
(except SMALLDOS) to 'y', except that it will consume some additional
memory (and I doubt that embedded people use ncpfs). Only question
is whether retain CONFIG_NCP_FS selecting NLS (currently CONFIG_NCPFS_NLS
selects NLS), or whether CONFIG_NCP_FS should depend on NLS
(I've thought that CONFIG_NCPFS_NLS depends on NLS and only just now
I found that CONFIG_NCPFS_NLS selects NLS now...).
Petr Vandrovec
vandrove@vc.cvut.cz
next reply other threads:[~2004-09-01 14:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-01 14:15 Petr Vandrovec [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-09-01 9:50 [PATCH] centralize some nls helpers Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253871B35E8@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.