From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56442C28CC0 for ; Thu, 30 May 2019 01:39:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28774243EA for ; Thu, 30 May 2019 01:39:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n3w0gXEh"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dA7r1dbR"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EWoJsHuy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28774243EA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=yFQ8vbST2gwAjAd6rE6gg7wjKdGWSGqhRTx30Y0WXdE=; b=n3w0gXEhLWMZjbFzf8dJi5aVq pvA3mDBJ8cFuvs+1FA5P18uwWwPe7rdVMHOPgelKcnYEGGprhgZfT2AfpRkKtsXXnmyWWF0iWQtWB 5b1SvKcNvQKI67SzeENyG+BMUoaSZ7QNRBiuYH1cbO7i+bBlsuvRIncGaMi3T1ocXNINtxvDZxYmO 3olLzXznKCAriD11BbxqgI7pK+ObeSRRWtNaGdIJOolcrY8FMBzuX6IQfnnCFGceiiID3azVChQi1 XxiuloW/PYMXbOskYcX7+lqka/Y08rkMgA76U0iTvGA5XhvaLrh/HDMsEqxi9qNoFYgWZX+lyzeL9 Gv0846Exw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWA1t-0007to-7N; Thu, 30 May 2019 01:38:53 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hWA1p-0007tK-7P for linux-arm-kernel@lists.infradead.org; Thu, 30 May 2019 01:38:50 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 3233260A05; Thu, 30 May 2019 01:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559180328; bh=9juO5+fk3lH9CoK/+q+jiu9YWLxmL6m/v8Ar/h/6rRg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dA7r1dbR/WcRSYiIEupp6qAHJNrsO95trsbyZTmmzxUsb8Zo0gbeFDSUij5OG2jcX +1C4X2XuvcOhWEHoyDQ4e5R6UdBMAUBAx4IHqLKW/znZiORjtMFrdNaH9YygULN8CS DL1HkCgLNBzw6azTg5cbNpIiWhXmcOYGe6yti4P0= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 2DC1B6063A; Thu, 30 May 2019 01:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559180327; bh=9juO5+fk3lH9CoK/+q+jiu9YWLxmL6m/v8Ar/h/6rRg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EWoJsHuymdmKG5M3HXyjC7hFxN7Rb1p2YIhzDx8Mr+c7U2YS4wjOQ3lyeEui+LkV7 CAZllBM/koJNZi5ewZ0/sW4PUD2WUSJrtMpLq2XHEw9yJ9XPipzmgHX4+u9xtSvkcZ udBChGzm9WkNhKVmIfvPoXviQQge/MEFO/cEmUj4= MIME-Version: 1.0 Date: Thu, 30 May 2019 09:38:47 +0800 From: tengfeif@codeaurora.org To: Anshuman Khandual Subject: Re: [PATCH] arm64: break while loop if task had been rescheduled In-Reply-To: References: <1558430404-4840-1-git-send-email-tengfeif@codeaurora.org> Message-ID: <253affe7493cb9689e224d74aa182765@codeaurora.org> X-Sender: tengfeif@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190529_183849_299899_03424951 X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, tengfei@codeaurora.org, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, andreyknvl@google.com, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAxOS0wNS0yMiAxNzowNCwgQW5zaHVtYW4gS2hhbmR1YWwgd3JvdGU6Cj4gT24gMDUvMjEv MjAxOSAwMjo1MCBQTSwgVGVuZ2ZlaSBGYW4gd3JvdGU6Cj4+IFdoaWxlIHByaW50aW5nIGEgdGFz aydzIGJhY2t0cmFjZSBhbmQgdGhpcyB0YXNrIGlzbid0Cj4+IGN1cnJlbnQgdGFzaywgaXQgaXMg cG9zc2libGUgdGhhdCB0YXNrJ3MgZnAgYW5kIGZwKzgKPj4gaGF2ZSB0aGUgc2FtZSB2YWx1ZSwg c28gY2Fubm90IGJyZWFrIHRoZSB3aGlsZSBsb29wLgo+PiBUaGlzIGNhbiBicmVhayB3aGlsZSBs b29wIGlmIHRoaXMgdGFzayBoYWQgYmVlbgo+PiByZXNjaGVkdWxlZCBkdXJpbmcgcHJpbnQgdGhp cyB0YXNrJ3MgYmFja3RyYWNlLgo+IAo+IFRoaXMgaXMgdmVyeSBjb25mdXNpbmcuIElJVUMgaXQg c3VnZ2VzdHMgdGhhdCB3aGlsZSBwcmludGluZwo+IHRoZSBiYWNrdHJhY2UgZm9yIG5vbi1jdXJy ZW50IHRhc2tzIHRoZSBkby93aGlsZSBsb29wIGRvZXMgbm90Cj4gZXhpdCBiZWNhdXNlIGZwIGFu ZCBmcCs4IG1pZ2h0IGhhdmUgdGhlIHNhbWUgdmFsdWUgPyBXaGVuIHdvdWxkCj4gdGhpcyBoYXBw ZW4gPyBFdmVuIGluIHRoYXQgY2FzZSB0aGUgY29tbWl0IG1lc3NhZ2UgaGVyZSBkb2VzIG5vdAo+ IHByb3Blcmx5IG1hdGNoIHRoZSBjaGFuZ2UgaW4gdGhpcyBwYXRjaC4KCkluIG91ciBpc3N1ZSwg d2UgZ290IGZwPXBjPTB4RkZGRkZGODAyNUExM0JBMCwgc28gY2Fubm90IGV4aXQgd2hpbGUKbG9v cCBpbiBkdW1wX2Jhc2t0cmFjZSgpLgpBZnRlciBhbmFseXplIG91ciBpc3N1ZSdzIGR1bXAsIHdl IGZvdW5kIG9uZSB0YXNrKHN1Y2ggYXM6IHRhc2sgQSkKaXMgZXhpdGluZyB2aWEgaW52b2tlIGRv X2V4aXQoKSBkdXJpbmcgYW5vdGhlciB0YXNrIGlzIHNob3dpbmcgdGFzawpBJ3MgZHVtcHRhc2su IEluIGtlcm5lbCBjb2RlLCBkb19leGl0KCkgYW5kIGV4aXRfbm90aWZ5IGFyZSBkZWZpbmVkCmFz IGZvbGxvd3M6CnZvaWQgbm9yZXR1cm4gZG9fZXhpdChsb25nIGNvZGUpCnsKICAgICAgLi4uLi4u CiAgICAgIGV4aXRfbm90aWZ5KHRzaywgZ3JvdXBfZGVhZCk7CiAgICAgIC4uLi4uLgp9CnN0YXRp YyB2b2lkIGV4aXRfbm90aWZ5KHN0cnVjdCB0YXNrX3N0cnVjdCAqdHNrLCBpbnQgZ3JvdXBfZGVh ZCkKewogICAgICAuLi4uLi4KfQpCZWNhdXNlIG9mIGV4aXRfbm90aWZ5KCkgaXMgYSBzdGF0aWMg ZnVuY3Rpb24sIHNvIGl0IGlzIGlubGluZWQgdG8KZG9fZXhpdCgpIHdoZW4gY29tcGlsZSBrZXJu ZWwsIHNvIHdlIGNhbiBnZXQgcGFydGlhbCBhc3NlbWJseSBjb2RlCm9mIGRvX2V4aXQoKSBhcyBm b2xsb3dzOgrigKbigKYKewogICAgICAgICBib29sIGF1dG9yZWFwOwogICAgICAgICBzdHJ1Y3Qg dGFza19zdHJ1Y3QgKnAsICpuOwogICAgICAgICBMSVNUX0hFQUQoZGVhZCk7CgogICAgICAgICB3 cml0ZV9sb2NrX2lycSgmdGFza2xpc3RfbG9jayk7CiAgICAgIGMxMDogICAgICAgOTAwMDAwMDAg ICAgICAgIGFkcnAgICAgeDAsIDAgPHRhc2tsaXN0X2xvY2s+CiAgICAgIGMxNDogICAgICAgOTEw MDAzZTggICAgICAgIG1vdiAgICAgeDgsIHNwCiAgICAgIGMxODogICAgICAgOTEwMDAwMDAgICAg ICAgIGFkZCAgICAgeDAsIHgwLCAjMHgwCiovCnN0YXRpYyB2b2lkIGV4aXRfbm90aWZ5KHN0cnVj dCB0YXNrX3N0cnVjdCAqdHNrLCBpbnQgZ3JvdXBfZGVhZCkKewogICAgICAgICBib29sIGF1dG9y ZWFwOwogICAgICAgICBzdHJ1Y3QgdGFza19zdHJ1Y3QgKnAsICpuOwogICAgICAgICBMSVNUX0hF QUQoZGVhZCk7CiAgICAgIGMxYzogICAgICAgYTkwMDIzZTggICAgICAgIHN0cCAgICAgeDgsIHg4 LCBbc3BdCgogICAgICAgICB3cml0ZV9sb2NrX2lycSgmdGFza2xpc3RfbG9jayk7CiAgICAgIGMy MDogICAgICAgOTQwMDAwMDAgICAgICAgIGJsICAgICAgMCA8X3Jhd193cml0ZV9sb2NrX2lycT4K ICAgICAgYzI0OiAgICAgICBmOTQzNTI2OCAgICAgICAgbGRyICAgICB4OCwgW3gxOSwjMTY5Nl0K 4oCm4oCmCiBGcm9tIHRoZSBjb2RlICJjMTQ6IiBhbmQgImMxYzoiLCB3ZSB3aWxsIGZpbmQgc3An cyBhZGRyIHZhbHVlIGlzIHN0b3JlZAppbiBzcCBhbmQgc3ArOCwgc28gc3AncyB2YXVsZSBlcXVh bCAoc3ArOCkncyB2YWx1ZS4KSW4gb3VyIGlzc3VlLCB0aGVyZSBpcyBhIGNoYW5jZSBvZiBmcCBw b2ludCBzcCwgc28gdGhlcmUgd2lsbCBiZSAKZnA9cGM9ZnAncwphZGRyIHZhbHVlLHNvIGNvZGUg Y2Fubm90IGJyZWFrIGZyb20gd2hpbGUgbG9vcCBpbiBkdW1wX2JhY2t0cmFjZSgpLgoKPiAKPiBU aGlzIHBhdGNoIHRyaWVzIHRvIHN0b3AgcHJpbnRpbmcgdGhlIHN0YWNrIGZvciBub24tY3VycmVu dCB0YXNrcwo+IGlmIHRoZWlyIHN0YXRlIGNoYW5nZSB3aGlsZSB0aGVyZSBpcyBvbmUgZHVtcF9i YWNrdHJhY2UoKSB0cnlpbmcKPiB0byBwcmludCBiYWNrIHRyYWNlLiBEb250IHdlIGhhdmUgYW55 IGxvY2sgcHJldmVudGluZyBhIHRhc2sgaW4KPiB0aGlzIHNpdHVhdGlvbiAod2hpbGUgZHVtcGlu ZyBpdCdzIGJhY2t0cmFjZSkgZnJvbSBydW5uaW5nIGFnYWluCj4gb3IgY2hhbmdpbmcgc3RhdGUu CgpJIGhhdmVuJ3QgZm91bmQgYW55IGxvY2sgcHJldmVudGluZyBhIHRhc2sgaW4gdGhpcyBzaXR1 YXRpb24sIGFuZCBJIAp0aGluayB3ZSBzaG91bGRuJ3QKcHJldmVudCB0YXNrIHJ1bm5pbmcgaWYg dGhpcyB0YXNrIGlzIHNjaGVkdWxlZC4KPiAKPj4gCj4+IFNpZ25lZC1vZmYtYnk6IFRlbmdmZWkg RmFuIDx0ZW5nZmVpZkBjb2RlYXVyb3JhLm9yZz4KPj4gLS0tCj4+ICBhcmNoL2FybTY0L2tlcm5l bC90cmFwcy5jIHwgMjMgKysrKysrKysrKysrKysrKysrKysrKysKPj4gIDEgZmlsZSBjaGFuZ2Vk LCAyMyBpbnNlcnRpb25zKCspCj4+IAo+PiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9rZXJuZWwv dHJhcHMuYyBiL2FyY2gvYXJtNjQva2VybmVsL3RyYXBzLmMKPj4gaW5kZXggMjk3NTU5OC4uOWRm NmUwMiAxMDA2NDQKPj4gLS0tIGEvYXJjaC9hcm02NC9rZXJuZWwvdHJhcHMuYwo+PiArKysgYi9h cmNoL2FybTY0L2tlcm5lbC90cmFwcy5jCj4+IEBAIC0xMDMsNiArMTAzLDkgQEAgdm9pZCBkdW1w X2JhY2t0cmFjZShzdHJ1Y3QgcHRfcmVncyAqcmVncywgc3RydWN0IAo+PiB0YXNrX3N0cnVjdCAq dHNrKQo+PiAgewo+PiAgCXN0cnVjdCBzdGFja2ZyYW1lIGZyYW1lOwo+PiAgCWludCBza2lwID0g MDsKPj4gKwlsb25nIGN1cl9zdGF0ZSA9IDA7Cj4+ICsJdW5zaWduZWQgbG9uZyBjdXJfc3AgPSAw Owo+PiArCXVuc2lnbmVkIGxvbmcgY3VyX2ZwID0gMDsKPj4gCj4+ICAJcHJfZGVidWcoIiVzKHJl Z3MgPSAlcCB0c2sgPSAlcClcbiIsIF9fZnVuY19fLCByZWdzLCB0c2spOwo+PiAKPj4gQEAgLTEy Nyw2ICsxMzAsOSBAQCB2b2lkIGR1bXBfYmFja3RyYWNlKHN0cnVjdCBwdF9yZWdzICpyZWdzLCBz dHJ1Y3QgCj4+IHRhc2tfc3RydWN0ICp0c2spCj4+ICAJCSAqLwo+PiAgCQlmcmFtZS5mcCA9IHRo cmVhZF9zYXZlZF9mcCh0c2spOwo+PiAgCQlmcmFtZS5wYyA9IHRocmVhZF9zYXZlZF9wYyh0c2sp Owo+PiArCQljdXJfc3RhdGUgPSB0c2stPnN0YXRlOwo+PiArCQljdXJfc3AgPSB0aHJlYWRfc2F2 ZWRfc3AodHNrKTsKPj4gKwkJY3VyX2ZwID0gZnJhbWUuZnA7Cj4gCj4gU2hvdWxkICdzYXZlZF9z dGF0ZXxzcHxmcCcgaW5zdGVhZCBhcyBpdHMgYXBwbGljYWJsZSB0byBub24tY3VycmVudAo+IHRh c2tzIG9ubHkuCgonc2F2ZWRfc3RhdGV8c3B8ZnAnIG9ubHkgYXBwbGllcyB0byBub24tY3VycmVu dCB0YXNrcy4KCj4gCj4+ICAJfQo+PiAgI2lmZGVmIENPTkZJR19GVU5DVElPTl9HUkFQSF9UUkFD RVIKPj4gIAlmcmFtZS5ncmFwaCA9IDA7Cj4+IEBAIC0xMzQsNiArMTQwLDIzIEBAIHZvaWQgZHVt cF9iYWNrdHJhY2Uoc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIHN0cnVjdCAKPj4gdGFza19zdHJ1Y3Qg KnRzaykKPj4gCj4+ICAJcHJpbnRrKCJDYWxsIHRyYWNlOlxuIik7Cj4+ICAJZG8gewo+PiArCQlp ZiAodHNrICE9IGN1cnJlbnQgJiYgKGN1cl9zdGF0ZSAhPSB0c2stPnN0YXRlCj4+ICsJCQkvKgo+ PiArCQkJICogV2Ugd291bGQgbm90IGJlIHByaW50aW5nIGJhY2t0cmFjZSBmb3IgdGhlIHRhc2sK Pj4gKwkJCSAqIHRoYXQgaGFzIGNoYW5nZWQgc3RhdGUgZnJvbSAic2F2ZWQiIHN0YXRlIHRvIG90 aGVyCj4+ICsJCQkgKiBzdGF0ZSBiZWZvcmUgaGl0dGluZyB0aGUgZG8td2hpbGUgbG9vcCBidXQg YWZ0ZXIKPj4gKwkJCSAqIHNhdmluZyB0aGUgY3VycmVudCBzdGF0ZS4gSWYgdGFzaydzIGN1cnJl bnQgc3RhdGUKPiAKPiBUaGlzIGRvZXMgbm90IGNoZWNrIGFueSBleHBsaWNpdCB0YXNrIHN0YXRl cyBsaWtlICd1bi1pbnRlcnJ1cHRpYmxlJyBvcgo+ICdydW5uaW5nJyBidXQgaW5zdGVhZCB0cmFj a3MgY2hhbmdlIGZyb20gYW55IHByZXZpb3VzbHkgJ3NhdmVkJyBzdGF0ZS4KCmhhdmUgdXBkYXRl ZCBjb21tZW50cy4KPiAKPiAKPj4gKwkJCSAqIG5vdCBlcXVhbCB0aGUgInNhdmVkIiBzdGF0ZSwg dGhlbiB3ZSBtYXkgcHJpbnQKPj4gKwkJCSAqIHdyb25nIGNhbGwgdHJhY2Ugb3IgZW5kIHVwIGlu IGluZmluaXRlIHdoaWxlIGxvb3AKPj4gKwkJCSAqIGlmICooZnApIGFuZCAqKGZwKzgpIGFyZSBz YW1lLiBXaGlsZSB0aGUgc2l0dWF0aW9uCj4gCj4gVGhlbiBkdW1wX2JhY2t0cmFjZSgpIG11c3Qg ZGV0ZWN0IGl0LCBzaG91bGQgbm90IHNhdmUgaXQgYW5kIGp1c3QgCj4gYWJvcnQuCgpoYXZlIHVw ZGF0ZCBjb21tZW50ZXMuCj4gCj4gCj4+ICsJCQkgKiBzaG91bGQgYmUgc3RvcGVkIG9uY2Ugd2Ug Zm91bmQgdGhlIHRhc2sncyBzdGF0ZQogICAgKwkJCSAqIGlzIGNoYW5nZWQsIHNvIHdlIGRldGVj dCB0aGUgdGFzaydzIGN1cnJlbnQgc3RhdGUsCiAgICArCQkJICogc3AgYW5kIGZwIGluIGVhY2gg d2hpbGUuCj4gCj4gVGhhdHMgbm90IGEgcmVsaWFibGUgc29sdXRpb24uIEFGSUNTIHdlIHNob3Vs ZCBub3QgcHJvY2VlZCBmdXJ0aGVyIGlmCj4gdGhlcmUgaXMgYSBjaGFuY2Ugb2YgYW4gd3Jvbmcg dHJhY2Ugb3IgYW4gaW5maW5pdGUgbG9vcC4gSG9waW5nIHRoYXQKPiB0aGUgcHJpbnRpbmcgd2ls bCBzdG9wIHdoZW4gdGFzayBnZXRzIHNjaGVkdWxlZCBvdXQgZG9lcyBub3Qgc2VlbSAKPiByaWdo dC4KCkluIHRoaXMgcGF0Y2gsIGl0IHdpbGwgYnJlYWsgd2hpbGUgbG9vcCBhbmQgc3RvcCB0byBw cmludCBiYWNrdHJhY2UgaWYgCndlCmZpbmQgdGhlIHRhc2sncyBzdGF0ZSBjaGFuZ2Ugb3IgdGhl cmUgaXMgYSBjaGFuY2Ugb2YgYW4gaW5maW5pdGUgbG9vcC4KPiAKPj4gKwkJCSAqLwo+PiArCQkJ fHwgY3VyX3NwICE9IHRocmVhZF9zYXZlZF9zcCh0c2spCj4+ICsJCQl8fCBjdXJfZnAgIT0gdGhy ZWFkX3NhdmVkX2ZwKHRzaykpKSB7Cj4gCj4gV2h5IGRvZXMgYW55IG9mIHRoZXNlIHRocmVlIG1p c21hdGNoZXMgZGV0ZWN0IHRoZSBwcm9ibGVtYXRpYyAKPiB0cmFuc2l0aW9uCj4gbm90IGp1c3Qg dGhlIHN0YXRlID8KCjEuIHdlIGNhbiB1c2UgImN1cl9zdGF0ZSAhPSB0c2stPnN0YXRlIiBwcmV2 ZW50IHByaW50aW5nIGJhY2t0cmFjZSBpZiAKdGhlIHRhc2sncwogICAgc3RhdGUgaXMgY2hhbmdl ZCBhZnRlciAic2F2ZWQiIHRhc2sncyBzdGF0ZS4KMi4gd2UgY2FuIHVzZSAiY3VyX3NwICE9IHRo cmVhZF9zYXZlZF9zcCh0c2spIiBhbmQgImN1cl9mcCAhPSAKdGhyZWFkX3NhdmVkX2ZwKHRzayki CiAgICBwcmV2ZW50IHByaW50aW5nIGJhY2t0cmFjZSBpZiB0aGUgdGFzaydzIHN0YXRlIGlzIGNo YW5nZWQgYmVmb3JlIAoic2F2ZWQiIHRhc2sncwogICAgc3RhdGUuIEJlY2F1c2UgdGhlIHZhbHVl IG9mICJ0aHJlYWRfc2F2ZWRfc3AodHNrKSIgYW5kIAoidGhyZWFkX3NhdmVkX2ZwKHRzaykiCiAg ICB3aWxsIG5vdCBlcXVhbCAic2F2ZWQiIHNwKGN1cl9zcCkgYW5kIGZwKGN1cl9mcCkuCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A5FC28CC0 for ; Thu, 30 May 2019 01:38:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCBB8243B9 for ; Thu, 30 May 2019 01:38:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dA7r1dbR"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="EWoJsHuy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbfE3Bit (ORCPT ); Wed, 29 May 2019 21:38:49 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:41026 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbfE3Bit (ORCPT ); Wed, 29 May 2019 21:38:49 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 50B72604D4; Thu, 30 May 2019 01:38:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559180328; bh=9juO5+fk3lH9CoK/+q+jiu9YWLxmL6m/v8Ar/h/6rRg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dA7r1dbR/WcRSYiIEupp6qAHJNrsO95trsbyZTmmzxUsb8Zo0gbeFDSUij5OG2jcX +1C4X2XuvcOhWEHoyDQ4e5R6UdBMAUBAx4IHqLKW/znZiORjtMFrdNaH9YygULN8CS DL1HkCgLNBzw6azTg5cbNpIiWhXmcOYGe6yti4P0= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 2DC1B6063A; Thu, 30 May 2019 01:38:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559180327; bh=9juO5+fk3lH9CoK/+q+jiu9YWLxmL6m/v8Ar/h/6rRg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EWoJsHuymdmKG5M3HXyjC7hFxN7Rb1p2YIhzDx8Mr+c7U2YS4wjOQ3lyeEui+LkV7 CAZllBM/koJNZi5ewZ0/sW4PUD2WUSJrtMpLq2XHEw9yJ9XPipzmgHX4+u9xtSvkcZ udBChGzm9WkNhKVmIfvPoXviQQge/MEFO/cEmUj4= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 30 May 2019 09:38:47 +0800 From: tengfeif@codeaurora.org To: Anshuman Khandual Cc: catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, marc.zyngier@arm.com, andreyknvl@google.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tengfei@codeaurora.org Subject: Re: [PATCH] arm64: break while loop if task had been rescheduled In-Reply-To: References: <1558430404-4840-1-git-send-email-tengfeif@codeaurora.org> Message-ID: <253affe7493cb9689e224d74aa182765@codeaurora.org> X-Sender: tengfeif@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-05-22 17:04, Anshuman Khandual wrote: > On 05/21/2019 02:50 PM, Tengfei Fan wrote: >> While printing a task's backtrace and this task isn't >> current task, it is possible that task's fp and fp+8 >> have the same value, so cannot break the while loop. >> This can break while loop if this task had been >> rescheduled during print this task's backtrace. > > This is very confusing. IIUC it suggests that while printing > the backtrace for non-current tasks the do/while loop does not > exit because fp and fp+8 might have the same value ? When would > this happen ? Even in that case the commit message here does not > properly match the change in this patch. In our issue, we got fp=pc=0xFFFFFF8025A13BA0, so cannot exit while loop in dump_basktrace(). After analyze our issue's dump, we found one task(such as: task A) is exiting via invoke do_exit() during another task is showing task A's dumptask. In kernel code, do_exit() and exit_notify are defined as follows: void noreturn do_exit(long code) { ...... exit_notify(tsk, group_dead); ...... } static void exit_notify(struct task_struct *tsk, int group_dead) { ...... } Because of exit_notify() is a static function, so it is inlined to do_exit() when compile kernel, so we can get partial assembly code of do_exit() as follows: …… { bool autoreap; struct task_struct *p, *n; LIST_HEAD(dead); write_lock_irq(&tasklist_lock); c10: 90000000 adrp x0, 0 c14: 910003e8 mov x8, sp c18: 91000000 add x0, x0, #0x0 */ static void exit_notify(struct task_struct *tsk, int group_dead) { bool autoreap; struct task_struct *p, *n; LIST_HEAD(dead); c1c: a90023e8 stp x8, x8, [sp] write_lock_irq(&tasklist_lock); c20: 94000000 bl 0 <_raw_write_lock_irq> c24: f9435268 ldr x8, [x19,#1696] …… From the code "c14:" and "c1c:", we will find sp's addr value is stored in sp and sp+8, so sp's vaule equal (sp+8)'s value. In our issue, there is a chance of fp point sp, so there will be fp=pc=fp's addr value,so code cannot break from while loop in dump_backtrace(). > > This patch tries to stop printing the stack for non-current tasks > if their state change while there is one dump_backtrace() trying > to print back trace. Dont we have any lock preventing a task in > this situation (while dumping it's backtrace) from running again > or changing state. I haven't found any lock preventing a task in this situation, and I think we shouldn't prevent task running if this task is scheduled. > >> >> Signed-off-by: Tengfei Fan >> --- >> arch/arm64/kernel/traps.c | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c >> index 2975598..9df6e02 100644 >> --- a/arch/arm64/kernel/traps.c >> +++ b/arch/arm64/kernel/traps.c >> @@ -103,6 +103,9 @@ void dump_backtrace(struct pt_regs *regs, struct >> task_struct *tsk) >> { >> struct stackframe frame; >> int skip = 0; >> + long cur_state = 0; >> + unsigned long cur_sp = 0; >> + unsigned long cur_fp = 0; >> >> pr_debug("%s(regs = %p tsk = %p)\n", __func__, regs, tsk); >> >> @@ -127,6 +130,9 @@ void dump_backtrace(struct pt_regs *regs, struct >> task_struct *tsk) >> */ >> frame.fp = thread_saved_fp(tsk); >> frame.pc = thread_saved_pc(tsk); >> + cur_state = tsk->state; >> + cur_sp = thread_saved_sp(tsk); >> + cur_fp = frame.fp; > > Should 'saved_state|sp|fp' instead as its applicable to non-current > tasks only. 'saved_state|sp|fp' only applies to non-current tasks. > >> } >> #ifdef CONFIG_FUNCTION_GRAPH_TRACER >> frame.graph = 0; >> @@ -134,6 +140,23 @@ void dump_backtrace(struct pt_regs *regs, struct >> task_struct *tsk) >> >> printk("Call trace:\n"); >> do { >> + if (tsk != current && (cur_state != tsk->state >> + /* >> + * We would not be printing backtrace for the task >> + * that has changed state from "saved" state to other >> + * state before hitting the do-while loop but after >> + * saving the current state. If task's current state > > This does not check any explicit task states like 'un-interruptible' or > 'running' but instead tracks change from any previously 'saved' state. have updated comments. > > >> + * not equal the "saved" state, then we may print >> + * wrong call trace or end up in infinite while loop >> + * if *(fp) and *(fp+8) are same. While the situation > > Then dump_backtrace() must detect it, should not save it and just > abort. have updatd commentes. > > >> + * should be stoped once we found the task's state + * is changed, so we detect the task's current state, + * sp and fp in each while. > > Thats not a reliable solution. AFICS we should not proceed further if > there is a chance of an wrong trace or an infinite loop. Hoping that > the printing will stop when task gets scheduled out does not seem > right. In this patch, it will break while loop and stop to print backtrace if we find the task's state change or there is a chance of an infinite loop. > >> + */ >> + || cur_sp != thread_saved_sp(tsk) >> + || cur_fp != thread_saved_fp(tsk))) { > > Why does any of these three mismatches detect the problematic > transition > not just the state ? 1. we can use "cur_state != tsk->state" prevent printing backtrace if the task's state is changed after "saved" task's state. 2. we can use "cur_sp != thread_saved_sp(tsk)" and "cur_fp != thread_saved_fp(tsk)" prevent printing backtrace if the task's state is changed before "saved" task's state. Because the value of "thread_saved_sp(tsk)" and "thread_saved_fp(tsk)" will not equal "saved" sp(cur_sp) and fp(cur_fp).