From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2890C3064D for ; Wed, 26 Jun 2024 15:36:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LKYLxlPZ/Z/Ce1zlFklXjP31P8T+OWxnz3zo+2ITPCU=; b=igj5jMwJi9ipdM4VhAnXJzsGB+ 5p4hvECNG9VERqrirQSwSHe1yZ+cWM1LUZfPo/YiNOmDFY2QmS8RkalTyDwu8Siro0PnUTQM722Nj FA13zyz8+5kxqWVO634CtfPZUANI5X055wfmGErvhOjfCvJcHOb8KVHHO+ENFTUgck6+knqY3pisM 15kCEIYydTI3pzjT00DK2Nl4vEA95oCWLe0kvX5cW0he0ja7f5nvFVeJQrk0g+hWnBoC6Tl9KjYKK RUO7ZD74VQmi4i/Yzd5/UkZ3mWOUtLhGjFmEo/SfVK7DOKi17q9YSTM1K2B2D3sDqCxtlc8aqAtak NzRqBMqQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMUh2-00000007QBO-2GRo; Wed, 26 Jun 2024 15:36:20 +0000 Received: from mail-mw2nam12on2060e.outbound.protection.outlook.com ([2a01:111:f403:200a::60e] helo=NAM12-MW2-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMUgz-00000007QAl-2v25 for linux-nvme@lists.infradead.org; Wed, 26 Jun 2024 15:36:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OzmGAu08dtIF/ifkQv+MY1osfYdsZY4T8R10/f0UBbmcVAu/Zi/BZZImWP6lTP9T3qMvYjO+HnHzF1MrOb8EC5jo0T40CivvCC7iwOuMC4+jnKUEtjvglLmtnJPnCAlOuZ8m7wi7nHULwNIpRBhy/qd6j2aIwKqtWw6dpVFFxv+eL3vNmFEz0eB+TwYFoo6LtDkj4qvygc2GhykX8YIsIuvzHMI4nA25ZrJ273iY9u1yShOrOeSh7WHei03RSq6f3IEga49yThYTXqmJ8vjl5vV41i0TfghibOiBMt254pyF8x2gjvUw0j89AlewUWZnUIV5PZlFMN6+KF/lVrE6vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKYLxlPZ/Z/Ce1zlFklXjP31P8T+OWxnz3zo+2ITPCU=; b=HMuvd32BIRhrCuQduHJodbW+Ni8YxJXWDZGfLY8/qEG3bJNtZKqrUmmFAim25oaNmQbygH7j7+Ij1JffWTwN+oLejHOmsaQXrnmGTIzrMSbji2GNKx/mbki4INsI73//UZKRCp1EKvh0fclMxhHWgcjeEguIHaTXbMOUGmxT6BXI3xs8pTbSKQsMO5exKxDhbMfjhLghO6oOtW626k/3Idr86qNqUeRz8l+sGXOTPmKc7TUYbBRBk1yjGTb54+E2iy5HHArE8VnfSOMnQL7HHqygYyIpJlU7rXOpuu7CfswVNmVSqNxshkIeuyZ/UYTdviDc7zWQIhZr4kAmODUcCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKYLxlPZ/Z/Ce1zlFklXjP31P8T+OWxnz3zo+2ITPCU=; b=POVil36axBOLhSr9hLqCGtUfOP8vHMzpJRYRZWM/9L888I86USUWrUmwUI95M0sHI8jCVbx1dQ8FbHl1ldAdZSENfRj1twisvH/PIzZid1/8Jrq0blVloob9BZ4LT0g8Zt+Twcw5L1ctNch49DkyycHgSNRyilH5aCbEcM4a+d60tk83sf5R4AngBN3SIZCIB8bo+NScddD3pHQHpPTkb2VnBo7gTTEVKdS/WvyLk8wPFiUxUNjzvUajPYZE8MxqJrfKHEMDJAlygMqFeoF5CzJRr9MjJ0G+RTJlwRmGH8f5/l+zTmSeEn6RbPkcbi6deYtyBNDn7h+Fsq1Km2R1Jg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) by DS0PR12MB7873.namprd12.prod.outlook.com (2603:10b6:8:142::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7698.30; Wed, 26 Jun 2024 15:21:58 +0000 Received: from SJ1PR12MB6075.namprd12.prod.outlook.com ([fe80::3715:9750:b92c:7bee]) by SJ1PR12MB6075.namprd12.prod.outlook.com ([fe80::3715:9750:b92c:7bee%7]) with mapi id 15.20.7698.025; Wed, 26 Jun 2024 15:21:58 +0000 From: Aurelien Aptel To: Sagi Grimberg , Jakub Kicinski Cc: "linux-nvme@lists.infradead.org" , "netdev@vger.kernel.org" , "hch@lst.de" , "kbusch@kernel.org" , "axboe@fb.com" , Chaitanya Kulkarni , "davem@davemloft.net" , Shai Malin , "malin1024@gmail.com" , Yoray Zack , Jason Gunthorpe , Tariq Toukan , mgurtovoy@nvidia.com, galshalom@nvidia.com, borisp@nvidia.com, ogerlitz@nvidia.com Subject: RE: [PATCH v25 00/20] nvme-tcp receive offloads In-Reply-To: References: <20240529160053.111531-1-aaptel@nvidia.com> <20240530183906.4534c029@kernel.org> <9ed2275c-7887-4ce1-9b1d-3b51e9f47174@grimberg.me> Date: Wed, 26 Jun 2024 18:21:54 +0300 Message-ID: <253v81vpw4t.fsf@nvidia.com> Content-Type: text/plain X-ClientProxiedBy: FR4P281CA0372.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:f8::18) To SJ1PR12MB6075.namprd12.prod.outlook.com (2603:10b6:a03:45e::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR12MB6075:EE_|DS0PR12MB7873:EE_ X-MS-Office365-Filtering-Correlation-Id: c8525f44-d6e5-4afd-5489-08dc95f3b840 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230038|366014|376012|1800799022; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?rJwwdw2XE21xfxcNXkMn2whM10r8y//DZrnHAY7rE6XMPx9lCJdq1NK+f/sj?= =?us-ascii?Q?IWg/Q2xb0bYEhOsLloycbSWpTWrnmtOMJKL54xcNflR5OV0sJzRzpSo97/i8?= =?us-ascii?Q?3GDxsuTeNV+sTnemDIgWT6r2+iRB1kSwiu+ZfRClEI2Q7JKMuscBiKpFhvbR?= =?us-ascii?Q?pBSLbdGFRXwRZ9+6YEnrK8eZv0gg7geWRTjqTFJ45cpJO12vJxF1mbohLXSg?= =?us-ascii?Q?yIRG8B7nyEnqCtkn7w2hGrPrxuwUCJOZKXnFizKLs3okVvrR3dhPncrLdsQo?= =?us-ascii?Q?AI9NCFBJf7v/KuduIRuvaKnO5u7mdAZ7YlFUCQSUk6f3n8pAQMSiQc63lhpO?= =?us-ascii?Q?6gVRtmjqfYGI2Q31NDGkLl8VvMmTORbcvAJdOfjuUQGXmELbKNpbA+apSVum?= =?us-ascii?Q?YyYYyRY9HIqvgjXuvTYfPdyxtZjEB3LiVrN9nenzuLajmakyfYAE04GtGG/q?= =?us-ascii?Q?tcpKsgj5bmSY1hePVvTc6DSX4maEPUE5N43FR8PEWoKZGEGGtEassxDPtErM?= =?us-ascii?Q?IGS14QaeryH9J1oPxWuxGhfaE/qKdTuxQPycoZO+9ul7H2oWlqEsO+f9XUdO?= =?us-ascii?Q?Olt05ksy6DesD5JSdAa7J1VR20fheLAOeQfpAKhtPzFX2nz9OKVExcOLrspL?= =?us-ascii?Q?GKBcF9lGFnwa6t8Pea67LmefXbfx2hO65dmRqB9wHztS+byqIkMTHynPK0e0?= =?us-ascii?Q?W1gFUWO0VkJIaL1WJWnJgvXfP6wmHbBuTbVDdpepUD8gI412GR9eNZsV/IMN?= =?us-ascii?Q?t0gXbsABMNTAkC8duZCjDEoBm0WFurZwyxZprlfw7LDW/Xi9MeWYp1KIJD4h?= =?us-ascii?Q?rzupJqxN4lbVbfPtoQKhIGjmSeN+zbe+122IYEM3bajdBchUwPTAFDPJESYd?= =?us-ascii?Q?U59USUi0v1taTqFoOcEF0HObC497oTqDxIN2ysZq8h/i8EcKoyhiLTohRKA5?= =?us-ascii?Q?u+ZwOthbTs8WDgqvliwG0oKJC2sxR8SeHUElPT6088L7QdE/niw2Wd1q0LWZ?= =?us-ascii?Q?0xFJ39SUkhTISr4gLCidKpo7JR9S/YL9qiW0S9LMZ/ntSTze5C1d1UYzJW9B?= =?us-ascii?Q?msQJMmHpy/hLXux13Kpls0OOvJ+7tTW2mFHkgLxyiOv3idXUMeavnTuQr1z9?= =?us-ascii?Q?SXFPLTbe/OqO6lAivWEg8h7Dmo85k7mwBwhizFCKw1gXYEg8BhebnQyxwxpr?= =?us-ascii?Q?vqVx9Kopc+pSrizVrIDUE+RVreoG4aingyUm1QKi/GgM6G6xIo2fWiW6n83c?= =?us-ascii?Q?4awjUq7c6RHiaC9piJH4mTPhOWMsLbKq2y1lBKTwcBAgUxZEJ5JsSMoRhm5k?= =?us-ascii?Q?RMIwVC9k8RIl68Cyi5q3nTF9VHUKi3awC1yiQm4S08eqpg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR12MB6075.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230038)(366014)(376012)(1800799022);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IVTMUSpQ/bzZG82Dvx2B25ryDn4SPh3lPWqh9/pEH6kmH8pNwBTBLgRy7K1z?= =?us-ascii?Q?mitaXsQS4IHkY0PiOfpw4NPwTDAelbP67iBSAa9wH1edPSuoimwKyKUSPrPR?= =?us-ascii?Q?sqE2t/0KRbOMYFW4r+lKo5wKcjXPwCz/hP1K1yGQvyoU9Lu614MJVMccVKyZ?= =?us-ascii?Q?jf2qqhVivPmGaSvmQqHFiakteo3u/WkeGQOYGMv7Kh50jYqgZarcXh5qyN/z?= =?us-ascii?Q?+39BGQVYnFe9PYeywcl5FVmaCjF4ihe+34Z3NKy/g5KzpZtx+37vnBamRZoQ?= =?us-ascii?Q?7T+GSuy3cFLggZ8rbPWz5mzl5OlBU8wnu+fRIwq+VcxYtQSTST0bgxR48aMl?= =?us-ascii?Q?QOJpgXeliiy313W33m6KMximhJoEKR4Fx5/f0i8nt39SvjCrXJ0T06xIKeMu?= =?us-ascii?Q?WmTRoIoE/1wi/7/05Kwn5/2Usjqw1dxtyxPr9iBz5DL0poCniYOZXjlCXChC?= =?us-ascii?Q?8wuHVkIfdhVLPcq4kEXBajUgACqFMFyen21Pczs3j1znD5rQoqslz+oXm6Vu?= =?us-ascii?Q?BX84q+nqFcViOfzDBJCgxWmNXPZrQqpUnsjqmZcazLpBWpHWuvfQ+2UNwXkH?= =?us-ascii?Q?NIlq1Jnq7bXUcN7AB3h4Nd+Pj3SfLXD9O3y0LlBpTwbhPNB7FTRus4r6zM4e?= =?us-ascii?Q?LqXCaOQuZnBRxBqUieH9UOYkpyB+KDbc0f7/9TXAjFjJeVIIKne/zWVZUMYF?= =?us-ascii?Q?Qo5k0u+sWz39vqlsJFZvAQfUKH5p4PaQ75ymBmcsY6JC4JzuJZc8ra4YMfzx?= =?us-ascii?Q?DBXEUs+uj6Vvp+10BYYxa1ho51bPTy4Q24PXI8p2l86vGEOainC6xEZ1sf71?= =?us-ascii?Q?HSdM41AE7ffca8PhrOlUVSzS5C88loYiVnl988Ln2ul7eEniwNG9sS+wlEJh?= =?us-ascii?Q?lCIZCetMWN+QfezOAedsmZqczkHs2+2FDLQoow2hQzx0e0Axt2C+CbEpBr05?= =?us-ascii?Q?zkqcy+wuLt0I0fHO0aKCn6OO+/2uLXCUHLh8bWTM1QJLVwluWzbB19Ja7efo?= =?us-ascii?Q?TRQA3Mwqrp1G2MDsQUiKedmra77Zpuxfl8pyU7i/iYjto+NcWK+kwc2g1mqK?= =?us-ascii?Q?qlLOWBUJpxxn+0E9gQ5olPJbut0gKGVAqYH7j9Xqlx4c2Mk4JrHCiZhq0I2x?= =?us-ascii?Q?ErpUCVzUFRP698YJDKvi8SCJGu8r+Y+mIO1jHloa//hfayVmmHVtgZ/HMTrR?= =?us-ascii?Q?/Fdk+ydp3CVgivbuhP58g8GTRn5Znrj84k+6HCCy/2gZGiLRFErTNfXVweq7?= =?us-ascii?Q?qCna4OhcxQNCnC1en2WELujNPRGp6ED7q1QQmsWi41kEat1yBM4qnyyGMNiV?= =?us-ascii?Q?VnPCB4IJzFnBqfEUKhncepq3Bjbs7RATcZRTVyNNkiQt8c2LgmGQS2I6Q/B3?= =?us-ascii?Q?8fD6jAGLEEuIUhE5JM6f0QwFcvxHHa51ImUx2g0RSPY/xJZuTw15pU1VzaZj?= =?us-ascii?Q?FrCuSa5EbYfT8y/XJ1PNZvoXTkWe3LMAB3cWU7bkipTwaS6cOGsOgu4dQUh0?= =?us-ascii?Q?w4obe0Rull4lR9wzDvdQYrnroiAt5T0ITfV8wrKuRF9kbWc6/nacd9lw/GCm?= =?us-ascii?Q?ZJpuPRKy7WPnicImbn7QjFfUTh28zuWstAsEx0al?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8525f44-d6e5-4afd-5489-08dc95f3b840 X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6075.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jun 2024 15:21:58.3280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kFzxSgSGv4HR/3Ebt9qZoTz9UJicyx+OoOHfHAA7xLShZsYiq7MMRKJLOPLdlPldAj77WZnwg1DnO+6CijXQdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7873 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_083617_746380_08B1F8E8 X-CRM114-Status: UNSURE ( 6.13 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org Hi, We have taken some time to review your documents and code and have had several internal discussions regarding the CI topic. We truly appreciate the benefits that a CI setup could bring. However, we believe that since this feature primarily relies on nvme-tcp, it might achieve better coverage and testing if integrated with blktest. Your design focuses on the netdev layer, which we don't think is sufficient. blktests/nvme is designed to test the entire nvme upstream infrastructure including nvme-tcp that targets corner cases and bugs in on-going development. Chaitanya, Shinichiro, Daniel and other developers are actively developing blktests and running these tests in timely manner on latest branch in linux-nvme repo and for-next branch in linux-block repo. Again, we are open to provide NIC so that others can also test this feature on upstream kernel on our NIC to facilitate easier testing including distros, as long as they are testing this feature on upstream kernel. In this way we don't have to replicate the nvme-block storage stack infra/tools/tests in the framework that is focused on netdev development and yet achieve good coverage, what do you think? Thanks