Re: [B.A.T.M.A.N.] [PATCH 7/7] batman-adv: add debugfs support to view multiif tables

[Marek Lindner <mareklindner@neomailbox.ch>]

[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]

On Wednesday 09 October 2013 15:05:38 Simon Wunderlich wrote:
>  			hlist_for_each_entry_rcu(neigh_node_tmp,
>  						 &orig_node->neigh_list, list) {
> -				neigh_ifinfo = batadv_neigh_node_get_ifinfo(
> -							neigh_node, NULL);
> -				if (!neigh_ifinfo)
> +				n_ifinfo = batadv_neigh_node_get_ifinfo(
> +							neigh_node,
> +							if_outgoing);

Nope ...


> +/**
> + * batadv_originators_open_multiif - handles debugfs output for the
> + *	originators_multiif table
> + * @inode: inode pointer to debugfs file
> + * @file: pointer to the seq_file
> + */

Documentation longer than one line should be indented by one char not 8 
(second line).


> --- a/originator.c
> +++ b/originator.c
> @@ -776,7 +776,49 @@ int batadv_orig_seq_print_text(struct seq_file *seq,
> void *offset) return 0;
>  	}
> 
> -	bat_priv->bat_algo_ops->bat_orig_print(bat_priv, seq);
> +	bat_priv->bat_algo_ops->bat_orig_print(bat_priv, seq, NULL);
> +
> +	return 0;
> +}
> +
> +/**
> + * batadv_orig_multiif_seq_print_text - writes originator infos for all
> + *	outgoing interfaces
> + * @seq: debugfs table seq_file struct
> + * @offset: not used
> + *
> + * Returns 0
> + */

Same indentation problem here.

Cheers,
Marek

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]