From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:37468 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932432AbeD0V0U (ORCPT ); Fri, 27 Apr 2018 17:26:20 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 00/11] r8a77965: M3-N DU Enablement Date: Sat, 28 Apr 2018 00:26:34 +0300 Message-ID: <254152681.Kc1dWBUcyC@avalon> In-Reply-To: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, On Friday, 27 April 2018 19:57:11 EEST Kieran Bingham wrote: > This series enables the DU for the M3-N R8A77965 SoC, and provides > output on the VGA and HDMI connectors. > > LVDS is not yet supported or tested. > > > Patch 9 has the following checkpatch.pl warnings of which I have > ignored: > > =========================================================================== > WARNING: line over 80 characters > #44: FILE: arch/arm64/boot/dts/renesas/r8a77965.dtsi:1126: > + remote-endpoint = > <&du_out_hdmi0>; > > WARNING: line over 80 characters > #60: FILE: arch/arm64/boot/dts/renesas/r8a77965.dtsi:1164: > + remote-endpoint = > <&dw_hdmi0_in>; > =========================================================================== > > I don't think the remote endpoints can be shorter unless the <&phandles> > are on a line on their own and that seems silly. > > This series is available via git at the following URL: > git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git > du/m3n/enablement/v2 That's based on renesas-drivers that includes branches not ready for upstream yet. The patches don't apply cleanly on top of my drm/du/next branch (itself based on top of Dave's drm-next branch). Please don't use renesas-drivers for patch development and submission. > Kieran Bingham (11): > dt-bindings: display: renesas: Add R-Car M3-N HDMI TX DT bindings > pinctrl: sh-pfc: r8a77965: Add DU RGB output pins, groups and > functions > drm: rcar-du: Split CRTC handling to support hardware indexing > drm: rcar-du: Allow DU groups to work with hardware indexing > drm: rcar-du: Add R8A77965 support > arm64: dts: r8a77965: Add FCPF and FCPV instances > arm64: dts: r8a77965: Add VSP instances > arm64: dts: r8a77965: Populate the DU instance placeholder > arm64: dts: r8a77965: Add HDMI encoder instance > arm64: dts: r8a77965-salvator-x: Enable DU external clocks and HDMI > arm64: dts: r8a77965-salvator-xs: Enable DU external clocks and HDMI > > .../display/bridge/renesas,dw-hdmi.txt | 1 + > .../boot/dts/renesas/r8a77965-salvator-x.dts | 28 ++++ > .../boot/dts/renesas/r8a77965-salvator-xs.dts | 29 ++++ > arch/arm64/boot/dts/renesas/r8a77965.dtsi | 131 +++++++++++++++++- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 26 ++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 3 +- > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 51 +++++-- > drivers/gpu/drm/rcar-du/rcar_du_drv.h | 4 +- > drivers/gpu/drm/rcar-du/rcar_du_group.c | 14 +- > drivers/gpu/drm/rcar-du/rcar_du_group.h | 2 + > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 23 ++- > drivers/pinctrl/sh-pfc/pfc-r8a77965.c | 116 ++++++++++++++++ > 12 files changed, 387 insertions(+), 41 deletions(-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 00/11] r8a77965: M3-N DU Enablement Date: Sat, 28 Apr 2018 00:26:34 +0300 Message-ID: <254152681.Kc1dWBUcyC@avalon> References: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 031F86EAEF for ; Fri, 27 Apr 2018 21:26:20 +0000 (UTC) In-Reply-To: <20180427165722.19445-1-kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gRnJpZGF5LCAyNyBBcHJpbCAyMDE4IDE5OjU3OjExIEVFU1QgS2llcmFu IEJpbmdoYW0gd3JvdGU6Cj4gVGhpcyBzZXJpZXMgZW5hYmxlcyB0aGUgRFUgZm9yIHRoZSBNMy1O IFI4QTc3OTY1IFNvQywgYW5kIHByb3ZpZGVzCj4gb3V0cHV0IG9uIHRoZSBWR0EgYW5kIEhETUkg Y29ubmVjdG9ycy4KPiAKPiBMVkRTIGlzIG5vdCB5ZXQgc3VwcG9ydGVkIG9yIHRlc3RlZC4KPiAK PiAKPiBQYXRjaCA5IGhhcyB0aGUgZm9sbG93aW5nIGNoZWNrcGF0Y2gucGwgd2FybmluZ3Mgb2Yg d2hpY2ggSSBoYXZlCj4gaWdub3JlZDoKPiAKPiA9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KPiBXQVJOSU5H OiBsaW5lIG92ZXIgODAgY2hhcmFjdGVycwo+ICM0NDogRklMRTogYXJjaC9hcm02NC9ib290L2R0 cy9yZW5lc2FzL3I4YTc3OTY1LmR0c2k6MTEyNjoKPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByZW1vdGUtZW5kcG9pbnQgPQo+IDwmZHVfb3V0X2hkbWkw PjsKPiAKPiBXQVJOSU5HOiBsaW5lIG92ZXIgODAgY2hhcmFjdGVycwo+ICM2MDogRklMRTogYXJj aC9hcm02NC9ib290L2R0cy9yZW5lc2FzL3I4YTc3OTY1LmR0c2k6MTE2NDoKPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZW1vdGUtZW5kcG9pbnQgPQo+ IDwmZHdfaGRtaTBfaW4+Owo+ID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo+IAo+IEkgZG9uJ3QgdGhpbmsg dGhlIHJlbW90ZSBlbmRwb2ludHMgY2FuIGJlIHNob3J0ZXIgdW5sZXNzIHRoZSA8JnBoYW5kbGVz Pgo+IGFyZSBvbiBhIGxpbmUgb24gdGhlaXIgb3duIGFuZCB0aGF0IHNlZW1zIHNpbGx5Lgo+IAo+ IFRoaXMgc2VyaWVzIGlzIGF2YWlsYWJsZSB2aWEgZ2l0IGF0IHRoZSBmb2xsb3dpbmcgVVJMOgo+ ICBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQva2JpbmdoYW0v cmNhci5naXQKPiAgZHUvbTNuL2VuYWJsZW1lbnQvdjIKClRoYXQncyBiYXNlZCBvbiByZW5lc2Fz LWRyaXZlcnMgdGhhdCBpbmNsdWRlcyBicmFuY2hlcyBub3QgcmVhZHkgZm9yIHVwc3RyZWFtIAp5 ZXQuIFRoZSBwYXRjaGVzIGRvbid0IGFwcGx5IGNsZWFubHkgb24gdG9wIG9mIG15IGRybS9kdS9u ZXh0IGJyYW5jaCAoaXRzZWxmIApiYXNlZCBvbiB0b3Agb2YgRGF2ZSdzIGRybS1uZXh0IGJyYW5j aCkuIFBsZWFzZSBkb24ndCB1c2UgcmVuZXNhcy1kcml2ZXJzIGZvciAKcGF0Y2ggZGV2ZWxvcG1l bnQgYW5kIHN1Ym1pc3Npb24uCgo+IEtpZXJhbiBCaW5naGFtICgxMSk6Cj4gICBkdC1iaW5kaW5n czogZGlzcGxheTogcmVuZXNhczogQWRkIFItQ2FyIE0zLU4gSERNSSBUWCBEVCBiaW5kaW5ncwo+ ICAgcGluY3RybDogc2gtcGZjOiByOGE3Nzk2NTogQWRkIERVIFJHQiBvdXRwdXQgcGlucywgZ3Jv dXBzIGFuZAo+ICAgICBmdW5jdGlvbnMKPiAgIGRybTogcmNhci1kdTogU3BsaXQgQ1JUQyBoYW5k bGluZyB0byBzdXBwb3J0IGhhcmR3YXJlIGluZGV4aW5nCj4gICBkcm06IHJjYXItZHU6IEFsbG93 IERVIGdyb3VwcyB0byB3b3JrIHdpdGggaGFyZHdhcmUgaW5kZXhpbmcKPiAgIGRybTogcmNhci1k dTogQWRkIFI4QTc3OTY1IHN1cHBvcnQKPiAgIGFybTY0OiBkdHM6IHI4YTc3OTY1OiBBZGQgRkNQ RiBhbmQgRkNQViBpbnN0YW5jZXMKPiAgIGFybTY0OiBkdHM6IHI4YTc3OTY1OiBBZGQgVlNQIGlu c3RhbmNlcwo+ICAgYXJtNjQ6IGR0czogcjhhNzc5NjU6IFBvcHVsYXRlIHRoZSBEVSBpbnN0YW5j ZSBwbGFjZWhvbGRlcgo+ICAgYXJtNjQ6IGR0czogcjhhNzc5NjU6IEFkZCBIRE1JIGVuY29kZXIg aW5zdGFuY2UKPiAgIGFybTY0OiBkdHM6IHI4YTc3OTY1LXNhbHZhdG9yLXg6IEVuYWJsZSBEVSBl eHRlcm5hbCBjbG9ja3MgYW5kIEhETUkKPiAgIGFybTY0OiBkdHM6IHI4YTc3OTY1LXNhbHZhdG9y LXhzOiBFbmFibGUgRFUgZXh0ZXJuYWwgY2xvY2tzIGFuZCBIRE1JCj4gCj4gIC4uLi9kaXNwbGF5 L2JyaWRnZS9yZW5lc2FzLGR3LWhkbWkudHh0ICAgICAgICB8ICAgMSArCj4gIC4uLi9ib290L2R0 cy9yZW5lc2FzL3I4YTc3OTY1LXNhbHZhdG9yLXguZHRzICB8ICAyOCArKysrCj4gIC4uLi9ib290 L2R0cy9yZW5lc2FzL3I4YTc3OTY1LXNhbHZhdG9yLXhzLmR0cyB8ICAyOSArKysrCj4gIGFyY2gv YXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk2NS5kdHNpICAgICB8IDEzMSArKysrKysrKysr KysrKysrKy0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmMgICAgICAg IHwgIDI2ICsrLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9jcnRjLmggICAg ICAgIHwgICAzICstCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2LmMgICAg ICAgICB8ICA1MSArKysrKy0tCj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfZHJ2 LmggICAgICAgICB8ICAgNCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2dy b3VwLmMgICAgICAgfCAgMTQgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9n cm91cC5oICAgICAgIHwgICAyICsKPiAgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9r bXMuYyAgICAgICAgIHwgIDIzICsrLQo+ICBkcml2ZXJzL3BpbmN0cmwvc2gtcGZjL3BmYy1yOGE3 Nzk2NS5jICAgICAgICAgfCAxMTYgKysrKysrKysrKysrKysrKwo+ICAxMiBmaWxlcyBjaGFuZ2Vk LCAzODcgaW5zZXJ0aW9ucygrKSwgNDEgZGVsZXRpb25zKC0pCgoKLS0gClJlZ2FyZHMsCgpMYXVy ZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=