From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: grub-devel@gnu.org
Subject: Re: [PATCH] gfxterm: check elements' properties and hadle errors.
Date: Thu, 07 Mar 2013 11:46:15 +0400 [thread overview]
Message-ID: <2544568.Y50qHJl12c@icedphoenix> (raw)
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
>This is not a correct error handling. You should never return an error
>without calling grub_error. Also in all these contexts you handle the
>cases of unknown property name. I don't feel like refusing to load a
>theme because of unknown property is a good idea. This would i.a.
>exclude older GRUB versions for newer themes even if property in
>question is minor in meaning. Compare this to a browser refusing to show
>a page because of unknown tag attribute. Also GRUB_ERR_IO hardly
>describes a condition of unknown property.
Thanks for the reply. :) This subject is closed.
--
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru
[-- Attachment #2: Type: text/html, Size: 3551 bytes --]
next reply other threads:[~2013-03-07 7:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 7:46 Vladimir Testov [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 6:29 [PATCH] gfxterm: check elements' properties and hadle errors Vladimir Testov
2013-03-07 4:22 Vladimir Testov
2013-03-07 6:03 ` Andrey Borzenkov
2013-03-04 11:27 Vladimir Testov
2013-03-06 18:05 ` Andrey Borzenkov
2013-03-07 7:31 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2544568.Y50qHJl12c@icedphoenix \
--to=vladimir.testov@rosalab.ru \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.