From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Wed, 10 Dec 2014 12:00:38 +0100 Subject: [PATCH 2/4] irqchip: mediatek: Add support for mt8173 In-Reply-To: <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> Message-ID: <2545975.QDuBFbG7BN@wuerfel> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: > From: Yingjoe Chen > > MT8173 intpol have 32 more irq pins, add support to it. > > Signed-off-by: Yingjoe Chen > Signed-off-by: Eddie Huang > How about adding a property for the number of irq pins and leave the old compatible string in place? I don't think it would be good if we have to update this driver for each new SoC that uses this irqchip just to change one number. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173 Date: Wed, 10 Dec 2014 12:00:38 +0100 Message-ID: <2545975.QDuBFbG7BN@wuerfel> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1418208602-35584-3-git-send-email-eddie.huang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Eddie Huang , Matthias Brugger , Rob Herring , Jason Cooper , Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Pawel Moll , Ian Campbell , Catalin Marinas , Mark Brown , Will Deacon , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Robert Richter , Sascha Hauer , Kumar Gala , Olof Johansson , "Joe.C" , Thomas Gleixner , yh.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: > From: Yingjoe Chen > > MT8173 intpol have 32 more irq pins, add support to it. > > Signed-off-by: Yingjoe Chen > Signed-off-by: Eddie Huang > How about adding a property for the number of irq pins and leave the old compatible string in place? I don't think it would be good if we have to update this driver for each new SoC that uses this irqchip just to change one number. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755577AbaLJLBf (ORCPT ); Wed, 10 Dec 2014 06:01:35 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:55485 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222AbaLJLBd (ORCPT ); Wed, 10 Dec 2014 06:01:33 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eddie Huang , Matthias Brugger , Rob Herring , Jason Cooper , Mark Rutland , devicetree@vger.kernel.org, srv_heupstream@mediatek.com, Pawel Moll , Ian Campbell , Catalin Marinas , Mark Brown , Will Deacon , linux-kernel@vger.kernel.org, Robert Richter , Sascha Hauer , Kumar Gala , Olof Johansson , "Joe.C" , Thomas Gleixner , yh.chen@mediatek.com Subject: Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173 Date: Wed, 10 Dec 2014 12:00:38 +0100 Message-ID: <2545975.QDuBFbG7BN@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> References: <1418208602-35584-1-git-send-email-eddie.huang@mediatek.com> <1418208602-35584-3-git-send-email-eddie.huang@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Q07EoDcINIQtgobyCjlkARjKwl3Fx2OUSfZX6BLkAdUXO9END3d 4MZK7PNXdGQ07cEJmJfJqvN2wtj/sClaxE5SSCaQ+8qmsb9G2HbRu1s8OXOKxzjqCIg5Eyh 1zG0Fk7Ny9c8gMYjGwDZ2NM4z6fplYOZ0V7UvSGbbz5Q1+mQ6C6ztxzsli2JO/m5hsFlQiV coy18mIdSgnvlbxxOMe0A== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: > From: Yingjoe Chen > > MT8173 intpol have 32 more irq pins, add support to it. > > Signed-off-by: Yingjoe Chen > Signed-off-by: Eddie Huang > How about adding a property for the number of irq pins and leave the old compatible string in place? I don't think it would be good if we have to update this driver for each new SoC that uses this irqchip just to change one number. Arnd