From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: regmap: mmio: regression in pre-v4.6-rc1
Date: Wed, 23 Mar 2016 12:50:53 +0100 [thread overview]
Message-ID: <2546687.zGbvS8bYIW@ws-stein> (raw)
In-Reply-To: <20160323113939.GI2566@sirena.org.uk>
On Wednesday 23 March 2016 11:39:39, Mark Brown wrote:
> On Wed, Mar 23, 2016 at 12:16:13PM +0100, Alexander Stein wrote:
> > On Wednesday 23 March 2016 10:34:15, Mark Brown wrote:
>
> > > Are you *sure* that this is actually big endian? Are you basing this on
> > > documentation or on what happened to work for you in the past.
>
> > Please refer to QorIQ LS1021A Reference Manual (REV 0) table 2.2 (CCSR block
> > base address map) which states that this peripheral (among _most_ but not all)
> > requires byte swapping. Same for DSPI.
> > Yeah, it sounds strange.
>
> I don't have that document.
Nothing wrong with that, I just wanted to state where it is actually documented.
> > > Have you tried tracing through the code to see what ends up happening to
> > > the I/O? It should come out using your architecture's big endian
> > > accessors.
>
> > In regmap_mmio_gen_context ctx->reg_read is set to regmap_mmio_read32le and
> > ctx->reg_write to regmap_mmio_write32le respectively.
>
> So how does that happen then? We set these values if the bus is
> default, little or native endian but if it's big endian we go into a
> completely different case...
Well, in regmap_mmio_gen_context config->reg_format_endian is still set to REGMAP_ENDIAN_DEFAULT. of_syscon_register sets config.val_format_endian (notice val_ instead of reg_) depending on "big-endian" (or "little-endian") property.
I'm kinda confused regarding reg_format_endian and val_format_endian. Dunno what should be set in which way.
Best regards,
Alexander
next prev parent reply other threads:[~2016-03-23 11:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 8:48 regmap: mmio: regression in pre-v4.6-rc1 Alexander Stein
2016-03-23 9:43 ` Alexander Stein
2016-03-23 10:34 ` Mark Brown
2016-03-23 11:16 ` Alexander Stein
2016-03-23 11:39 ` Mark Brown
2016-03-23 11:50 ` Alexander Stein [this message]
2016-03-23 12:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2546687.zGbvS8bYIW@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.