From: David Howells <dhowells@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>,
davem@davemloft.net, netdev@vger.kernel.org,
herbert.xu@redhat.com, linux-kernel@vger.kernel.org,
arjan@infradead.org
Subject: Re: [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly [try #2]
Date: Fri, 16 Mar 2007 14:19:02 +0000 [thread overview]
Message-ID: <25477.1174054742@redhat.com> (raw)
In-Reply-To: <20070316151257.24238f2a@lxorguk.ukuu.org.uk>
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> As do many things but the goal of the coding style is consistency and
> almost all other code doesn't have the static inline wasting an extra
> display line.
Actually it doesn't waste an extra display line. Either the static inline is
on a line of its own, or the first argument is on a line of its own. Either
way it uses up two lines - unless you want to split it up further and have
four lines as per Christoph's second suggestion (static inline / void /
funcname / 1st arg).
David
next prev parent reply other threads:[~2007-03-16 14:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 12:50 [PATCH 0/5] [RFC] AF_RXRPC socket family implementation [try #2] David Howells
2007-03-16 12:50 ` [PATCH 1/5] AF_RXRPC: Add blkcipher accessors for using kernel data directly " David Howells
2007-03-16 13:32 ` Christoph Hellwig
2007-03-16 13:57 ` David Howells
2007-03-16 15:12 ` Alan Cox
2007-03-16 14:19 ` David Howells [this message]
2007-03-16 12:50 ` [PATCH 2/5] AF_RXRPC: Move generic skbuff stuff from XFRM code to generic code " David Howells
2007-03-16 13:36 ` Christoph Hellwig
2007-03-16 12:50 ` [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work " David Howells
2007-03-16 15:07 ` Alan Cox
2007-03-16 14:22 ` David Howells
2007-03-16 12:50 ` [PATCH 4/5] AF_RXRPC: Key facility changes for AF_RXRPC " David Howells
2007-03-16 13:38 ` Christoph Hellwig
2007-03-16 14:15 ` David Howells
2007-03-16 13:40 ` [PATCH 0/5] [RFC] AF_RXRPC socket family implementation " Christoph Hellwig
2007-03-16 15:13 ` Alan Cox
2007-03-16 14:23 ` David Howells
2007-03-16 15:34 ` Alan Cox
2007-03-16 15:14 ` David Howells
2007-03-16 17:11 ` Alan Cox
2007-03-18 6:32 ` Kyle Moffett
2007-03-18 14:23 ` Alan Cox
2007-03-19 11:56 ` David Howells
2007-03-19 13:04 ` Alan Cox
2007-03-19 12:59 ` David Howells
2007-03-19 15:29 ` Alan Cox
2007-03-19 15:41 ` David Howells
2007-03-19 19:03 ` Alan Cox
2007-03-20 11:16 ` David Howells
2007-03-19 19:19 ` David Miller
2007-03-20 13:16 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25477.1174054742@redhat.com \
--to=dhowells@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=herbert.xu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.