Re: [PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: khilman@baylibre.com, dri-devel@lists.freedesktop.org,
	bgolaszewski@baylibre.com, tomi.valkeinen@ti.com,
	rmk+kernel@arm.linux.org.uk
Subject: Re: [PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call
Date: Wed, 19 Oct 2016 10:54:06 +0300	[thread overview]
Message-ID: <2548817.EVISR1fG5n@avalon> (raw)
In-Reply-To: <e988513ba2c8cf280f956c9d8e2494682855a248.1476825466.git.jsarha@ti.com>

Hi Jyri,

Thank you for the patch.

On Wednesday 19 Oct 2016 00:33:54 Jyri Sarha wrote:
> Remove obsolete drm_connector_register() call from tda998x_bind(). All
> connectors are registered when drm_dev_register() is called by the
> master drm_device driver.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

By the way, any chance you would plan porting the driver to drm_bridge ? :-)

> ---
>  drivers/gpu/drm/i2c/tda998x_drv.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c
> b/drivers/gpu/drm/i2c/tda998x_drv.c index 9798d40..265f854 100644
> --- a/drivers/gpu/drm/i2c/tda998x_drv.c
> +++ b/drivers/gpu/drm/i2c/tda998x_drv.c
> @@ -1656,16 +1656,10 @@ static int tda998x_bind(struct device *dev, struct
> device *master, void *data) if (ret)
>  		goto err_connector;
> 
> -	ret = drm_connector_register(&priv->connector);
> -	if (ret)
> -		goto err_sysfs;
> -
>  	drm_mode_connector_attach_encoder(&priv->connector, &priv->encoder);
> 
>  	return 0;
> 
> -err_sysfs:
> -	drm_connector_cleanup(&priv->connector);
>  err_connector:
>  	drm_encoder_cleanup(&priv->encoder);
>  err_encoder:

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel