Re: [PATCH] devtools: add compressdev tests to test-build

[Thomas Monjalon <thomas@monjalon.net>]

16/07/2018 19:33, De Lara Guarch, Pablo:
> HI Thomas,
> 
> > -----Original Message-----
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Sent: Wednesday, July 11, 2018 4:50 PM
> > To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [PATCH] devtools: add compressdev tests to test-build
> > 
> > 11/07/2018 09:17, Pablo de Lara:
> > > Compressdev tests depend on Zlib library, so they can only be enabled
> > > if this is available.
> > >
> > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > > ---
> > > --- a/devtools/test-build.sh
> > > +++ b/devtools/test-build.sh
> > > @@ -154,6 +154,7 @@ config () # <directory> <target> <options>
> > >  		test "$DPDK_DEP_ZLIB" != y || \
> > >  		sed -ri          's,(BNX2X_PMD=)n,\1y,' $1/.config
> > >  		sed -ri            's,(NFP_PMD=)n,\1y,' $1/.config
> > > +		sed -ri   's,(COMPRESSDEV_TEST=)n,\1y,' $1/.config
> > 
> > It is always enabled here.
> > You need to repeat the ZLIB condition for NFP and COMPRESSDEV_TEST.
> > 
> 
> I see. So, does this mean that NFP PMD is always enabled? Do we need a fix for that?

Exact