All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Thomas Schmitt" <scdbackup@gmx.net>
To: grub-devel@gnu.org
Cc: jeffbai@aosc.io
Subject: Re: [PATCH] util/grub-mkrescue: specify -iso-level 3 in xorriso options
Date: Wed, 20 Sep 2023 09:17:45 +0200	[thread overview]
Message-ID: <2551629672848525138@scdbackup.webframe.org> (raw)
In-Reply-To: <4cc8af80062837238ec026d30783eecb@aosc.io>

Hi,

Mingcong Bai <jeffbai@aosc.io> wrote:
> This is needed for architectures whose EFI executables has file names that
> exceeds the 8.3 (extension.suffix) convention, such as LoongArch64
> (bootloongarch64.efi).

In general -iso-level 3 is a harmless setting if the reading operating
system is Linux or MS-Windows. On other reading system your mileage may
vary. In any case level 3 is harmless if it is not actually needed, i.e.
all file names are 8.3 and all files are smaller than 4 GiB.

But i wonder:

- Why level 3 and not 2 ?

  If it is only about file name length, then -iso-level 2 would suffice
  and not enable file sizes of 4 GiB and larger. Such files have to be
  represented by more than one extent, which might be not supported by
  the BSDs and other systems.
  Especially in grub-core/fs/iso9660.c function grub_iso9660_read() i see
  a remark: "XXX: The file is stored in as a single extent" and cannot
  spot provisions to read more than one directory entry per file.
  So i doubt that GRUB is prepared for multi-extent files.

  (If somebody wants to test: libcdio has a small ISO image
   https://git.savannah.gnu.org/cgit/libcdio.git/tree/test/data/multi_extent_8k.iso
   of size 122 KB with artificially small extent size. So its file
   /multi_extent_file bears 8 extents although it has only 54 KB of size.
   Compare GRUB's representation of the file with that of GNU/Linux.)

- Why is the name bootloongarch64.efi a problem in the ISO filesystem ?

  The name length restriction of -iso-level 1 applies only to the dull
  ISO 9660 names, but not to Rock Ridge names, which GRUB uses if present.
  (Other than mkisofs or genisoimage, xorriso produces Rock Ridge by
   default. Just don't use option --norock.)


Have a nice day :)

Thomas


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  reply	other threads:[~2023-09-20  7:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-20  5:39 [PATCH] util/grub-mkrescue: specify -iso-level 3 in xorriso options jeffbai
2023-09-20  7:17 ` Thomas Schmitt [this message]
2023-09-20  7:53   ` Gerd Hoffmann
2023-09-20  9:16     ` Thomas Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2551629672848525138@scdbackup.webframe.org \
    --to=scdbackup@gmx.net \
    --cc=grub-devel@gnu.org \
    --cc=jeffbai@aosc.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.