From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE4CE258EC1 for ; Wed, 20 May 2026 01:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779240382; cv=none; b=Q9PIQZg1N+Pr8LoIGAlCmVaQamyxLqzIenwSHJ5aV7xf6ixDf37S21j1ufZPWwVupbbgFarYgAk++9DbwrYq4yDFsK4ZXSbkhi8xMpejOhtA22rsrEJpLJaK1z610LyKnA/2lcImZO3deiw8rTMePFo9GYv9CC5rEKkuesuv6vs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779240382; c=relaxed/simple; bh=cuwr5fGN4GoLEBnaLulAKcHHHWTQA3fUhwXs74XKqs4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kbq90k/Dm5/61CknGvfu74kKlHL/YhX5i61Kmo6waYO3l3ldxuPg0kS1RrpWNt/UHve5SdHPQoYSbcM/yOKEJIpfPV0NdkwQaRsygnm/bryYiveMk5AK2CoDvAOQfPEeGpXLQrdXByFLH4kDAGls/Yca5wgivA+pdUtprYztGNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=vU6N6YZQ; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="vU6N6YZQ" Message-ID: <2552567e-9e35-47f8-9c3b-cff2dac75ea3@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779240377; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cuwr5fGN4GoLEBnaLulAKcHHHWTQA3fUhwXs74XKqs4=; b=vU6N6YZQA7XvrEs4BlOqVePhtS4w0tI1N/aVcb2CYViR6pOTQA8lcmrQxGdIkLHEP/Vdhz 7AvNozBTFci/EFT4JIGukAxcCdRU5HquTbWhQlX8wGo7JQnfIpBVNrSkrpP/AyiTtmyHKQ 4kJTPfww7AGKygvIYDnKDbCYaOK5OB0= Date: Wed, 20 May 2026 09:26:06 +0800 Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH nf 2/2] selftests: netfilter: add nft_fib_nexthop test To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, pablo@netfilter.org, phil@nwl.cc, coreteam@netfilter.org References: <20260519041431.396218-1-jiayuan.chen@linux.dev> <20260519041431.396218-2-jiayuan.chen@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Jiayuan Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 5/20/26 2:53 AM, Florian Westphal wrote: > Specifially: 'Does the test need to verify the datapath actually > evaluated correctly?' and > 'It looks like the test also sets up an nftables counter rule but doesn't > verify if the rule actually matched any packets.' > > I prefer functionality test over 'bug trap' tests. Agreed -- functional verification is the right approach here.