From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F51716ABC2; Tue, 28 May 2024 13:23:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716902607; cv=none; b=TWy5nBo9TanjDiGCysKwKHgG4p9FD4blec8LU5KQ6JiC64rMn6AX89keB0g/1EZZAXgiPocPArRjDPtjScXI96hHqm7AZuvChg1T/jm1OQKHgdrLZ6z4yQ1ivAW+o/pWWQoawwvb3vp6OZQTrYIUMPHVzdvu1c+AsZy0M4yQASg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716902607; c=relaxed/simple; bh=VpoXeImvv+3zjups/cZs0SCyUkXvCCcET3oHfElZJnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=UlgkHmV0mBDdRvQPN8z5DDSU1ReRSfGfyDxErXT1hJoTF8E9QSTAClSr8BiA+HcF+Kt/BzCP4/5WE20rd9AQPqyzoUN3Si8DBxw6FCe9SZhf9Pypo3VhYevgHyCBmxmRQEaZKlGSQPeziXAbv8c+7ojlVRSqVU0FlSFs5PxAOgM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBwnL-00040P-DW; Tue, 28 May 2024 15:23:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij , Dmitry Yashin Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Yashin Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 15:23:14 +0200 Message-ID: <2553645.4XsnlVU6TS@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <1770701.X513TT2pbd@diego> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Am Dienstag, 28. Mai 2024, 14:18:35 CEST schrieb Dmitry Yashin: > Hi Heiko, >=20 > On 5/28/24 4:52 PM, Heiko St=C3=BCbner wrote: > > Hi Linus, > > > > Am Dienstag, 28. Mai 2024, 13:29:12 CEST schrieb Linus Walleij: > >> On Wed, May 15, 2024 at 2:17=E2=80=AFPM Dmitry Yashin wrote: > >> > >>> Some of the rk3308 iomux routes in rk3308_mux_route_data belong to > >>> the rk3308b SoC. Remove them and correct i2c3 routes. > >>> > >>> Fixes: 7825aeb7b208 ("pinctrl: rockchip: add rk3308 SoC support") > >>> Signed-off-by: Dmitry Yashin > >> While you guys are thinking about the RK3308B support, is this fix > >> something I can just apply? > > I'd think so. I've detailed stuff in my Review mail I just sent. > > Both the soc itself and also the affected pin functions are niche > > enough that this should not cause breakage. > > > > > > Heiko > > > > > > >=20 > Should i just drop 1/3 from V2 then? I guess just check the state of affairs once your v2 is ready ;-) . I.e. if LinusW grabs patch1 before you post v2, just drop it, otherwise send it along. > Thanks everyone for the feedback on this series. I'll prepare V2 based > on runtime chip detection with use of GRF_CHIP_ID. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82DD5C25B78 for ; Tue, 28 May 2024 13:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qTcXLTPUWVEnSzqGkTP9szUKubXRZ1ckC80QV5njlqg=; b=rOHq0x4VSg4Gz6 5A78Y7ZAF5tzRNzMlnkSCIqnO9e9/eFlC1bEa3dRHkz98GbRigPeEFpz9ehO4WCCDT/KWO0dkYFps 03Q7y4znLez7Slbl0m+5CVFMKY5TzgRINrEgmKggqf1BbVjfqwsj+M63cknRIY9tgjdVHTqXHLlyt EYKOxHcAx1cM9wxlKwmzbBe/VNIM8nxHbi/Oo6RwtIVUW6wYvU5R7fmsGQ3EcidtIABUm0YNk4TQM GJB1rXeDQ+imHnIn1Gu0w0bsn7rtiROErHh/ZzWQh6+odUL5+pePVcdLok+aTq9DlcgD6y3r30SaH cqgjMugl4ZlDgVwWK51A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBwnX-00000000mPL-3ato; Tue, 28 May 2024 13:23:27 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBwnU-00000000mNU-3A1G; Tue, 28 May 2024 13:23:25 +0000 Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBwnL-00040P-DW; Tue, 28 May 2024 15:23:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij , Dmitry Yashin Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Yashin Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 15:23:14 +0200 Message-ID: <2553645.4XsnlVU6TS@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <1770701.X513TT2pbd@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_062324_813909_6279D14D X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org QW0gRGllbnN0YWcsIDI4LiBNYWkgMjAyNCwgMTQ6MTg6MzUgQ0VTVCBzY2hyaWViIERtaXRyeSBZ YXNoaW46Cj4gSGkgSGVpa28sCj4gCj4gT24gNS8yOC8yNCA0OjUyIFBNLCBIZWlrbyBTdMO8Ym5l ciB3cm90ZToKPiA+IEhpIExpbnVzLAo+ID4KPiA+IEFtIERpZW5zdGFnLCAyOC4gTWFpIDIwMjQs IDEzOjI5OjEyIENFU1Qgc2NocmllYiBMaW51cyBXYWxsZWlqOgo+ID4+IE9uIFdlZCwgTWF5IDE1 LCAyMDI0IGF0IDI6MTfigK9QTSBEbWl0cnkgWWFzaGluIDxkbXQueWFzaGluQGdtYWlsLmNvbT4g d3JvdGU6Cj4gPj4KPiA+Pj4gU29tZSBvZiB0aGUgcmszMzA4IGlvbXV4IHJvdXRlcyBpbiByazMz MDhfbXV4X3JvdXRlX2RhdGEgYmVsb25nIHRvCj4gPj4+IHRoZSByazMzMDhiIFNvQy4gUmVtb3Zl IHRoZW0gYW5kIGNvcnJlY3QgaTJjMyByb3V0ZXMuCj4gPj4+Cj4gPj4+IEZpeGVzOiA3ODI1YWVi N2IyMDggKCJwaW5jdHJsOiByb2NrY2hpcDogYWRkIHJrMzMwOCBTb0Mgc3VwcG9ydCIpCj4gPj4+ IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBZYXNoaW4gPGRtdC55YXNoaW5AZ21haWwuY29tPgo+ID4+ IFdoaWxlIHlvdSBndXlzIGFyZSB0aGlua2luZyBhYm91dCB0aGUgUkszMzA4QiBzdXBwb3J0LCBp cyB0aGlzIGZpeAo+ID4+IHNvbWV0aGluZyBJIGNhbiBqdXN0IGFwcGx5Pwo+ID4gSSdkIHRoaW5r IHNvLiBJJ3ZlIGRldGFpbGVkIHN0dWZmIGluIG15IFJldmlldyBtYWlsIEkganVzdCBzZW50Lgo+ ID4gQm90aCB0aGUgc29jIGl0c2VsZiBhbmQgYWxzbyB0aGUgYWZmZWN0ZWQgcGluIGZ1bmN0aW9u cyBhcmUgbmljaGUKPiA+IGVub3VnaCB0aGF0IHRoaXMgc2hvdWxkIG5vdCBjYXVzZSBicmVha2Fn ZS4KPiA+Cj4gPgo+ID4gSGVpa28KPiA+Cj4gPgo+ID4KPiAKPiBTaG91bGQgaSBqdXN0IGRyb3Ag MS8zIGZyb20gVjIgdGhlbj8KCkkgZ3Vlc3MganVzdCBjaGVjayB0aGUgc3RhdGUgb2YgYWZmYWly cyBvbmNlIHlvdXIgdjIgaXMgcmVhZHkgOy0pIC4KCkkuZS4gaWYgTGludXNXIGdyYWJzIHBhdGNo MSBiZWZvcmUgeW91IHBvc3QgdjIsIGp1c3QgZHJvcCBpdCwgb3RoZXJ3aXNlCnNlbmQgaXQgYWxv bmcuCgoKPiBUaGFua3MgZXZlcnlvbmUgZm9yIHRoZSBmZWVkYmFjayBvbiB0aGlzIHNlcmllcy4g SSdsbCBwcmVwYXJlIFYyIGJhc2VkCj4gb24gcnVudGltZSBjaGlwIGRldGVjdGlvbiB3aXRoIHVz ZSBvZiBHUkZfQ0hJUF9JRC4KCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2CE2FC25B78 for ; Tue, 28 May 2024 13:23:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9vJUGTRdM1hcZayvF/z3e5kSzKH0VEcKl99DtKg2JZU=; b=S4vX/vShXwRmUZ udG+EasMTE/WGDFpNZl7G3+R31I3yFq5bRG29dCjiz+f4/HZOqmnF6sVZPZji7polki+rB408wxwN f5fubFDWCoiM17dyph5ogLOezwDfFFg+su2l60vP7FOhS68vqMhHyvv5IC36RxvuALkF25OChJ43S lPD283bshXRYURevH99+12tECikblrVBbF10MPOhqGlqJ1VHyEiz3tv84xtw/pZVo4oqHPV/RORNR aJLgT+yH2Ai6cFuB3JlrxvzLeMEWJwuyYQF51kZpLD359PzmEd8quVuEZmEERsyuSqadW6LA3Z305 Fx85XM1/BffAJBmfdv9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBwnX-00000000mPC-0yHr; Tue, 28 May 2024 13:23:27 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sBwnU-00000000mNU-3A1G; Tue, 28 May 2024 13:23:25 +0000 Received: from i5e86193d.versanet.de ([94.134.25.61] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sBwnL-00040P-DW; Tue, 28 May 2024 15:23:15 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Linus Walleij , Dmitry Yashin Cc: Krzysztof Kozlowski , Conor Dooley , Rob Herring , Luca Ceresoli , Jianqun Xu , devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Yashin Subject: Re: [PATCH 1/3] pinctrl: rockchip: update rk3308 iomux routes Date: Tue, 28 May 2024 15:23:14 +0200 Message-ID: <2553645.4XsnlVU6TS@diego> In-Reply-To: References: <20240515121634.23945-1-dmt.yashin@gmail.com> <1770701.X513TT2pbd@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240528_062324_813909_6279D14D X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org QW0gRGllbnN0YWcsIDI4LiBNYWkgMjAyNCwgMTQ6MTg6MzUgQ0VTVCBzY2hyaWViIERtaXRyeSBZ YXNoaW46Cj4gSGkgSGVpa28sCj4gCj4gT24gNS8yOC8yNCA0OjUyIFBNLCBIZWlrbyBTdMO8Ym5l ciB3cm90ZToKPiA+IEhpIExpbnVzLAo+ID4KPiA+IEFtIERpZW5zdGFnLCAyOC4gTWFpIDIwMjQs IDEzOjI5OjEyIENFU1Qgc2NocmllYiBMaW51cyBXYWxsZWlqOgo+ID4+IE9uIFdlZCwgTWF5IDE1 LCAyMDI0IGF0IDI6MTfigK9QTSBEbWl0cnkgWWFzaGluIDxkbXQueWFzaGluQGdtYWlsLmNvbT4g d3JvdGU6Cj4gPj4KPiA+Pj4gU29tZSBvZiB0aGUgcmszMzA4IGlvbXV4IHJvdXRlcyBpbiByazMz MDhfbXV4X3JvdXRlX2RhdGEgYmVsb25nIHRvCj4gPj4+IHRoZSByazMzMDhiIFNvQy4gUmVtb3Zl IHRoZW0gYW5kIGNvcnJlY3QgaTJjMyByb3V0ZXMuCj4gPj4+Cj4gPj4+IEZpeGVzOiA3ODI1YWVi N2IyMDggKCJwaW5jdHJsOiByb2NrY2hpcDogYWRkIHJrMzMwOCBTb0Mgc3VwcG9ydCIpCj4gPj4+ IFNpZ25lZC1vZmYtYnk6IERtaXRyeSBZYXNoaW4gPGRtdC55YXNoaW5AZ21haWwuY29tPgo+ID4+ IFdoaWxlIHlvdSBndXlzIGFyZSB0aGlua2luZyBhYm91dCB0aGUgUkszMzA4QiBzdXBwb3J0LCBp cyB0aGlzIGZpeAo+ID4+IHNvbWV0aGluZyBJIGNhbiBqdXN0IGFwcGx5Pwo+ID4gSSdkIHRoaW5r IHNvLiBJJ3ZlIGRldGFpbGVkIHN0dWZmIGluIG15IFJldmlldyBtYWlsIEkganVzdCBzZW50Lgo+ ID4gQm90aCB0aGUgc29jIGl0c2VsZiBhbmQgYWxzbyB0aGUgYWZmZWN0ZWQgcGluIGZ1bmN0aW9u cyBhcmUgbmljaGUKPiA+IGVub3VnaCB0aGF0IHRoaXMgc2hvdWxkIG5vdCBjYXVzZSBicmVha2Fn ZS4KPiA+Cj4gPgo+ID4gSGVpa28KPiA+Cj4gPgo+ID4KPiAKPiBTaG91bGQgaSBqdXN0IGRyb3Ag MS8zIGZyb20gVjIgdGhlbj8KCkkgZ3Vlc3MganVzdCBjaGVjayB0aGUgc3RhdGUgb2YgYWZmYWly cyBvbmNlIHlvdXIgdjIgaXMgcmVhZHkgOy0pIC4KCkkuZS4gaWYgTGludXNXIGdyYWJzIHBhdGNo MSBiZWZvcmUgeW91IHBvc3QgdjIsIGp1c3QgZHJvcCBpdCwgb3RoZXJ3aXNlCnNlbmQgaXQgYWxv bmcuCgoKPiBUaGFua3MgZXZlcnlvbmUgZm9yIHRoZSBmZWVkYmFjayBvbiB0aGlzIHNlcmllcy4g SSdsbCBwcmVwYXJlIFYyIGJhc2VkCj4gb24gcnVudGltZSBjaGlwIGRldGVjdGlvbiB3aXRoIHVz ZSBvZiBHUkZfQ0hJUF9JRC4KCgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2Vy bmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==